| Message ID | 20240917173249.158920-2-fabrizio.castro.jz@renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | Add support for the RZ/V2H Interrupt Control Unit | expand |
On Tue, 17 Sep 2024 18:32:44 +0100, Fabrizio Castro wrote: > All the platforms from the renesas,rzg2l-pinctrl.yaml binding > actually require the interrupt-parent property. Add it. > > Fixes: 35c37efd1273 ("dt-bindings: pinctrl: renesas,rzg2l-pinctrl: Document the properties to handle GPIO IRQ") > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com> > --- > .../devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.example.dtb: pinctrl@11030000: 'interrupt-parent' is a required property from schema $id: http://devicetree.org/schemas/pinctrl/renesas,rzg2l-pinctrl.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240917173249.158920-2-fabrizio.castro.jz@renesas.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Tue, Sep 17, 2024 at 06:32:44PM +0100, Fabrizio Castro wrote: > All the platforms from the renesas,rzg2l-pinctrl.yaml binding > actually require the interrupt-parent property. Add it. But they don't require it. It *never* is required. If interrupt-parent is not found in a node, the parent will be checked. The check failure is because the example extraction has to play with interrupt-parent to make interrupt parsing work. > > Fixes: 35c37efd1273 ("dt-bindings: pinctrl: renesas,rzg2l-pinctrl: Document the properties to handle GPIO IRQ") > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com> > --- > .../devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml | 4 ++++ > 1 file changed, 4 insertions(+) >
Hi Rob, Thank you for your reply. > From: Rob Herring <robh@kernel.org> > Sent: Tuesday, September 17, 2024 11:15 PM > To: Fabrizio Castro <fabrizio.castro.jz@renesas.com> > Subject: Re: [PATCH 1/6] dt-bindings: pinctrl: renesas: rzg2l-pinctrl: Add interrupt-parent > > On Tue, Sep 17, 2024 at 06:32:44PM +0100, Fabrizio Castro wrote: > > All the platforms from the renesas,rzg2l-pinctrl.yaml binding actually > > require the interrupt-parent property. Add it. > > But they don't require it. It *never* is required. If interrupt-parent is not found in a node, the > parent will be checked. Indeed. I am dropping this patch. > > The check failure is because the example extraction has to play with interrupt-parent to make interrupt > parsing work. Gotcha. Thank you for the explanation. Cheers, Fab > > > > > Fixes: 35c37efd1273 ("dt-bindings: pinctrl: renesas,rzg2l-pinctrl: > > Document the properties to handle GPIO IRQ") > > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com> > > --- > > .../devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml | 4 ++++ > > 1 file changed, 4 insertions(+) > >
diff --git a/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml index 56d90c8e1fa3..10f724e87ae7 100644 --- a/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml @@ -51,6 +51,8 @@ properties: interrupt-controller: true + interrupt-parent: true + '#interrupt-cells': const: 2 description: @@ -155,6 +157,7 @@ required: - '#gpio-cells' - gpio-ranges - interrupt-controller + - interrupt-parent - '#interrupt-cells' - clocks - power-domains @@ -174,6 +177,7 @@ examples: gpio-ranges = <&pinctrl 0 0 392>; interrupt-controller; #interrupt-cells = <2>; + interrupt-parent = <&irqc>; clocks = <&cpg CPG_MOD R9A07G044_GPIO_HCLK>; resets = <&cpg R9A07G044_GPIO_RSTN>, <&cpg R9A07G044_GPIO_PORT_RESETN>,
All the platforms from the renesas,rzg2l-pinctrl.yaml binding actually require the interrupt-parent property. Add it. Fixes: 35c37efd1273 ("dt-bindings: pinctrl: renesas,rzg2l-pinctrl: Document the properties to handle GPIO IRQ") Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com> --- .../devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml | 4 ++++ 1 file changed, 4 insertions(+)