diff mbox series

ARM: dts: renesas: genmai: update audio codec bindings

Message ID 20240925090812.14497-2-wsa+renesas@sang-engineering.com (mailing list archive)
State Mainlined
Commit dcb207f141cb6896a991623a860ac4a9fb3136c9
Delegated to: Geert Uytterhoeven
Headers show
Series ARM: dts: renesas: genmai: update audio codec bindings | expand

Commit Message

Wolfram Sang Sept. 25, 2024, 9:08 a.m. UTC
Meanwhile, bindings for the audio codec exist. Add dai-cells property
and limit max frequency accordingly:

  codec@0: '#sound-dai-cells' is a required property
  codec@0: spi-max-frequency: 5000000 is greater than the maximum of 526000

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 arch/arm/boot/dts/renesas/r7s72100-genmai.dts | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Geert Uytterhoeven Sept. 26, 2024, 1:11 p.m. UTC | #1
Hi Wolfram,

On Wed, Sep 25, 2024 at 11:08 AM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> Meanwhile, bindings for the audio codec exist. Add dai-cells property
> and limit max frequency accordingly:
>
>   codec@0: '#sound-dai-cells' is a required property
>   codec@0: spi-max-frequency: 5000000 is greater than the maximum of 526000
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.13, with s/bindings/device node/
in the one-line summary.

> --- a/arch/arm/boot/dts/renesas/r7s72100-genmai.dts
> +++ b/arch/arm/boot/dts/renesas/r7s72100-genmai.dts
> @@ -248,9 +248,10 @@ &spi4 {
>         status = "okay";
>
>         codec: codec@0 {
> +               #sound-dai-cells = <0>;

I'll move this to the end, to match generic property order.

>                 compatible = "wlf,wm8978";
>                 reg = <0>;
> -               spi-max-frequency = <5000000>;
> +               spi-max-frequency = <500000>;
>         };
>  };

Gr{oetje,eeting}s,

                        Geert
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/renesas/r7s72100-genmai.dts b/arch/arm/boot/dts/renesas/r7s72100-genmai.dts
index 2f14522d5b50..2d72daa4fac2 100644
--- a/arch/arm/boot/dts/renesas/r7s72100-genmai.dts
+++ b/arch/arm/boot/dts/renesas/r7s72100-genmai.dts
@@ -248,9 +248,10 @@  &spi4 {
 	status = "okay";
 
 	codec: codec@0 {
+		#sound-dai-cells = <0>;
 		compatible = "wlf,wm8978";
 		reg = <0>;
-		spi-max-frequency = <5000000>;
+		spi-max-frequency = <500000>;
 	};
 };