| Message ID | 20241003075342.17244-1-biju.das.jz@bp.renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | pinctrl: renesas: rzg2l: Fix missing return statement | expand |
On 10/3/24 10:53, Biju Das wrote: > Fix the missing return statement on the error path for > rzg2l_pinctrl_register(). > > Fixes: f73f63b24491 ("pinctrl: renesas: rzg2l: Use dev_err_probe()") > Reported-by: nobuhiro1.iwamatsu@toshiba.co.jp <nobuhiro1.iwamatsu@toshiba.co.jp> Hm, strange email? > Closes: https://lore.kernel.org/all/OS0PR01MB638837327E5487B71D88A70392712@OS0PR01MB6388.jpnprd01.prod.outlook.com/ > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > --- > drivers/pinctrl/renesas/pinctrl-rzg2l.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/renesas/pinctrl-rzg2l.c b/drivers/pinctrl/renesas/pinctrl-rzg2l.c > index 5a403915fed2..f913e8385ead 100644 > --- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c > +++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c > @@ -2710,7 +2710,7 @@ static int rzg2l_pinctrl_register(struct rzg2l_pinctrl *pctrl) > > ret = pinctrl_enable(pctrl->pctl); > if (ret) > - dev_err_probe(pctrl->dev, ret, "pinctrl enable failed\n"); > + return dev_err_probe(pctrl->dev, ret, "pinctrl enable failed\n"); Why tab after *return*? [...] MBR, Sergey
Hi Sergey, > -----Original Message----- > From: Sergey Shtylyov <s.shtylyov@omp.ru> > Sent: Thursday, October 3, 2024 9:17 AM > To: Biju Das <biju.das.jz@bp.renesas.com>; Linus Walleij <linus.walleij@linaro.org> > Cc: Geert Uytterhoeven <geert+renesas@glider.be>; linux-renesas-soc@vger.kernel.org; linux- > gpio@vger.kernel.org; Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>; biju.das.au > <biju.das.au@gmail.com>; nobuhiro1 . iwamatsu @ toshiba . co . jp <nobuhiro1.iwamatsu@toshiba.co.jp> > Subject: Re: [PATCH] pinctrl: renesas: rzg2l: Fix missing return statement > > On 10/3/24 10:53, Biju Das wrote: > > > Fix the missing return statement on the error path for > > rzg2l_pinctrl_register(). > > > > Fixes: f73f63b24491 ("pinctrl: renesas: rzg2l: Use dev_err_probe()") > > Reported-by: nobuhiro1.iwamatsu@toshiba.co.jp > > <nobuhiro1.iwamatsu@toshiba.co.jp> > > Hm, strange email? Oops, will fix this. > > > Closes: > > https://lore.kernel.org/all/OS0PR01MB638837327E5487B71D88A70392712@OS0 > > PR01MB6388.jpnprd01.prod.outlook.com/ > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > --- > > drivers/pinctrl/renesas/pinctrl-rzg2l.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/pinctrl/renesas/pinctrl-rzg2l.c > > b/drivers/pinctrl/renesas/pinctrl-rzg2l.c > > index 5a403915fed2..f913e8385ead 100644 > > --- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c > > +++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c > > @@ -2710,7 +2710,7 @@ static int rzg2l_pinctrl_register(struct > > rzg2l_pinctrl *pctrl) > > > > ret = pinctrl_enable(pctrl->pctl); > > if (ret) > > - dev_err_probe(pctrl->dev, ret, "pinctrl enable failed\n"); > > + return dev_err_probe(pctrl->dev, ret, "pinctrl enable failed\n"); > > Why tab after *return*? Will fix this as well. Cheers, Biju
diff --git a/drivers/pinctrl/renesas/pinctrl-rzg2l.c b/drivers/pinctrl/renesas/pinctrl-rzg2l.c index 5a403915fed2..f913e8385ead 100644 --- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c +++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c @@ -2710,7 +2710,7 @@ static int rzg2l_pinctrl_register(struct rzg2l_pinctrl *pctrl) ret = pinctrl_enable(pctrl->pctl); if (ret) - dev_err_probe(pctrl->dev, ret, "pinctrl enable failed\n"); + return dev_err_probe(pctrl->dev, ret, "pinctrl enable failed\n"); ret = rzg2l_gpio_register(pctrl); if (ret)
Fix the missing return statement on the error path for rzg2l_pinctrl_register(). Fixes: f73f63b24491 ("pinctrl: renesas: rzg2l: Use dev_err_probe()") Reported-by: nobuhiro1.iwamatsu@toshiba.co.jp <nobuhiro1.iwamatsu@toshiba.co.jp> Closes: https://lore.kernel.org/all/OS0PR01MB638837327E5487B71D88A70392712@OS0PR01MB6388.jpnprd01.prod.outlook.com/ Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> --- drivers/pinctrl/renesas/pinctrl-rzg2l.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)