| Message ID | 20241219-v4-vspx-id-v1-1-e45225b02bf3@ideasonboard.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Kieran Bingham |
| Headers | show |
| Series | media: renesas: vsp1: Add support for VSPX | expand |
Hi Jacopo, Thank you for the patch. On Thu, Dec 19, 2024 at 06:40:13PM +0100, Jacopo Mondi wrote: > Add support for VSPX to the vsp1 driver. > > VSPX is an instance of Renesas VSP2 IP found on R-Car gen4 SoCs > that performs external memory access on behalf of the ISP. > > Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> That's missing a +renesas suffix (same in the From: address). With that, Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > Add an vsp1_device_info entry for Gen4 VSPX. > > VSPX will likely need custom features, hence do no set any feature > for the time being to prepare to expand later on. > --- > drivers/media/platform/renesas/vsp1/vsp1_drv.c | 10 ++++++++++ > drivers/media/platform/renesas/vsp1/vsp1_regs.h | 1 + > 2 files changed, 11 insertions(+) > > diff --git a/drivers/media/platform/renesas/vsp1/vsp1_drv.c b/drivers/media/platform/renesas/vsp1/vsp1_drv.c > index 9fc6bf624a520ae38e9c5f30dfa4dfa412eec38e..4dfc5e1640264f23772964f2b48c66d76599cb70 100644 > --- a/drivers/media/platform/renesas/vsp1/vsp1_drv.c > +++ b/drivers/media/platform/renesas/vsp1/vsp1_drv.c > @@ -835,6 +835,16 @@ static const struct vsp1_device_info vsp1_device_infos[] = { > .uif_count = 2, > .wpf_count = 1, > .num_bru_inputs = 5, > + }, { > + .version = VI6_IP_VERSION_MODEL_VSPX_GEN4, > + .model = "VSP2-X", > + .gen = 4, > + .features = 0, > + .lif_count = 0, > + .rpf_count = 2, > + .uif_count = 0, > + .wpf_count = 0, > + .num_bru_inputs = 2, > }, > }; > > diff --git a/drivers/media/platform/renesas/vsp1/vsp1_regs.h b/drivers/media/platform/renesas/vsp1/vsp1_regs.h > index 7eca82e0ba7ec5e02a5f3b9a30ccdcb48db39ed2..75e064429f4e231ecd2e291a10c09931e8096a97 100644 > --- a/drivers/media/platform/renesas/vsp1/vsp1_regs.h > +++ b/drivers/media/platform/renesas/vsp1/vsp1_regs.h > @@ -791,6 +791,7 @@ > #define VI6_IP_VERSION_MODEL_VSPDL_GEN3 (0x19 << 8) > #define VI6_IP_VERSION_MODEL_VSPBS_GEN3 (0x1a << 8) > #define VI6_IP_VERSION_MODEL_VSPD_GEN4 (0x1c << 8) > +#define VI6_IP_VERSION_MODEL_VSPX_GEN4 (0x1d << 8) > /* RZ/G2L SoCs have no version register, So use 0x80 as the model version */ > #define VI6_IP_VERSION_MODEL_VSPD_RZG2L (0x80 << 8) > > > --- > base-commit: 50d451b19cc58cf374160e30cbf72a5ed5b1b129 > change-id: 20241219-v4-vspx-id-1dd2bb4aedfd
diff --git a/drivers/media/platform/renesas/vsp1/vsp1_drv.c b/drivers/media/platform/renesas/vsp1/vsp1_drv.c index 9fc6bf624a520ae38e9c5f30dfa4dfa412eec38e..4dfc5e1640264f23772964f2b48c66d76599cb70 100644 --- a/drivers/media/platform/renesas/vsp1/vsp1_drv.c +++ b/drivers/media/platform/renesas/vsp1/vsp1_drv.c @@ -835,6 +835,16 @@ static const struct vsp1_device_info vsp1_device_infos[] = { .uif_count = 2, .wpf_count = 1, .num_bru_inputs = 5, + }, { + .version = VI6_IP_VERSION_MODEL_VSPX_GEN4, + .model = "VSP2-X", + .gen = 4, + .features = 0, + .lif_count = 0, + .rpf_count = 2, + .uif_count = 0, + .wpf_count = 0, + .num_bru_inputs = 2, }, }; diff --git a/drivers/media/platform/renesas/vsp1/vsp1_regs.h b/drivers/media/platform/renesas/vsp1/vsp1_regs.h index 7eca82e0ba7ec5e02a5f3b9a30ccdcb48db39ed2..75e064429f4e231ecd2e291a10c09931e8096a97 100644 --- a/drivers/media/platform/renesas/vsp1/vsp1_regs.h +++ b/drivers/media/platform/renesas/vsp1/vsp1_regs.h @@ -791,6 +791,7 @@ #define VI6_IP_VERSION_MODEL_VSPDL_GEN3 (0x19 << 8) #define VI6_IP_VERSION_MODEL_VSPBS_GEN3 (0x1a << 8) #define VI6_IP_VERSION_MODEL_VSPD_GEN4 (0x1c << 8) +#define VI6_IP_VERSION_MODEL_VSPX_GEN4 (0x1d << 8) /* RZ/G2L SoCs have no version register, So use 0x80 as the model version */ #define VI6_IP_VERSION_MODEL_VSPD_RZG2L (0x80 << 8)
Add support for VSPX to the vsp1 driver. VSPX is an instance of Renesas VSP2 IP found on R-Car gen4 SoCs that performs external memory access on behalf of the ISP. Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> --- Add an vsp1_device_info entry for Gen4 VSPX. VSPX will likely need custom features, hence do no set any feature for the time being to prepare to expand later on. --- drivers/media/platform/renesas/vsp1/vsp1_drv.c | 10 ++++++++++ drivers/media/platform/renesas/vsp1/vsp1_regs.h | 1 + 2 files changed, 11 insertions(+) --- base-commit: 50d451b19cc58cf374160e30cbf72a5ed5b1b129 change-id: 20241219-v4-vspx-id-1dd2bb4aedfd Best regards,