From patchwork Fri Dec 20 11:33:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 13916632 X-Patchwork-Delegate: geert@linux-m68k.org Received: from mail.zeus03.de (zeus03.de [194.117.254.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 800F31BD00A for ; Fri, 20 Dec 2024 11:33:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.117.254.33 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734694421; cv=none; b=Xwoa+kIOje4D0uvlpjybkIPTymve+8pEtqNlAF0pyptxSQisjpGosUVYRUc6yZ2v/ScZf+xwMm8OegI+My0uxSEGe307lLtcpPnSHlJW6dCWg5cECEv1sVhJ/4gylXBvGIqa8v/Om0Ydk6QwLvpwUZ7tG7mPC/Nmo9HGs4LF/vM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734694421; c=relaxed/simple; bh=+r130rckWcX6jYdn+Ln3jDvzy6JOxhEl+3WKkuSt1qw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=fxIXMJXVn8URtrtbjcPrNTR1EU6+tLaaBJZf/F0ssLP5D53ZYxt89JQErC58NpgdySC2LcaL2hPpDliMDUcoMhxaAIlTCCdY5wcNGxQBfwT+BJ+JdGGIsVK4Tn55Lq1tbSA00JoV4ezcl+bHdTDnTLJoBaZqYdM+8g0wUbhisYE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com; spf=pass smtp.mailfrom=sang-engineering.com; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b=HOfd6rth; arc=none smtp.client-ip=194.117.254.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b="HOfd6rth" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; s=k1; bh=JTVYffu7bObqCnm7BryRbyhmBYXN9UAwW1f5OWePOno=; b=HOfd6r thrpQ4Z1iKg1lV10bbLXXLAv0bJjlmc2QLWt7mjWQHkd5X02kvj4KDMwL4SeUmKC VfzrSienSOqIBUQ9NGXvBNHIUDsTqbjoSzyLAMKNKY/t0S4i24n7GSg84jVU3LMd KqrZyxW/tZWCyp201EyiqOFjRpmmzx2Ux0Pk+Jjwk/fVfZAApYbpG3l7JZsfgJbZ i4vJ8ZuiV5JA1q9dlecFGLuYID6vaxI1mtCyUUun9NipB2tLFRwyBLh2TptG3EEc ijBtNqexA++R0K4Gn8XRuW6s9eymaTuU7CkIeEJg4UuWErHhvW+wQXbatkz5x1Is K2jLozDFsnoqHl3w== Received: (qmail 990974 invoked from network); 20 Dec 2024 12:33:37 +0100 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 20 Dec 2024 12:33:37 +0100 X-UD-Smtp-Session: l3s3148p1@KYCKBLIpzuIujnsY From: Wolfram Sang To: linux-renesas-soc@vger.kernel.org Cc: Yury Norov , linux-i3c@lists.infradead.org, Wolfram Sang , Alexandre Belloni Subject: [PATCH RFT RESEND 3/5] i3c: dw: use get_parity8 helper instead of open coding it Date: Fri, 20 Dec 2024 12:33:31 +0100 Message-Id: <20241220113335.17937-4-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20241220113335.17937-1-wsa+renesas@sang-engineering.com> References: <20241220113335.17937-1-wsa+renesas@sang-engineering.com> Precedence: bulk X-Mailing-List: linux-renesas-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The kernel has now a generic helper for getting parity with easier to understand semantics. Make use of it. Signed-off-by: Wolfram Sang --- drivers/i3c/master/dw-i3c-master.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c index d4b80eb8cecd..a6d7fade5007 100644 --- a/drivers/i3c/master/dw-i3c-master.c +++ b/drivers/i3c/master/dw-i3c-master.c @@ -251,14 +251,6 @@ struct dw_i3c_i2c_dev_data { struct i3c_generic_ibi_pool *ibi_pool; }; -static u8 even_parity(u8 p) -{ - p ^= p >> 4; - p &= 0xf; - - return (0x9669 >> p) & 1; -} - static bool dw_i3c_master_supports_ccc_cmd(struct i3c_master_controller *m, const struct i3c_ccc_cmd *cmd) { @@ -848,7 +840,7 @@ static int dw_i3c_master_daa(struct i3c_master_controller *m) struct dw_i3c_xfer *xfer; struct dw_i3c_cmd *cmd; u32 olddevs, newdevs; - u8 p, last_addr = 0; + u8 last_addr = 0; int ret, pos; ret = pm_runtime_resume_and_get(master->dev); @@ -873,9 +865,9 @@ static int dw_i3c_master_daa(struct i3c_master_controller *m) } master->devs[pos].addr = ret; - p = even_parity(ret); last_addr = ret; - ret |= (p << 7); + + ret |= get_parity8(ret) ? 0 : BIT(7); writel(DEV_ADDR_TABLE_DYNAMIC_ADDR(ret), master->regs +