From patchwork Mon Jan 6 09:27:22 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 13927092 X-Patchwork-Delegate: geert@linux-m68k.org Received: from mail.zeus03.de (zeus03.de [194.117.254.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F5F51D90D9 for ; Mon, 6 Jan 2025 09:27:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.117.254.33 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736155659; cv=none; b=clw8DeAWOUhtje4TUpPaxAHfNQbT5USsMcxuAa01P39/QDKhU3ECZ7dWuL9tQxwIMEwMccgIAZQwMMTysPvpjcoUG7XAPAgTegUWHBp/UVjxNya/mqNLYPmUeyOd2bmRnzAjOQTBloUK6V2mPvyHsf+/g4dd5an0otHAYdbpBjQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736155659; c=relaxed/simple; bh=8WpB9HpuWYM/wsrLWrv8HYgqR+4+o35bNEuFKKZFvr8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rO2TnegH/yDIDcB4CKidB9kjGVhxQSLQh1hzIRohBGw+/gWEOOvzLWR83QyzNQKsLP2SBXUI7krNHfJ+o0vc63PXGZu1dDf3Q9tMe8+xgf9j52r/yEq8C3vCbtVRq3Gl/g01TAto5q8Jw6OeQ5SL7joLOyVOUxhQ3EnSmS9B798= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com; spf=pass smtp.mailfrom=sang-engineering.com; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b=Qij2CcLM; arc=none smtp.client-ip=194.117.254.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b="Qij2CcLM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; s=k1; bh=Ta1yRvPmk5gWC8V3XFdegSgto4i6026D0epR4X2xhig=; b=Qij2Cc LM1RRwo4VymSORu7F1VP1pfl+/P/5ihzXTIQ3pRpn7s0AbMSvkfUL7WYdHgE7cuC +upm6jeCmLdl31m9iYkwgQQSbPm7Ke2bLolDl06mD5tJYynbBQc6DZlYSm7Hv8Y0 Cn3/u9NOhlxez0uxP1E1wMEgDvgKWVxt4pW03bJFSbGABFwEWRUQFhDzUF4SXdE6 sx7wGBmzZFp77+Az+Wo4AZyISdRcZ41ZwNk2zRQmf/K8f7V7tmHEKVEz+aPPw65j 5FV4WYpRpRvOWIPLOOUApUmjJooXGgCVVLFbDgtMJiYWVjneqapQynCfuiSUXI/s eN+wjJbiJocPxZ9g== Received: (qmail 1727955 invoked from network); 6 Jan 2025 10:27:29 +0100 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 6 Jan 2025 10:27:29 +0100 X-UD-Smtp-Session: l3s3148p1@rny7PAYr/JsgAwDPXw20AOMQ2KO98fSH From: Wolfram Sang To: linux-i3c@lists.infradead.org Cc: linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Wolfram Sang , Jarkko Nikula , Alexandre Belloni Subject: [PATCH v3 4/5] i3c: mipi-i3c-hci: use parity8 helper instead of open coding it Date: Mon, 6 Jan 2025 10:27:22 +0100 Message-ID: <20250106092725.22869-5-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250106092725.22869-1-wsa+renesas@sang-engineering.com> References: <20250106092725.22869-1-wsa+renesas@sang-engineering.com> Precedence: bulk X-Mailing-List: linux-renesas-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The kernel has now a generic helper for getting parity with easier to understand semantics. Make use of it. Signed-off-by: Wolfram Sang Tested-by: Jarkko Nikula --- drivers/i3c/master/mipi-i3c-hci/dat_v1.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/i3c/master/mipi-i3c-hci/dat_v1.c b/drivers/i3c/master/mipi-i3c-hci/dat_v1.c index 47b9b4d4ed3f..85c4916972e4 100644 --- a/drivers/i3c/master/mipi-i3c-hci/dat_v1.c +++ b/drivers/i3c/master/mipi-i3c-hci/dat_v1.c @@ -40,15 +40,6 @@ #define dat_w0_write(i, v) writel(v, hci->DAT_regs + (i) * 8) #define dat_w1_write(i, v) writel(v, hci->DAT_regs + (i) * 8 + 4) -static inline bool dynaddr_parity(unsigned int addr) -{ - addr |= 1 << 7; - addr += addr >> 4; - addr += addr >> 2; - addr += addr >> 1; - return (addr & 1); -} - static int hci_dat_v1_init(struct i3c_hci *hci) { unsigned int dat_idx; @@ -123,7 +114,7 @@ static void hci_dat_v1_set_dynamic_addr(struct i3c_hci *hci, dat_w0 = dat_w0_read(dat_idx); dat_w0 &= ~(DAT_0_DYNAMIC_ADDRESS | DAT_0_DYNADDR_PARITY); dat_w0 |= FIELD_PREP(DAT_0_DYNAMIC_ADDRESS, address) | - (dynaddr_parity(address) ? DAT_0_DYNADDR_PARITY : 0); + (parity8(address) ? 0 : DAT_0_DYNADDR_PARITY); dat_w0_write(dat_idx, dat_w0); }