| Message ID | 20250106104458.3596109-1-niklas.soderlund+renesas@ragnatech.se (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | f68e655c6fa4aa9748588d82df147f7a0f95141a |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | arm64: dts: renesas: white-hawk-csi-dsi: Define numerical CSI-2 data line orders | expand |
On Mon, Jan 6, 2025 at 11:45 AM Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> wrote: > The second CSI-2 C-PHY data-lane have a different line order (BCA) then > the two other data-lanes (ABC) for both connected CSI-2 receivers, > describe this in the device tree. > > This have worked in the past as the R-Car CSI-2 driver did not have > documentation for the line order configuration and a magic value was > written to the register for this specific setup. Now the registers > involved are documented and the hardware description as well as the > driver needs to be corrected. > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > --- > In this change the numerical values for the line-orders are used as the > changes video-interfaces.h are not yet in the renesas tree and it's a > good idea to get this DTS change in the same release as the driver > change. Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> i.e. will queue in renesas-devel for v6.14. Gr{oetje,eeting}s, Geert
diff --git a/arch/arm64/boot/dts/renesas/white-hawk-csi-dsi.dtsi b/arch/arm64/boot/dts/renesas/white-hawk-csi-dsi.dtsi index 3006b0a64f41..9017c4475a7c 100644 --- a/arch/arm64/boot/dts/renesas/white-hawk-csi-dsi.dtsi +++ b/arch/arm64/boot/dts/renesas/white-hawk-csi-dsi.dtsi @@ -21,6 +21,7 @@ csi40_in: endpoint { bus-type = <MEDIA_BUS_TYPE_CSI2_CPHY>; clock-lanes = <0>; data-lanes = <1 2 3>; + line-orders = <0 3 0>; remote-endpoint = <&max96712_out0>; }; }; @@ -41,6 +42,7 @@ csi41_in: endpoint { bus-type = <MEDIA_BUS_TYPE_CSI2_CPHY>; clock-lanes = <0>; data-lanes = <1 2 3>; + line-orders = <0 3 0>; remote-endpoint = <&max96712_out1>; }; };
The second CSI-2 C-PHY data-lane have a different line order (BCA) then the two other data-lanes (ABC) for both connected CSI-2 receivers, describe this in the device tree. This have worked in the past as the R-Car CSI-2 driver did not have documentation for the line order configuration and a magic value was written to the register for this specific setup. Now the registers involved are documented and the hardware description as well as the driver needs to be corrected. Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> --- In this change the numerical values for the line-orders are used as the changes video-interfaces.h are not yet in the renesas tree and it's a good idea to get this DTS change in the same release as the driver change. --- arch/arm64/boot/dts/renesas/white-hawk-csi-dsi.dtsi | 2 ++ 1 file changed, 2 insertions(+)