| Message ID | 20250212182034.366167-3-fabrizio.castro.jz@renesas.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | Improvements for the RZ/G2L IRQC driver | expand |
On Wed, Feb 12, 2025 at 6:32 PM Fabrizio Castro <fabrizio.castro.jz@renesas.com> wrote: > > Use devm_reset_control_get_exclusive_deasserted() to simplify > rzg2l_irqc_common_init(). > > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com> > --- > drivers/irqchip/irq-renesas-rzg2l.c | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Cheers, Prabhakar > diff --git a/drivers/irqchip/irq-renesas-rzg2l.c b/drivers/irqchip/irq-renesas-rzg2l.c > index a7c3a3cc6b9f..a29c40466137 100644 > --- a/drivers/irqchip/irq-renesas-rzg2l.c > +++ b/drivers/irqchip/irq-renesas-rzg2l.c > @@ -562,14 +562,10 @@ static int rzg2l_irqc_common_init(struct device_node *node, struct device_node * > return ret; > } > > - resetn = devm_reset_control_get_exclusive(dev, NULL); > - if (IS_ERR(resetn)) > + resetn = devm_reset_control_get_exclusive_deasserted(dev, NULL); > + if (IS_ERR(resetn)) { > + dev_err(dev, "failed to acquire deasserted reset: %d\n", ret); > return PTR_ERR(resetn); > - > - ret = reset_control_deassert(resetn); > - if (ret) { > - dev_err(dev, "failed to deassert resetn pin, %d\n", ret); > - return ret; > } > > pm_runtime_enable(dev); > @@ -609,7 +605,6 @@ static int rzg2l_irqc_common_init(struct device_node *node, struct device_node * > pm_runtime_put(dev); > pm_disable: > pm_runtime_disable(dev); > - reset_control_assert(resetn); > return ret; > } > > -- > 2.34.1 > >
On Mi, 2025-02-12 at 18:20 +0000, Fabrizio Castro wrote: > Use devm_reset_control_get_exclusive_deasserted() to simplify > rzg2l_irqc_common_init(). > > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com> Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de> regards Philipp
diff --git a/drivers/irqchip/irq-renesas-rzg2l.c b/drivers/irqchip/irq-renesas-rzg2l.c index a7c3a3cc6b9f..a29c40466137 100644 --- a/drivers/irqchip/irq-renesas-rzg2l.c +++ b/drivers/irqchip/irq-renesas-rzg2l.c @@ -562,14 +562,10 @@ static int rzg2l_irqc_common_init(struct device_node *node, struct device_node * return ret; } - resetn = devm_reset_control_get_exclusive(dev, NULL); - if (IS_ERR(resetn)) + resetn = devm_reset_control_get_exclusive_deasserted(dev, NULL); + if (IS_ERR(resetn)) { + dev_err(dev, "failed to acquire deasserted reset: %d\n", ret); return PTR_ERR(resetn); - - ret = reset_control_deassert(resetn); - if (ret) { - dev_err(dev, "failed to deassert resetn pin, %d\n", ret); - return ret; } pm_runtime_enable(dev); @@ -609,7 +605,6 @@ static int rzg2l_irqc_common_init(struct device_node *node, struct device_node * pm_runtime_put(dev); pm_disable: pm_runtime_disable(dev); - reset_control_assert(resetn); return ret; }
Use devm_reset_control_get_exclusive_deasserted() to simplify rzg2l_irqc_common_init(). Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com> --- drivers/irqchip/irq-renesas-rzg2l.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-)