diff mbox series

[4/6] irqchip/renesas-rzg2l: Remove pm_put label

Message ID 20250212182034.366167-5-fabrizio.castro.jz@renesas.com (mailing list archive)
State Accepted
Delegated to: Geert Uytterhoeven
Headers show
Series Improvements for the RZ/G2L IRQC driver | expand

Commit Message

Fabrizio Castro Feb. 12, 2025, 6:20 p.m. UTC 
No need to keep label `pm_put`, as it's only used once.
Call pm_runtime_put() directly from the error path.

Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
---
 drivers/irqchip/irq-renesas-rzg2l.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

Comments

Lad, Prabhakar Feb. 13, 2025, 9:41 a.m. UTC | #1 
On Wed, Feb 12, 2025 at 6:22 PM Fabrizio Castro
<fabrizio.castro.jz@renesas.com> wrote:
>
> No need to keep label `pm_put`, as it's only used once.
> Call pm_runtime_put() directly from the error path.
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> ---
>  drivers/irqchip/irq-renesas-rzg2l.c | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)
>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Cheers,
Prabhakar

> diff --git a/drivers/irqchip/irq-renesas-rzg2l.c b/drivers/irqchip/irq-renesas-rzg2l.c
> index c024023a1832..0f325ceb0f53 100644
> --- a/drivers/irqchip/irq-renesas-rzg2l.c
> +++ b/drivers/irqchip/irq-renesas-rzg2l.c
> @@ -586,9 +586,9 @@ static int rzg2l_irqc_common_init(struct device_node *node, struct device_node *
>                                               node, &rzg2l_irqc_domain_ops,
>                                               rzg2l_irqc_data);
>         if (!irq_domain) {
> +               pm_runtime_put(dev);
>                 dev_err(dev, "failed to add irq domain\n");
> -               ret = -ENOMEM;
> -               goto pm_put;
> +               return -ENOMEM;
>         }
>
>         register_syscore_ops(&rzg2l_irqc_syscore_ops);
> @@ -605,11 +605,6 @@ static int rzg2l_irqc_common_init(struct device_node *node, struct device_node *
>         dev = NULL;
>
>         return 0;
> -
> -pm_put:
> -       pm_runtime_put(dev);
> -
> -       return ret;
>  }
>
>  static int __init rzg2l_irqc_init(struct device_node *node,
> --
> 2.34.1
>
>
diff mbox series

Patch

diff --git a/drivers/irqchip/irq-renesas-rzg2l.c b/drivers/irqchip/irq-renesas-rzg2l.c
index c024023a1832..0f325ceb0f53 100644
--- a/drivers/irqchip/irq-renesas-rzg2l.c
+++ b/drivers/irqchip/irq-renesas-rzg2l.c
@@ -586,9 +586,9 @@  static int rzg2l_irqc_common_init(struct device_node *node, struct device_node *
 					      node, &rzg2l_irqc_domain_ops,
 					      rzg2l_irqc_data);
 	if (!irq_domain) {
+		pm_runtime_put(dev);
 		dev_err(dev, "failed to add irq domain\n");
-		ret = -ENOMEM;
-		goto pm_put;
+		return -ENOMEM;
 	}
 
 	register_syscore_ops(&rzg2l_irqc_syscore_ops);
@@ -605,11 +605,6 @@  static int rzg2l_irqc_common_init(struct device_node *node, struct device_node *
 	dev = NULL;
 
 	return 0;
-
-pm_put:
-	pm_runtime_put(dev);
-
-	return ret;
 }
 
 static int __init rzg2l_irqc_init(struct device_node *node,