| Message ID | 20250305163753.34913-3-fabrizio.castro.jz@renesas.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | Fix missing of_node_put() calls | expand |
On Wed, Mar 5, 2025 at 4:39 PM Fabrizio Castro <fabrizio.castro.jz@renesas.com> wrote: > > of_parse_phandle_with_fixed_args() requires its caller to > call into of_node_put() on the node pointer from the output > structure, but such a call is currently missing. > > Call into of_node_put() to rectify that. > > Fixes: c4c4637eb57f ("pinctrl: renesas: Add RZ/G2L pin and gpio controller driver") > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com> > --- > drivers/pinctrl/renesas/pinctrl-rzg2l.c | 2 ++ > 1 file changed, 2 insertions(+) > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Cheers, Prabhakar > diff --git a/drivers/pinctrl/renesas/pinctrl-rzg2l.c b/drivers/pinctrl/renesas/pinctrl-rzg2l.c > index 9280bc37a623..c72e250f4a15 100644 > --- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c > +++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c > @@ -2763,6 +2763,8 @@ static int rzg2l_gpio_register(struct rzg2l_pinctrl *pctrl) > if (ret) > return dev_err_probe(pctrl->dev, ret, "Unable to parse gpio-ranges\n"); > > + of_node_put(of_args.np); > + > if (of_args.args[0] != 0 || of_args.args[1] != 0 || > of_args.args[2] != pctrl->data->n_port_pins) > return dev_err_probe(pctrl->dev, -EINVAL, > -- > 2.34.1 > >
On Wed, 5 Mar 2025 at 17:38, Fabrizio Castro <fabrizio.castro.jz@renesas.com> wrote: > of_parse_phandle_with_fixed_args() requires its caller to > call into of_node_put() on the node pointer from the output > structure, but such a call is currently missing. > > Call into of_node_put() to rectify that. > > Fixes: c4c4637eb57f ("pinctrl: renesas: Add RZ/G2L pin and gpio controller driver") > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> i.e. will queue in renesas-pinctrl for v6.15. Gr{oetje,eeting}s, Geert
diff --git a/drivers/pinctrl/renesas/pinctrl-rzg2l.c b/drivers/pinctrl/renesas/pinctrl-rzg2l.c index 9280bc37a623..c72e250f4a15 100644 --- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c +++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c @@ -2763,6 +2763,8 @@ static int rzg2l_gpio_register(struct rzg2l_pinctrl *pctrl) if (ret) return dev_err_probe(pctrl->dev, ret, "Unable to parse gpio-ranges\n"); + of_node_put(of_args.np); + if (of_args.args[0] != 0 || of_args.args[1] != 0 || of_args.args[2] != pctrl->data->n_port_pins) return dev_err_probe(pctrl->dev, -EINVAL,
of_parse_phandle_with_fixed_args() requires its caller to call into of_node_put() on the node pointer from the output structure, but such a call is currently missing. Call into of_node_put() to rectify that. Fixes: c4c4637eb57f ("pinctrl: renesas: Add RZ/G2L pin and gpio controller driver") Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com> --- drivers/pinctrl/renesas/pinctrl-rzg2l.c | 2 ++ 1 file changed, 2 insertions(+)