[13/15] gpio: cs5535: use new line value setter callbacks

Message ID	20250310-gpiochip-set-conversion-v1-13-03798bb833eb@linaro.org (mailing list archive)
State	New
Delegated to:	Geert Uytterhoeven
Headers	show Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5452227EAE for <linux-renesas-soc@vger.kernel.org>; Mon, 10 Mar 2025 12:40:41 +0000 (UTC) From: Bartosz Golaszewski <brgl@bgdev.pl> Date: Mon, 10 Mar 2025 13:40:27 +0100 Subject: [PATCH 13/15] gpio: cs5535: use new line value setter callbacks Precedence: bulk MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250310-gpiochip-set-conversion-v1-13-03798bb833eb@linaro.org> References: <20250310-gpiochip-set-conversion-v1-0-03798bb833eb@linaro.org> In-Reply-To: <20250310-gpiochip-set-conversion-v1-0-03798bb833eb@linaro.org> To: Ray Jui <rjui@broadcom.com>, Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>, Linus Walleij <linus.walleij@linaro.org>, Bartosz Golaszewski <brgl@bgdev.pl>, Florian Fainelli <florian.fainelli@broadcom.com>, Scott Branden <sbranden@broadcom.com>, Matti Vaittinen <mazziesaccount@gmail.com>, Marek Vasut <marek.vasut+renesas@gmail.com>, Michael Buesch <m@bues.ch>, Thomas Richard <thomas.richard@bootlin.com>, Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>, Benson Leung <bleung@chromium.org>, Guenter Roeck <groeck@chromium.org>, Andy Shevchenko <andy@kernel.org>, Support Opensource <support.opensource@diasemi.com> Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, chrome-platform@lists.linux.dev, Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Series	gpio: more gpio_chip setter conversions \| expand [00/15] gpio: more gpio_chip setter conversions [01/15] gpio: bcm-kona: use lock guards [02/15] gpio: bcm-kona: use new line value setter callbacks [03/15] gpio: bd71815: use new line value setter callbacks [04/15] gpio: bd71828: use new line value setter callbacks [05/15] gpio: bd9571mwv: use new line value setter callbacks [06/15] gpio: bt8xx: allow to build the module with COMPILE_TEST=y [07/15] gpio: bt8xx: use lock guards [08/15] gpio: bt8xx: use new line value setter callbacks [09/15] gpio: cgbc: use new line value setter callbacks [10/15] gpio: creg-snps: use new line value setter callbacks [11/15] gpio: cros-ec: use new line value setter callbacks [12/15] gpio: crystalcove: use new line value setter callbacks [13/15] gpio: cs5535: use new line value setter callbacks [14/15] gpio: da9052: use new line value setter callbacks [15/15] gpio: da9055: use new line value setter callbacks

Message ID

20250310-gpiochip-set-conversion-v1-13-03798bb833eb@linaro.org (mailing list archive)

State

New

Delegated to:

Geert Uytterhoeven

Headers

From: Bartosz Golaszewski <brgl@bgdev.pl>
Date: Mon, 10 Mar 2025 13:40:27 +0100
Subject: [PATCH 13/15] gpio: cs5535: use new line value setter callbacks
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <20250310-gpiochip-set-conversion-v1-13-03798bb833eb@linaro.org>
References: <20250310-gpiochip-set-conversion-v1-0-03798bb833eb@linaro.org>
In-Reply-To: <20250310-gpiochip-set-conversion-v1-0-03798bb833eb@linaro.org>
To: Ray Jui <rjui@broadcom.com>,
 Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>,
 Linus Walleij <linus.walleij@linaro.org>,
 Bartosz Golaszewski <brgl@bgdev.pl>,
 Florian Fainelli <florian.fainelli@broadcom.com>,
 Scott Branden <sbranden@broadcom.com>,
 Matti Vaittinen <mazziesaccount@gmail.com>,
 Marek Vasut <marek.vasut+renesas@gmail.com>, Michael Buesch <m@bues.ch>,
 Thomas Richard <thomas.richard@bootlin.com>,
 Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
 Benson Leung <bleung@chromium.org>, Guenter Roeck <groeck@chromium.org>,
 Andy Shevchenko <andy@kernel.org>,
 Support Opensource <support.opensource@diasemi.com>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-renesas-soc@vger.kernel.org, chrome-platform@lists.linux.dev,
 Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Series

gpio: more gpio_chip setter conversions | expand

Commit Message

Bartosz Golaszewski March 10, 2025, 12:40 p.m. UTC

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
 drivers/gpio/gpio-cs5535.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/gpio/gpio-cs5535.c b/drivers/gpio/gpio-cs5535.c
index 6da3a247614a..143d1f4173a6 100644
--- a/drivers/gpio/gpio-cs5535.c
+++ b/drivers/gpio/gpio-cs5535.c
@@ -232,12 +232,14 @@  static int chip_gpio_get(struct gpio_chip *chip, unsigned offset)
 	return cs5535_gpio_isset(offset, GPIO_READ_BACK);
 }
 
-static void chip_gpio_set(struct gpio_chip *chip, unsigned offset, int val)
+static int chip_gpio_set(struct gpio_chip *chip, unsigned int offset, int val)
 {
 	if (val)
 		cs5535_gpio_set(offset, GPIO_OUTPUT_VAL);
 	else
 		cs5535_gpio_clear(offset, GPIO_OUTPUT_VAL);
+
+	return 0;
 }
 
 static int chip_direction_input(struct gpio_chip *c, unsigned offset)
@@ -294,7 +296,7 @@  static struct cs5535_gpio_chip cs5535_gpio_chip = {
 		.request = chip_gpio_request,
 
 		.get = chip_gpio_get,
-		.set = chip_gpio_set,
+		.set_rv = chip_gpio_set,
 
 		.direction_input = chip_direction_input,
 		.direction_output = chip_direction_output,

[13/15] gpio: cs5535: use new line value setter callbacks

Commit Message

Patch