| Message ID | 20250317083213.371614-2-tommaso.merciai.xr@bp.renesas.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | clk: renesas: rzv2h: Fixes and improvements | expand |
Hi Tommaso, On Mon, 17 Mar 2025 at 09:32, Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com> wrote: > Remove not needed "and" into description section. > > Reported-by: Pavel Machek <pavel@denx.de> > Closes: https://lore.kernel.org/cip-dev/Z9P%2F51qOlq2B46FK@duo.ucw.cz/ > Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com> Thanks for your patch! > --- a/Documentation/devicetree/bindings/clock/renesas,rzv2h-cpg.yaml > +++ b/Documentation/devicetree/bindings/clock/renesas,rzv2h-cpg.yaml > @@ -12,7 +12,7 @@ maintainers: > description: > On Renesas RZ/{G3E,V2H(P)} SoCs, the CPG (Clock Pulse Generator) handles > generation and control of clock signals for the IP modules, generation and > - control of resets, and control over booting, low power consumption and power > + control of resets, control over booting, low power consumption and power > supply domains. > > properties: I think the original is fine. When emphasizing the structure: The CPG handles: A. generation and control of clock signals for the IP modules, B. generation and control of resets, and C. control over booting, low power consumption and power supply domains. i.e. the "and" is part of the typical "A, B, and C" construct? Gr{oetje,eeting}s, Geert
Hi Geert, Thanks for your review. On Mon, Mar 17, 2025 at 11:08:19AM +0100, Geert Uytterhoeven wrote: > Hi Tommaso, > > On Mon, 17 Mar 2025 at 09:32, Tommaso Merciai > <tommaso.merciai.xr@bp.renesas.com> wrote: > > Remove not needed "and" into description section. > > > > Reported-by: Pavel Machek <pavel@denx.de> > > Closes: https://lore.kernel.org/cip-dev/Z9P%2F51qOlq2B46FK@duo.ucw.cz/ > > Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com> > > Thanks for your patch! > > > --- a/Documentation/devicetree/bindings/clock/renesas,rzv2h-cpg.yaml > > +++ b/Documentation/devicetree/bindings/clock/renesas,rzv2h-cpg.yaml > > @@ -12,7 +12,7 @@ maintainers: > > description: > > On Renesas RZ/{G3E,V2H(P)} SoCs, the CPG (Clock Pulse Generator) handles > > generation and control of clock signals for the IP modules, generation and > > - control of resets, and control over booting, low power consumption and power > > + control of resets, control over booting, low power consumption and power > > supply domains. > > > > properties: > > I think the original is fine. When emphasizing the structure: > > The CPG handles: > A. generation and control of clock signals for the IP modules, > B. generation and control of resets, and > C. control over booting, low power consumption and power supply domains. > > i.e. the "and" is part of the typical "A, B, and C" construct? Fine to me and thanks for the explanation. If you agree I will drop this in v2. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds Thanks & Regards, Tommaso
Hi! > On Mon, 17 Mar 2025 at 09:32, Tommaso Merciai > <tommaso.merciai.xr@bp.renesas.com> wrote: > > Remove not needed "and" into description section. > > > > Reported-by: Pavel Machek <pavel@denx.de> > > Closes: https://lore.kernel.org/cip-dev/Z9P%2F51qOlq2B46FK@duo.ucw.cz/ > > Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com> > > Thanks for your patch! > > > --- a/Documentation/devicetree/bindings/clock/renesas,rzv2h-cpg.yaml > > +++ b/Documentation/devicetree/bindings/clock/renesas,rzv2h-cpg.yaml > > @@ -12,7 +12,7 @@ maintainers: > > description: > > On Renesas RZ/{G3E,V2H(P)} SoCs, the CPG (Clock Pulse Generator) handles > > generation and control of clock signals for the IP modules, generation and > > - control of resets, and control over booting, low power consumption and power > > + control of resets, control over booting, low power consumption and power > > supply domains. > > > > properties: > > I think the original is fine. When emphasizing the structure: > > The CPG handles: > A. generation and control of clock signals for the IP modules, > B. generation and control of resets, and > C. control over booting, low power consumption and power supply domains. > > i.e. the "and" is part of the typical "A, B, and C" construct? Well, it is still horid sentence. What about making it into list, as you did? Best regards, Pavel
diff --git a/Documentation/devicetree/bindings/clock/renesas,rzv2h-cpg.yaml b/Documentation/devicetree/bindings/clock/renesas,rzv2h-cpg.yaml index c3fe76abd549..511692b7f84d 100644 --- a/Documentation/devicetree/bindings/clock/renesas,rzv2h-cpg.yaml +++ b/Documentation/devicetree/bindings/clock/renesas,rzv2h-cpg.yaml @@ -12,7 +12,7 @@ maintainers: description: On Renesas RZ/{G3E,V2H(P)} SoCs, the CPG (Clock Pulse Generator) handles generation and control of clock signals for the IP modules, generation and - control of resets, and control over booting, low power consumption and power + control of resets, control over booting, low power consumption and power supply domains. properties:
Remove not needed "and" into description section. Reported-by: Pavel Machek <pavel@denx.de> Closes: https://lore.kernel.org/cip-dev/Z9P%2F51qOlq2B46FK@duo.ucw.cz/ Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com> --- Documentation/devicetree/bindings/clock/renesas,rzv2h-cpg.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)