| Message ID | 20250329070329.32562-1-biju.das.jz@bp.renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | mmc: host: Kconfig: Fix undefined reference to rdev_get_drvdata() | expand |
On Sat, Mar 29, 2025 at 07:03:24AM +0000, Biju Das wrote: > The driver no longer builds when regulator support is unavailable. Fix > the build error undefined reference to rdev_get_drvdata() by selecting the > REGULATOR in config MMC_SDHI. As said in a previous mail: I'd suggest MMC_SDHI_INTERNAL_DMAC.
On Sat, Mar 29, 2025 at 08:18:08AM +0100, Wolfram Sang wrote: > On Sat, Mar 29, 2025 at 07:03:24AM +0000, Biju Das wrote: > > The driver no longer builds when regulator support is unavailable. Fix > > the build error undefined reference to rdev_get_drvdata() by selecting the > > REGULATOR in config MMC_SDHI. > > As said in a previous mail: I'd suggest MMC_SDHI_INTERNAL_DMAC. But let's add 'if ARCH_RENESAS' to leave at least SUPERH out?
Hi Wolfram, > -----Original Message----- > From: Wolfram Sang <wsa+renesas@sang-engineering.com> > Sent: 29 March 2025 07:34 > Subject: Re: [PATCH] mmc: host: Kconfig: Fix undefined reference to rdev_get_drvdata() > > On Sat, Mar 29, 2025 at 08:18:08AM +0100, Wolfram Sang wrote: > > On Sat, Mar 29, 2025 at 07:03:24AM +0000, Biju Das wrote: > > > The driver no longer builds when regulator support is unavailable. > > > Fix the build error undefined reference to rdev_get_drvdata() by > > > selecting the REGULATOR in config MMC_SDHI. > > > > As said in a previous mail: I'd suggest MMC_SDHI_INTERNAL_DMAC. > > But let's add 'if ARCH_RENESAS' to leave at least SUPERH out? Sure. Will send V2 with 'if ARCH_RENESAS' Cheers, Biju
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig index 6824131b69b1..14f485248ff9 100644 --- a/drivers/mmc/host/Kconfig +++ b/drivers/mmc/host/Kconfig @@ -692,6 +692,7 @@ config MMC_SDHI tristate "Renesas SDHI SD/SDIO controller support" depends on SUPERH || ARCH_RENESAS || COMPILE_TEST select MMC_TMIO_CORE + select REGULATOR select RESET_CONTROLLER if ARCH_RENESAS help This provides support for the SDHI SD/SDIO controller found in
The driver no longer builds when regulator support is unavailable. Fix the build error undefined reference to rdev_get_drvdata() by selecting the REGULATOR in config MMC_SDHI. Fixes: fae80a99dc03 ("mmc: renesas_sdhi: Add support for RZ/G3E SoC") Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202503290554.zASQT70Q-lkp@intel.com/ Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> --- drivers/mmc/host/Kconfig | 1 + 1 file changed, 1 insertion(+)