| Message ID | 20250330091738.27052-1-biju.das.jz@bp.renesas.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Kieran Bingham |
| Headers | show |
| Series | media: renesas: vsp1: Use %p4cc printk modifier to print FourCC codes | expand |
Hi Biju, Thank you for the patch. On Sun, Mar 30, 2025 at 10:17:35AM +0100, Biju Das wrote: > Replace '%08x->%p4cc' printk modifier to print FourCC codes for pixel > formats. > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > drivers/media/platform/renesas/vsp1/vsp1_drm.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/media/platform/renesas/vsp1/vsp1_drm.c b/drivers/media/platform/renesas/vsp1/vsp1_drm.c > index b5d1f238f7be..f8a575f6188a 100644 > --- a/drivers/media/platform/renesas/vsp1/vsp1_drm.c > +++ b/drivers/media/platform/renesas/vsp1/vsp1_drm.c > @@ -593,8 +593,8 @@ static int vsp1_du_pipeline_set_rwpf_format(struct vsp1_device *vsp1, > > fmtinfo = vsp1_get_format_info(vsp1, pixelformat); > if (!fmtinfo) { > - dev_dbg(vsp1->dev, "Unsupported pixel format %08x\n", > - pixelformat); > + dev_dbg(vsp1->dev, "Unsupported pixel format %p4cc\n", > + &pixelformat); > return -EINVAL; > } > > @@ -849,11 +849,11 @@ int vsp1_du_atomic_update(struct device *dev, unsigned int pipe_index, > } > > dev_dbg(vsp1->dev, > - "%s: RPF%u: (%u,%u)/%ux%u -> (%u,%u)/%ux%u (%08x), pitch %u dma { %pad, %pad, %pad } zpos %u\n", > + "%s: RPF%u: (%u,%u)/%ux%u -> (%u,%u)/%ux%u (%p4cc), pitch %u dma { %pad, %pad, %pad } zpos %u\n", > __func__, rpf_index, > cfg->src.left, cfg->src.top, cfg->src.width, cfg->src.height, > cfg->dst.left, cfg->dst.top, cfg->dst.width, cfg->dst.height, > - cfg->pixelformat, cfg->pitch, &cfg->mem[0], &cfg->mem[1], > + &cfg->pixelformat, cfg->pitch, &cfg->mem[0], &cfg->mem[1], > &cfg->mem[2], cfg->zpos); > > /*
Quoting Biju Das (2025-03-30 10:17:35) > Replace '%08x->%p4cc' printk modifier to print FourCC codes for pixel > formats. > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > --- > drivers/media/platform/renesas/vsp1/vsp1_drm.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/media/platform/renesas/vsp1/vsp1_drm.c b/drivers/media/platform/renesas/vsp1/vsp1_drm.c > index b5d1f238f7be..f8a575f6188a 100644 > --- a/drivers/media/platform/renesas/vsp1/vsp1_drm.c > +++ b/drivers/media/platform/renesas/vsp1/vsp1_drm.c > @@ -593,8 +593,8 @@ static int vsp1_du_pipeline_set_rwpf_format(struct vsp1_device *vsp1, > > fmtinfo = vsp1_get_format_info(vsp1, pixelformat); > if (!fmtinfo) { > - dev_dbg(vsp1->dev, "Unsupported pixel format %08x\n", > - pixelformat); > + dev_dbg(vsp1->dev, "Unsupported pixel format %p4cc\n", > + &pixelformat); > return -EINVAL; > } > > @@ -849,11 +849,11 @@ int vsp1_du_atomic_update(struct device *dev, unsigned int pipe_index, > } > > dev_dbg(vsp1->dev, > - "%s: RPF%u: (%u,%u)/%ux%u -> (%u,%u)/%ux%u (%08x), pitch %u dma { %pad, %pad, %pad } zpos %u\n", > + "%s: RPF%u: (%u,%u)/%ux%u -> (%u,%u)/%ux%u (%p4cc), pitch %u dma { %pad, %pad, %pad } zpos %u\n", > __func__, rpf_index, > cfg->src.left, cfg->src.top, cfg->src.width, cfg->src.height, > cfg->dst.left, cfg->dst.top, cfg->dst.width, cfg->dst.height, > - cfg->pixelformat, cfg->pitch, &cfg->mem[0], &cfg->mem[1], > + &cfg->pixelformat, cfg->pitch, &cfg->mem[0], &cfg->mem[1], > &cfg->mem[2], cfg->zpos); > > /* > -- > 2.43.0 >
diff --git a/drivers/media/platform/renesas/vsp1/vsp1_drm.c b/drivers/media/platform/renesas/vsp1/vsp1_drm.c index b5d1f238f7be..f8a575f6188a 100644 --- a/drivers/media/platform/renesas/vsp1/vsp1_drm.c +++ b/drivers/media/platform/renesas/vsp1/vsp1_drm.c @@ -593,8 +593,8 @@ static int vsp1_du_pipeline_set_rwpf_format(struct vsp1_device *vsp1, fmtinfo = vsp1_get_format_info(vsp1, pixelformat); if (!fmtinfo) { - dev_dbg(vsp1->dev, "Unsupported pixel format %08x\n", - pixelformat); + dev_dbg(vsp1->dev, "Unsupported pixel format %p4cc\n", + &pixelformat); return -EINVAL; } @@ -849,11 +849,11 @@ int vsp1_du_atomic_update(struct device *dev, unsigned int pipe_index, } dev_dbg(vsp1->dev, - "%s: RPF%u: (%u,%u)/%ux%u -> (%u,%u)/%ux%u (%08x), pitch %u dma { %pad, %pad, %pad } zpos %u\n", + "%s: RPF%u: (%u,%u)/%ux%u -> (%u,%u)/%ux%u (%p4cc), pitch %u dma { %pad, %pad, %pad } zpos %u\n", __func__, rpf_index, cfg->src.left, cfg->src.top, cfg->src.width, cfg->src.height, cfg->dst.left, cfg->dst.top, cfg->dst.width, cfg->dst.height, - cfg->pixelformat, cfg->pitch, &cfg->mem[0], &cfg->mem[1], + &cfg->pixelformat, cfg->pitch, &cfg->mem[0], &cfg->mem[1], &cfg->mem[2], cfg->zpos); /*
Replace '%08x->%p4cc' printk modifier to print FourCC codes for pixel formats. Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> --- drivers/media/platform/renesas/vsp1/vsp1_drm.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)