From patchwork Sat Mar 12 22:29:45 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergei Shtylyov X-Patchwork-Id: 8572251 X-Patchwork-Delegate: geert@linux-m68k.org Return-Path: X-Original-To: patchwork-linux-renesas-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 670059F44D for ; Sat, 12 Mar 2016 22:31:29 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A462D2015E for ; Sat, 12 Mar 2016 22:31:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4BE972013A for ; Sat, 12 Mar 2016 22:31:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753372AbcCLW3v (ORCPT ); Sat, 12 Mar 2016 17:29:51 -0500 Received: from mail-lb0-f179.google.com ([209.85.217.179]:36587 "EHLO mail-lb0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753232AbcCLW3u (ORCPT ); Sat, 12 Mar 2016 17:29:50 -0500 Received: by mail-lb0-f179.google.com with SMTP id x1so196982541lbj.3 for ; Sat, 12 Mar 2016 14:29:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:organization:user-agent :mime-version:content-transfer-encoding; bh=yOk1PKmO5zBplTTwErVP+yoUS3WlIGYCeNu2vsvpzDA=; b=1LUkwk6VP7VKzlLsrUtjc5o953Gs6qbw7HED5SiJxfkVk1N3xxybTC5V2WJbC5wsgo KG6+X4iphDZ/YKQuI5PIO3489Izzo3nbT0+lKoa7TTbk77pa32Q1NcCrW/gnRIAohhSf WKM9FXjDjX3GrMug0Vt/5P/R/Pfia4kR8B1HGWrjZi1HeuUqA/JmyLM+F/Q04UA73aqk nl6ZD1FHTzCDvSSu6SvYOWI15Z9GNno1sHU8Ip5iTMOom1MXxG/pvdxDKuPJ2SBoGuT6 dkUPAxuyqzdK4u/czz//rqzjO0V26zLGhq96KTIjs5JadlOV8QokCFU190EQeI1ZOZbH OLoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:organization :user-agent:mime-version:content-transfer-encoding; bh=yOk1PKmO5zBplTTwErVP+yoUS3WlIGYCeNu2vsvpzDA=; b=PvHAFzEGasJrtkZLFnHUPOxxa8uvGbVl5EN+VDfEhfo6MFGSE4WC9V7sq8PKekgR4v Mb0+1V2Tu3zUXFGKVANeejt5vVS4h3bSa9ELi++9ZNm1N44xkup+78rL3YZv8rXMpcGV uZnbdAt5S8HK0MTeA4SmnR0IP/Ng6U/1SzGsENSzs9ok1vkbnrdO/MhlJbawTjo+y5+6 9PANWT1msU+wemOp+u099mlAFRPsblwJ9GQKLEikFip4TpM4NMuYQjJsUWywIxSCKQP5 UwKobyL5tsUiX2j0pnhrF/oNgIY2ZS6unkQ14nnOd4ea35mZwPgaHc+o/TvasyQymuE7 3q5w== X-Gm-Message-State: AD7BkJKtVBS3ynJAwEyqRLU4y7wecHQRDYl8gmN1jbuPYpKATb0Bx040xu+n27X5h04nHw== X-Received: by 10.112.38.104 with SMTP id f8mr5319378lbk.115.1457821788234; Sat, 12 Mar 2016 14:29:48 -0800 (PST) Received: from wasted.cogentembedded.com ([195.16.111.13]) by smtp.gmail.com with ESMTPSA id c126sm2507281lfb.2.2016.03.12.14.29.46 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 12 Mar 2016 14:29:47 -0800 (PST) From: Sergei Shtylyov To: netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: [PATCH] sh_eth: kill useless initializers Date: Sun, 13 Mar 2016 01:29:45 +0300 Message-ID: <2737382.tXjN0OZRaC@wasted.cogentembedded.com> Organization: Cogent Embedded Inc. User-Agent: KMail/4.14.10 (Linux/4.3.6-201.fc22.x86_64; KDE/4.14.14; x86_64; ; ) MIME-Version: 1.0 Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Some of the local variable intializers in the driver turned out to be pointless, kill 'em. Signed-off-by: Sergei Shtylyov --- The patch is against the DaveM's 'net-next.git' repo. drivers/net/ethernet/renesas/sh_eth.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) Index: net-next/drivers/net/ethernet/renesas/sh_eth.c =================================================================== --- net-next.orig/drivers/net/ethernet/renesas/sh_eth.c +++ net-next/drivers/net/ethernet/renesas/sh_eth.c @@ -447,8 +447,8 @@ static bool sh_eth_is_rz_fast_ether(stru static void sh_eth_select_mii(struct net_device *ndev) { - u32 value = 0x0; struct sh_eth_private *mdp = netdev_priv(ndev); + u32 value; switch (mdp->phy_interface) { case PHY_INTERFACE_MODE_GMII: @@ -1231,8 +1231,8 @@ ring_free: static int sh_eth_dev_init(struct net_device *ndev, bool start) { - int ret = 0; struct sh_eth_private *mdp = netdev_priv(ndev); + int ret; /* Soft Reset */ ret = sh_eth_reset(ndev); @@ -1355,7 +1355,7 @@ static int sh_eth_txfree(struct net_devi struct sh_eth_private *mdp = netdev_priv(ndev); struct sh_eth_txdesc *txdesc; int free_num = 0; - int entry = 0; + int entry; for (; mdp->cur_tx - mdp->dirty_tx > 0; mdp->dirty_tx++) { entry = mdp->dirty_tx % mdp->num_tx_ring; @@ -1396,10 +1396,10 @@ static int sh_eth_rx(struct net_device * int boguscnt = (mdp->dirty_rx + mdp->num_rx_ring) - mdp->cur_rx; int limit; struct sk_buff *skb; - u16 pkt_len = 0; u32 desc_status; int skbuff_size = mdp->rx_buf_sz + SH_ETH_RX_ALIGN + 32 - 1; dma_addr_t dma_addr; + u16 pkt_len; u32 buf_len; boguscnt = min(boguscnt, *quota); @@ -1778,7 +1778,7 @@ static int sh_eth_phy_init(struct net_de { struct device_node *np = ndev->dev.parent->of_node; struct sh_eth_private *mdp = netdev_priv(ndev); - struct phy_device *phydev = NULL; + struct phy_device *phydev; mdp->link = 0; mdp->speed = 0; @@ -2232,8 +2232,8 @@ static const struct ethtool_ops sh_eth_e /* network device open function */ static int sh_eth_open(struct net_device *ndev) { - int ret = 0; struct sh_eth_private *mdp = netdev_priv(ndev); + int ret; pm_runtime_get_sync(&mdp->pdev->dev); @@ -2988,12 +2988,12 @@ static inline struct sh_eth_plat_data *s static int sh_eth_drv_probe(struct platform_device *pdev) { - int ret, devno = 0; struct resource *res; - struct net_device *ndev = NULL; - struct sh_eth_private *mdp = NULL; struct sh_eth_plat_data *pd = dev_get_platdata(&pdev->dev); const struct platform_device_id *id = platform_get_device_id(pdev); + struct sh_eth_private *mdp; + struct net_device *ndev; + int ret, devno; /* get base addr */ res = platform_get_resource(pdev, IORESOURCE_MEM, 0);