| Message ID | 39c2c5fd4232b6620a4a56dba4e2b0d61476ee36.1634646869.git.geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | clk: renesas: rzg2l: Add missing kerneldoc for resets | expand |
Hi Geert, Thanks for your work. On 2021-10-19 14:35:36 +0200, Geert Uytterhoeven wrote: > make W=1: > > drivers/clk/renesas/rzg2l-cpg.c:95: warning: Function parameter or member 'num_resets' not described in 'rzg2l_cpg_priv' > > Add the missing kerneldoc for fields in struct rzg2l_cpg_priv and struct > rzg2l_cpg_info related to Module Resets. > > Fixes: c3e67ad6f5a2c698 ("dt-bindings: clock: r9a07g044-cpg: Update clock/reset definitions") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > --- > To be queued in renesas-clk for v5.17. > --- > drivers/clk/renesas/rzg2l-cpg.c | 1 + > drivers/clk/renesas/rzg2l-cpg.h | 3 +++ > 2 files changed, 4 insertions(+) > > diff --git a/drivers/clk/renesas/rzg2l-cpg.c b/drivers/clk/renesas/rzg2l-cpg.c > index 4021f6cabda4b3bc..a77cb47b75e7c253 100644 > --- a/drivers/clk/renesas/rzg2l-cpg.c > +++ b/drivers/clk/renesas/rzg2l-cpg.c > @@ -74,6 +74,7 @@ struct sd_hw_data { > * @clks: Array containing all Core and Module Clocks > * @num_core_clks: Number of Core Clocks in clks[] > * @num_mod_clks: Number of Module Clocks in clks[] > + * @num_resets: Number of Module Resets in info->resets[] > * @last_dt_core_clk: ID of the last Core Clock exported to DT > * @notifiers: Notifier chain to save/restore clock state for system resume > * @info: Pointer to platform data > diff --git a/drivers/clk/renesas/rzg2l-cpg.h b/drivers/clk/renesas/rzg2l-cpg.h > index 7fb6b4030f72e237..484c7cee2629366f 100644 > --- a/drivers/clk/renesas/rzg2l-cpg.h > +++ b/drivers/clk/renesas/rzg2l-cpg.h > @@ -168,6 +168,9 @@ struct rzg2l_reset { > * @num_mod_clks: Number of entries in mod_clks[] > * @num_hw_mod_clks: Number of Module Clocks supported by the hardware > * > + * @resets: Array of Module Reset definitions > + * @num_resets: Number of entries in resets[] > + * > * @crit_mod_clks: Array with Module Clock IDs of critical clocks that > * should not be disabled without a knowledgeable driver > * @num_crit_mod_clks: Number of entries in crit_mod_clks[] > -- > 2.25.1 >
diff --git a/drivers/clk/renesas/rzg2l-cpg.c b/drivers/clk/renesas/rzg2l-cpg.c index 4021f6cabda4b3bc..a77cb47b75e7c253 100644 --- a/drivers/clk/renesas/rzg2l-cpg.c +++ b/drivers/clk/renesas/rzg2l-cpg.c @@ -74,6 +74,7 @@ struct sd_hw_data { * @clks: Array containing all Core and Module Clocks * @num_core_clks: Number of Core Clocks in clks[] * @num_mod_clks: Number of Module Clocks in clks[] + * @num_resets: Number of Module Resets in info->resets[] * @last_dt_core_clk: ID of the last Core Clock exported to DT * @notifiers: Notifier chain to save/restore clock state for system resume * @info: Pointer to platform data diff --git a/drivers/clk/renesas/rzg2l-cpg.h b/drivers/clk/renesas/rzg2l-cpg.h index 7fb6b4030f72e237..484c7cee2629366f 100644 --- a/drivers/clk/renesas/rzg2l-cpg.h +++ b/drivers/clk/renesas/rzg2l-cpg.h @@ -168,6 +168,9 @@ struct rzg2l_reset { * @num_mod_clks: Number of entries in mod_clks[] * @num_hw_mod_clks: Number of Module Clocks supported by the hardware * + * @resets: Array of Module Reset definitions + * @num_resets: Number of entries in resets[] + * * @crit_mod_clks: Array with Module Clock IDs of critical clocks that * should not be disabled without a knowledgeable driver * @num_crit_mod_clks: Number of entries in crit_mod_clks[]
make W=1: drivers/clk/renesas/rzg2l-cpg.c:95: warning: Function parameter or member 'num_resets' not described in 'rzg2l_cpg_priv' Add the missing kerneldoc for fields in struct rzg2l_cpg_priv and struct rzg2l_cpg_info related to Module Resets. Fixes: c3e67ad6f5a2c698 ("dt-bindings: clock: r9a07g044-cpg: Update clock/reset definitions") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- To be queued in renesas-clk for v5.17. --- drivers/clk/renesas/rzg2l-cpg.c | 1 + drivers/clk/renesas/rzg2l-cpg.h | 3 +++ 2 files changed, 4 insertions(+)