| Message ID | 4947043.txDs5ZU4mH@wasted.cogentembedded.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
Hi Sergei, Thank you for the patch. On Wednesday 14 Dec 2016 23:37:08 Sergei Shtylyov wrote: > We're going to use R8A7791 VSPDs to control DU, so set the corresponding > flag. > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> For the same reason I nacked the corresponding patch to the VSP1 driver, I have to nack this one as well. The Gen2 DU has native planes, this patch would prevent using them. I don't see a good reason to do so. > --- > The patch is against David Airlie's 'linux.git' repo's 'drm-next' branch. > > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > Index: linux/drivers/gpu/drm/rcar-du/rcar_du_drv.c > =================================================================== > --- linux.orig/drivers/gpu/drm/rcar-du/rcar_du_drv.c > +++ linux/drivers/gpu/drm/rcar-du/rcar_du_drv.c > @@ -90,7 +90,8 @@ static const struct rcar_du_device_info > static const struct rcar_du_device_info rcar_du_r8a7791_info = { > .gen = 2, > .features = RCAR_DU_FEATURE_CRTC_IRQ_CLOCK > - | RCAR_DU_FEATURE_EXT_CTRL_REGS, > + | RCAR_DU_FEATURE_EXT_CTRL_REGS > + | RCAR_DU_FEATURE_VSP1_SOURCE, > .num_crtcs = 2, > .routes = { > /* R8A779[13] has one RGB output, one LVDS output and one
Hello! On 12/14/2016 11:55 PM, Laurent Pinchart wrote: >> We're going to use R8A7791 VSPDs to control DU, so set the corresponding >> flag. >> >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > For the same reason I nacked the corresponding patch to the VSP1 driver, I > have to nack this one as well. The Gen2 DU has native planes, this patch would > prevent using them. I don't see a good reason to do so. One of the reasons is that these patches kill the horizontal noise when playing video in Weston... WBR, Sergei
Hi Sergei, On Monday 19 Dec 2016 22:58:57 Sergei Shtylyov wrote: > On 12/14/2016 11:55 PM, Laurent Pinchart wrote: > >> We're going to use R8A7791 VSPDs to control DU, so set the corresponding > >> flag. > >> > >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > > > For the same reason I nacked the corresponding patch to the VSP1 driver, I > > have to nack this one as well. The Gen2 DU has native planes, this patch > > would prevent using them. I don't see a good reason to do so. > > One of the reasons is that these patches kill the horizontal noise when > playing video in Weston... What horizontal noise ? :-)
On 12/19/2016 11:24 PM, Laurent Pinchart wrote: >>>> We're going to use R8A7791 VSPDs to control DU, so set the corresponding >>>> flag. >>>> >>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> >>> >>> For the same reason I nacked the corresponding patch to the VSP1 driver, I >>> have to nack this one as well. The Gen2 DU has native planes, this patch >>> would prevent using them. I don't see a good reason to do so. >> >> One of the reasons is that these patches kill the horizontal noise when >> playing video in Weston... > > What horizontal noise ? :-) Occurs with V4L2 renderer... :-) MBR, Sergei
Index: linux/drivers/gpu/drm/rcar-du/rcar_du_drv.c =================================================================== --- linux.orig/drivers/gpu/drm/rcar-du/rcar_du_drv.c +++ linux/drivers/gpu/drm/rcar-du/rcar_du_drv.c @@ -90,7 +90,8 @@ static const struct rcar_du_device_info static const struct rcar_du_device_info rcar_du_r8a7791_info = { .gen = 2, .features = RCAR_DU_FEATURE_CRTC_IRQ_CLOCK - | RCAR_DU_FEATURE_EXT_CTRL_REGS, + | RCAR_DU_FEATURE_EXT_CTRL_REGS + | RCAR_DU_FEATURE_VSP1_SOURCE, .num_crtcs = 2, .routes = { /* R8A779[13] has one RGB output, one LVDS output and one
We're going to use R8A7791 VSPDs to control DU, so set the corresponding flag. Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> --- The patch is against David Airlie's 'linux.git' repo's 'drm-next' branch. drivers/gpu/drm/rcar-du/rcar_du_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)