| Message ID | 5058a96cb7e8dca97629c48084537fe5def8344f.1532086734.git.horms+renesas@verge.net.au (mailing list archive) |
|---|---|
| State | Superseded |
| Commit | 5058a96cb7e8dca97629c48084537fe5def8344f |
| Headers | show |
On 07/20/2018 03:05 PM, Simon Horman wrote: > From: Marek Vasut <marek.vasut@gmail.com> > > Add PMIC nodes to Porter and connect CPU DVFS supply. There is > one DA9063L and one DA9210 on Porter, the only difference from > the other boards is that DA9063L is at I2C address 0x5a rather > than 0x58 . > > Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > --- > arch/arm/boot/dts/r8a7791-porter.dts | 33 +++++++++++++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > > diff --git a/arch/arm/boot/dts/r8a7791-porter.dts b/arch/arm/boot/dts/r8a7791-porter.dts > index a01101b49d99..5f77d73d7462 100644 > --- a/arch/arm/boot/dts/r8a7791-porter.dts > +++ b/arch/arm/boot/dts/r8a7791-porter.dts > @@ -375,10 +375,43 @@ > clock-frequency = <400000>; > }; > > +&i2c6 { > + status = "okay"; > + clock-frequency = <100000>; > + > + pmic@5a { > + compatible = "dlg,da9063l"; > + reg = <0x5a>; > + interrupt-parent = <&irqc0>; > + interrupts = <2 IRQ_TYPE_LEVEL_LOW>; > + interrupt-controller; Without a label and #interrupt-cells? > + > + wdt { > + compatible = "dlg,da9063-watchdog"; > + }; > + }; [...] MBR, Sergei
On 07/20/2018 06:38 PM, Sergei Shtylyov wrote: > On 07/20/2018 03:05 PM, Simon Horman wrote: > >> From: Marek Vasut <marek.vasut@gmail.com> >> >> Add PMIC nodes to Porter and connect CPU DVFS supply. There is >> one DA9063L and one DA9210 on Porter, the only difference from >> the other boards is that DA9063L is at I2C address 0x5a rather >> than 0x58 . >> >> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> >> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> >> Signed-off-by: Simon Horman <horms+renesas@verge.net.au> >> --- >> arch/arm/boot/dts/r8a7791-porter.dts | 33 +++++++++++++++++++++++++++++++++ >> 1 file changed, 33 insertions(+) >> >> diff --git a/arch/arm/boot/dts/r8a7791-porter.dts b/arch/arm/boot/dts/r8a7791-porter.dts >> index a01101b49d99..5f77d73d7462 100644 >> --- a/arch/arm/boot/dts/r8a7791-porter.dts >> +++ b/arch/arm/boot/dts/r8a7791-porter.dts >> @@ -375,10 +375,43 @@ >> clock-frequency = <400000>; >> }; >> >> +&i2c6 { >> + status = "okay"; >> + clock-frequency = <100000>; >> + >> + pmic@5a { >> + compatible = "dlg,da9063l"; >> + reg = <0x5a>; >> + interrupt-parent = <&irqc0>; >> + interrupts = <2 IRQ_TYPE_LEVEL_LOW>; >> + interrupt-controller; > > Without a label and #interrupt-cells? Just like the other boards do. What's the problem here ?
Hi Marek, On Sun, Jul 22, 2018 at 2:07 PM Marek Vasut <marek.vasut@gmail.com> wrote: > On 07/20/2018 06:38 PM, Sergei Shtylyov wrote: > > On 07/20/2018 03:05 PM, Simon Horman wrote: > >> From: Marek Vasut <marek.vasut@gmail.com> > >> > >> Add PMIC nodes to Porter and connect CPU DVFS supply. There is > >> one DA9063L and one DA9210 on Porter, the only difference from > >> the other boards is that DA9063L is at I2C address 0x5a rather > >> than 0x58 . > >> > >> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> > >> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > >> Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > >> --- > >> arch/arm/boot/dts/r8a7791-porter.dts | 33 +++++++++++++++++++++++++++++++++ > >> 1 file changed, 33 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/r8a7791-porter.dts b/arch/arm/boot/dts/r8a7791-porter.dts > >> index a01101b49d99..5f77d73d7462 100644 > >> --- a/arch/arm/boot/dts/r8a7791-porter.dts > >> +++ b/arch/arm/boot/dts/r8a7791-porter.dts > >> @@ -375,10 +375,43 @@ > >> clock-frequency = <400000>; > >> }; > >> > >> +&i2c6 { > >> + status = "okay"; > >> + clock-frequency = <100000>; > >> + > >> + pmic@5a { > >> + compatible = "dlg,da9063l"; > >> + reg = <0x5a>; > >> + interrupt-parent = <&irqc0>; > >> + interrupts = <2 IRQ_TYPE_LEVEL_LOW>; > >> + interrupt-controller; > > > > Without a label and #interrupt-cells? > > Just like the other boards do. What's the problem here ? Does it support external interrupt inputs? Or only the internal interrupt sources? If the former, it needs at least #interrupt-cells (also in the DT bindings). Gr{oetje,eeting}s, Geert
On 07/23/2018 11:03 AM, Geert Uytterhoeven wrote: > Hi Marek, Hi, > On Sun, Jul 22, 2018 at 2:07 PM Marek Vasut <marek.vasut@gmail.com> wrote: >> On 07/20/2018 06:38 PM, Sergei Shtylyov wrote: >>> On 07/20/2018 03:05 PM, Simon Horman wrote: >>>> From: Marek Vasut <marek.vasut@gmail.com> >>>> >>>> Add PMIC nodes to Porter and connect CPU DVFS supply. There is >>>> one DA9063L and one DA9210 on Porter, the only difference from >>>> the other boards is that DA9063L is at I2C address 0x5a rather >>>> than 0x58 . >>>> >>>> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> >>>> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> >>>> Signed-off-by: Simon Horman <horms+renesas@verge.net.au> >>>> --- >>>> arch/arm/boot/dts/r8a7791-porter.dts | 33 +++++++++++++++++++++++++++++++++ >>>> 1 file changed, 33 insertions(+) >>>> >>>> diff --git a/arch/arm/boot/dts/r8a7791-porter.dts b/arch/arm/boot/dts/r8a7791-porter.dts >>>> index a01101b49d99..5f77d73d7462 100644 >>>> --- a/arch/arm/boot/dts/r8a7791-porter.dts >>>> +++ b/arch/arm/boot/dts/r8a7791-porter.dts >>>> @@ -375,10 +375,43 @@ >>>> clock-frequency = <400000>; >>>> }; >>>> >>>> +&i2c6 { >>>> + status = "okay"; >>>> + clock-frequency = <100000>; >>>> + >>>> + pmic@5a { >>>> + compatible = "dlg,da9063l"; >>>> + reg = <0x5a>; >>>> + interrupt-parent = <&irqc0>; >>>> + interrupts = <2 IRQ_TYPE_LEVEL_LOW>; >>>> + interrupt-controller; >>> >>> Without a label and #interrupt-cells? >> >> Just like the other boards do. What's the problem here ? > > Does it support external interrupt inputs? Or only the internal > interrupt sources? The PMIC itself no, but the mfd subdevices do (ie. the GPIO block, for which we don't have driver), see drivers/mfd/da9063-irq.c . > If the former, it needs at least #interrupt-cells (also in the DT bindings). [...]
diff --git a/arch/arm/boot/dts/r8a7791-porter.dts b/arch/arm/boot/dts/r8a7791-porter.dts index a01101b49d99..5f77d73d7462 100644 --- a/arch/arm/boot/dts/r8a7791-porter.dts +++ b/arch/arm/boot/dts/r8a7791-porter.dts @@ -375,10 +375,43 @@ clock-frequency = <400000>; }; +&i2c6 { + status = "okay"; + clock-frequency = <100000>; + + pmic@5a { + compatible = "dlg,da9063l"; + reg = <0x5a>; + interrupt-parent = <&irqc0>; + interrupts = <2 IRQ_TYPE_LEVEL_LOW>; + interrupt-controller; + + wdt { + compatible = "dlg,da9063-watchdog"; + }; + }; + + vdd_dvfs: regulator@68 { + compatible = "dlg,da9210"; + reg = <0x68>; + interrupt-parent = <&irqc0>; + interrupts = <2 IRQ_TYPE_LEVEL_LOW>; + + regulator-min-microvolt = <1000000>; + regulator-max-microvolt = <1000000>; + regulator-boot-on; + regulator-always-on; + }; +}; + &sata0 { status = "okay"; }; +&cpu0 { + cpu0-supply = <&vdd_dvfs>; +}; + /* composite video input */ &vin0 { status = "okay";