| Message ID | 7cea42cd09540657875a210cd16421125497d690.1685696114.git.geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | drm: Atomic modesetting doc and comment improvements | expand |
Geert Uytterhoeven <geert+renesas@glider.be> writes: Hello Geert, Thanks for your patch. > The section about converting existing KMS drivers to atomic modesetting > mentions the existence of a conversion guide, but does not reference it. > While the guide is old and rusty, it still contains useful information, > so add a link to it. Also link to the LWN.net articles that give an > overview about the atomic mode setting design. > This is a great idea and agree that would be very useful to have these. > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > Documentation/gpu/todo.rst | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst > index 68bdafa0284f55f6..51eb67f5268c5ec1 100644 > --- a/Documentation/gpu/todo.rst > +++ b/Documentation/gpu/todo.rst > @@ -49,14 +49,19 @@ converted over. Modern compositors like Wayland or Surfaceflinger on Android > really want an atomic modeset interface, so this is all about the bright > future. > > -There is a conversion guide for atomic and all you need is a GPU for a > +There is a conversion guide for atomic[1] and all you need is a GPU for a > non-converted driver (again virtual HW drivers for KVM are still all > -suitable). Are any of the virtual drivers not yet ported to atomic? This sentence seems to be outdated and maybe you could remove it on a following patch? Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Hi Geert, Thank you for the patch. On Fri, Jun 02, 2023 at 11:11:34AM +0200, Geert Uytterhoeven wrote: > The section about converting existing KMS drivers to atomic modesetting > mentions the existence of a conversion guide, but does not reference it. > While the guide is old and rusty, it still contains useful information, > so add a link to it. Also link to the LWN.net articles that give an > overview about the atomic mode setting design. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > Documentation/gpu/todo.rst | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst > index 68bdafa0284f55f6..51eb67f5268c5ec1 100644 > --- a/Documentation/gpu/todo.rst > +++ b/Documentation/gpu/todo.rst > @@ -49,14 +49,19 @@ converted over. Modern compositors like Wayland or Surfaceflinger on Android > really want an atomic modeset interface, so this is all about the bright > future. > > -There is a conversion guide for atomic and all you need is a GPU for a > +There is a conversion guide for atomic[1] and all you need is a GPU for a > non-converted driver (again virtual HW drivers for KVM are still all > -suitable). > +suitable). The "Atomic mode setting design overview" series [2][3] at s/ / / Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > +LWN.net can also be helpful. > > As part of this drivers also need to convert to universal plane (which means > exposing primary & cursor as proper plane objects). But that's much easier to > do by directly using the new atomic helper driver callbacks. > > + - [1] https://blog.ffwll.ch/2014/11/atomic-modeset-support-for-kms-drivers.html > + - [2] https://lwn.net/Articles/653071/ > + - [3] https://lwn.net/Articles/653466/ > + > Contact: Daniel Vetter, respective driver maintainers > > Level: Advanced
Hi Javier, On Fri, Jun 2, 2023 at 12:39 PM Javier Martinez Canillas <javierm@redhat.com> wrote: > Geert Uytterhoeven <geert+renesas@glider.be> writes: > > The section about converting existing KMS drivers to atomic modesetting > > mentions the existence of a conversion guide, but does not reference it. > > While the guide is old and rusty, it still contains useful information, > > so add a link to it. Also link to the LWN.net articles that give an > > overview about the atomic mode setting design. > > --- a/Documentation/gpu/todo.rst > > +++ b/Documentation/gpu/todo.rst > > @@ -49,14 +49,19 @@ converted over. Modern compositors like Wayland or Surfaceflinger on Android > > really want an atomic modeset interface, so this is all about the bright > > future. > > > > -There is a conversion guide for atomic and all you need is a GPU for a > > +There is a conversion guide for atomic[1] and all you need is a GPU for a > > non-converted driver (again virtual HW drivers for KVM are still all > > -suitable). > > Are any of the virtual drivers not yet ported to atomic? This sentence > seems to be outdated and maybe you could remove it on a following patch? Good question. I'm not sure which driver(s) this refers to. drivers/gpu/drm/vkms/ was introduced much later, and always had DRIVER_ATOMIC. Perhaps just the boochs driver, which was converted? > Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> Thanks! Gr{oetje,eeting}s, Geert
On Fri, Jun 02, 2023 at 11:11:34AM +0200, Geert Uytterhoeven wrote: > -There is a conversion guide for atomic and all you need is a GPU for a > +There is a conversion guide for atomic[1] and all you need is a GPU for a > non-converted driver (again virtual HW drivers for KVM are still all > -suitable). > +suitable). The "Atomic mode setting design overview" series [2][3] at > +LWN.net can also be helpful. > > As part of this drivers also need to convert to universal plane (which means > exposing primary & cursor as proper plane objects). But that's much easier to > do by directly using the new atomic helper driver callbacks. > > + - [1] https://blog.ffwll.ch/2014/11/atomic-modeset-support-for-kms-drivers.html > + - [2] https://lwn.net/Articles/653071/ > + - [3] https://lwn.net/Articles/653466/ > + Looks like footnotes better serve these links above: ---- >8 ---- diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst index 51eb67f5268c5e..6ea92f48a2e21c 100644 --- a/Documentation/gpu/todo.rst +++ b/Documentation/gpu/todo.rst @@ -49,18 +49,18 @@ converted over. Modern compositors like Wayland or Surfaceflinger on Android really want an atomic modeset interface, so this is all about the bright future. -There is a conversion guide for atomic[1] and all you need is a GPU for a +There is a conversion guide for atomic [1]_ and all you need is a GPU for a non-converted driver (again virtual HW drivers for KVM are still all -suitable). The "Atomic mode setting design overview" series [2][3] at +suitable). The "Atomic mode setting design overview" series [2]_ [3]_ at LWN.net can also be helpful. As part of this drivers also need to convert to universal plane (which means exposing primary & cursor as proper plane objects). But that's much easier to do by directly using the new atomic helper driver callbacks. - - [1] https://blog.ffwll.ch/2014/11/atomic-modeset-support-for-kms-drivers.html - - [2] https://lwn.net/Articles/653071/ - - [3] https://lwn.net/Articles/653466/ + .. [1] https://blog.ffwll.ch/2014/11/atomic-modeset-support-for-kms-drivers.html + .. [2] https://lwn.net/Articles/653071/ + .. [3] https://lwn.net/Articles/653466/ Contact: Daniel Vetter, respective driver maintainers Thanks.
diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst index 68bdafa0284f55f6..51eb67f5268c5ec1 100644 --- a/Documentation/gpu/todo.rst +++ b/Documentation/gpu/todo.rst @@ -49,14 +49,19 @@ converted over. Modern compositors like Wayland or Surfaceflinger on Android really want an atomic modeset interface, so this is all about the bright future. -There is a conversion guide for atomic and all you need is a GPU for a +There is a conversion guide for atomic[1] and all you need is a GPU for a non-converted driver (again virtual HW drivers for KVM are still all -suitable). +suitable). The "Atomic mode setting design overview" series [2][3] at +LWN.net can also be helpful. As part of this drivers also need to convert to universal plane (which means exposing primary & cursor as proper plane objects). But that's much easier to do by directly using the new atomic helper driver callbacks. + - [1] https://blog.ffwll.ch/2014/11/atomic-modeset-support-for-kms-drivers.html + - [2] https://lwn.net/Articles/653071/ + - [3] https://lwn.net/Articles/653466/ + Contact: Daniel Vetter, respective driver maintainers Level: Advanced
The section about converting existing KMS drivers to atomic modesetting mentions the existence of a conversion guide, but does not reference it. While the guide is old and rusty, it still contains useful information, so add a link to it. Also link to the LWN.net articles that give an overview about the atomic mode setting design. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- Documentation/gpu/todo.rst | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)