| Message ID | 7f9c840ed44dfd57da545e87b5937b58f35cb9c9.1702309604.git.geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Kieran Bingham |
| Headers | show |
| Series | arm64: dts: renesas: Add support for more R-Car V4H and White Hawk variants | expand |
On Mon, Dec 11, 2023 at 5:01 PM Geert Uytterhoeven <geert+renesas@glider.be> wrote: > The White Hawk Single board is a single-board integration of the Renesas > White Hawk CPU and Breakout board stack, based on the R-Car V4H ES2.0 > (R8A779G2) SoC. > > For now, the only visible differences compared to the board stack are: > - The SoC is an updated version of R-Car V4H (R8A779G0), > - The serial console uses an FT2232H instead of a CP2102 USB-UART > bridge, with CTS/RTS wired. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- /dev/null > +++ b/arch/arm64/boot/dts/renesas/r8a779g2-white-hawk-single.dts > + > +&pfc { > + hscif0_pins: hscif0 { &hscif0_pins { > + groups = "hscif0_data", "hscif0_ctrl"; > + function = "hscif0"; > + }; > +}; Gr{oetje,eeting}s, Geert
On Mon, Dec 11, 2023 at 05:01:22PM +0100, Geert Uytterhoeven wrote: > The White Hawk Single board is a single-board integration of the Renesas > White Hawk CPU and Breakout board stack, based on the R-Car V4H ES2.0 > (R8A779G2) SoC. > > For now, the only visible differences compared to the board stack are: > - The SoC is an updated version of R-Car V4H (R8A779G0), > - The serial console uses an FT2232H instead of a CP2102 USB-UART > bridge, with CTS/RTS wired. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Modulo the HSCIF pin issue: Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com> I like the split up and the naming. Makes sense to me. > +/* > + * Device Tree Source for the White Hawk Single board Maybe add "R-Car V4H" here? Maybe even "Rev 2.0"? > + * > + * Copyright (C) 2023 Glider bv > + */
Hi Wolfram, On Wed, Jan 24, 2024 at 2:02 PM Wolfram Sang <wsa@kernel.org> wrote: > On Mon, Dec 11, 2023 at 05:01:22PM +0100, Geert Uytterhoeven wrote: > > The White Hawk Single board is a single-board integration of the Renesas > > White Hawk CPU and Breakout board stack, based on the R-Car V4H ES2.0 > > (R8A779G2) SoC. > > > > For now, the only visible differences compared to the board stack are: > > - The SoC is an updated version of R-Car V4H (R8A779G0), > > - The serial console uses an FT2232H instead of a CP2102 USB-UART > > bridge, with CTS/RTS wired. > > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Modulo the HSCIF pin issue: > > Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > > I like the split up and the naming. Makes sense to me. Thanks! > > +/* > > + * Device Tree Source for the White Hawk Single board > > Maybe add "R-Car V4H" here? Maybe even "Rev 2.0"? The existing r8a779g0-white-hawk.dts does not have such a comment. Perhaps it should be added, too? Gr{oetje,eeting}s, Geert
> > > +/* > > > + * Device Tree Source for the White Hawk Single board > > > > Maybe add "R-Car V4H" here? Maybe even "Rev 2.0"? > > The existing r8a779g0-white-hawk.dts does not have such a comment. > Perhaps it should be added, too? I think so. I mean, the whole point of the series is to make white-hawk includes independent. I'd conclude that the actual users of the includes should specify which SoC this instance incorporates.
diff --git a/arch/arm64/boot/dts/renesas/Makefile b/arch/arm64/boot/dts/renesas/Makefile index 5209ca9cdf8433c1..544dfd8de25cf809 100644 --- a/arch/arm64/boot/dts/renesas/Makefile +++ b/arch/arm64/boot/dts/renesas/Makefile @@ -87,6 +87,8 @@ dtb-$(CONFIG_ARCH_R8A779G0) += r8a779g0-white-hawk-ard-audio-da7212.dtbo r8a779g0-white-hawk-ard-audio-da7212-dtbs := r8a779g0-white-hawk.dtb r8a779g0-white-hawk-ard-audio-da7212.dtbo dtb-$(CONFIG_ARCH_R8A779G0) += r8a779g0-white-hawk-ard-audio-da7212.dtb +dtb-$(CONFIG_ARCH_R8A779G0) += r8a779g2-white-hawk-single.dtb + dtb-$(CONFIG_ARCH_R8A77951) += r8a779m1-salvator-xs.dtb r8a779m1-salvator-xs-panel-aa104xd12-dtbs := r8a779m1-salvator-xs.dtb salvator-panel-aa104xd12.dtbo dtb-$(CONFIG_ARCH_R8A77951) += r8a779m1-salvator-xs-panel-aa104xd12.dtb diff --git a/arch/arm64/boot/dts/renesas/r8a779g2-white-hawk-single.dts b/arch/arm64/boot/dts/renesas/r8a779g2-white-hawk-single.dts new file mode 100644 index 0000000000000000..ca5791b3ca321e97 --- /dev/null +++ b/arch/arm64/boot/dts/renesas/r8a779g2-white-hawk-single.dts @@ -0,0 +1,28 @@ +// SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +/* + * Device Tree Source for the White Hawk Single board + * + * Copyright (C) 2023 Glider bv + */ + +/dts-v1/; +#include "r8a779g2.dtsi" +#include "white-hawk-cpu-common.dtsi" +#include "white-hawk-common.dtsi" + +/ { + model = "Renesas White Hawk Single board based on r8a779g2"; + compatible = "renesas,white-hawk-single", "renesas,r8a779g2", + "renesas,r8a779g0"; +}; + +&hscif0 { + uart-has-rtscts; +}; + +&pfc { + hscif0_pins: hscif0 { + groups = "hscif0_data", "hscif0_ctrl"; + function = "hscif0"; + }; +};
The White Hawk Single board is a single-board integration of the Renesas White Hawk CPU and Breakout board stack, based on the R-Car V4H ES2.0 (R8A779G2) SoC. For now, the only visible differences compared to the board stack are: - The SoC is an updated version of R-Car V4H (R8A779G0), - The serial console uses an FT2232H instead of a CP2102 USB-UART bridge, with CTS/RTS wired. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- arch/arm64/boot/dts/renesas/Makefile | 2 ++ .../renesas/r8a779g2-white-hawk-single.dts | 28 +++++++++++++++++++ 2 files changed, 30 insertions(+) create mode 100644 arch/arm64/boot/dts/renesas/r8a779g2-white-hawk-single.dts