diff mbox

[1/2] arm64: dts: r8a7795: add sound CTU support

Message ID 877f7fvvh5.wl%kuninori.morimoto.gx@renesas.com (mailing list archive)
State Changes Requested
Headers show

Commit Message

Kuninori Morimoto Dec. 5, 2016, 4:42 a.m. UTC 
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

This patch adds CTU (= Channel Transfer Unit) supoort which is needed
to sound mixing.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts |  1 +
 arch/arm64/boot/dts/renesas/r8a7795.dtsi           | 13 +++++++++++++
 2 files changed, 14 insertions(+)

Comments

Geert Uytterhoeven Dec. 5, 2016, 8:44 a.m. UTC | #1 
Hi Morimoto-san,

On Mon, Dec 5, 2016 at 5:42 AM, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> @@ -1182,6 +1184,17 @@
>                                 };
>                         };
>
> +                       rcar_sound,ctu {
> +                               ctu00: ctu@0 { };
> +                               ctu01: ctu@1 { };
> +                               ctu02: ctu@2 { };
> +                               ctu03: ctu@3 { };
> +                               ctu10: ctu@4 { };
> +                               ctu11: ctu@5 { };
> +                               ctu12: ctu@6 { };
> +                               ctu13: ctu@7 { };

With W=1:

Warning (unit_address_vs_reg): Node
/sound@ec500000/rcar_sound,ctu/ctu@0 has a unit name, but no reg
property

"ctu00: ctu-0 { };" etc...

> +                       };
> +

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Kuninori Morimoto Dec. 5, 2016, 9:02 a.m. UTC | #2 
Hi Geert

> > --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> > @@ -1182,6 +1184,17 @@
> >                                 };
> >                         };
> >
> > +                       rcar_sound,ctu {
> > +                               ctu00: ctu@0 { };
> > +                               ctu01: ctu@1 { };
> > +                               ctu02: ctu@2 { };
> > +                               ctu03: ctu@3 { };
> > +                               ctu10: ctu@4 { };
> > +                               ctu11: ctu@5 { };
> > +                               ctu12: ctu@6 { };
> > +                               ctu13: ctu@7 { };
> 
> With W=1:
> 
> Warning (unit_address_vs_reg): Node
> /sound@ec500000/rcar_sound,ctu/ctu@0 has a unit name, but no reg
> property
> 
> "ctu00: ctu-0 { };" etc...

Ohh.. indeed.
Thanks. will send v2 patch

Best regards
---
Kuninori Morimoto
diff mbox

Patch

diff --git a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
index d56e4149..bceb20d 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
@@ -495,6 +495,7 @@ 
 		 <&cpg CPG_MOD 1026>, <&cpg CPG_MOD 1027>,
 		 <&cpg CPG_MOD 1028>, <&cpg CPG_MOD 1029>,
 		 <&cpg CPG_MOD 1030>, <&cpg CPG_MOD 1031>,
+		 <&cpg CPG_MOD 1020>, <&cpg CPG_MOD 1021>,
 		 <&cpg CPG_MOD 1019>, <&cpg CPG_MOD 1018>,
 		 <&audio_clk_a>, <&cs2000>,
 		 <&audio_clk_c>,
diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
index 4c77030..87d42dd 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -1155,6 +1155,7 @@ 
 				 <&cpg CPG_MOD 1026>, <&cpg CPG_MOD 1027>,
 				 <&cpg CPG_MOD 1028>, <&cpg CPG_MOD 1029>,
 				 <&cpg CPG_MOD 1030>, <&cpg CPG_MOD 1031>,
+				 <&cpg CPG_MOD 1020>, <&cpg CPG_MOD 1021>,
 				 <&cpg CPG_MOD 1019>, <&cpg CPG_MOD 1018>,
 				 <&audio_clk_a>, <&audio_clk_b>,
 				 <&audio_clk_c>,
@@ -1166,6 +1167,7 @@ 
 				      "src.9", "src.8", "src.7", "src.6",
 				      "src.5", "src.4", "src.3", "src.2",
 				      "src.1", "src.0",
+				      "ctu.1", "ctu.0",
 				      "dvc.0", "dvc.1",
 				      "clk_a", "clk_b", "clk_c", "clk_i";
 			power-domains = <&sysc R8A7795_PD_ALWAYS_ON>;
@@ -1182,6 +1184,17 @@ 
 				};
 			};
 
+			rcar_sound,ctu {
+				ctu00: ctu@0 { };
+				ctu01: ctu@1 { };
+				ctu02: ctu@2 { };
+				ctu03: ctu@3 { };
+				ctu10: ctu@4 { };
+				ctu11: ctu@5 { };
+				ctu12: ctu@6 { };
+				ctu13: ctu@7 { };
+			};
+
 			rcar_sound,src {
 				src0: src-0 {
 					interrupts = <GIC_SPI 352 IRQ_TYPE_LEVEL_HIGH>;