| Message ID | 87fuf0iuiq.wl%kuninori.morimoto.gx@renesas.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 5e2feac330953fe75197aecb20c781400e2bf606 |
| Delegated to: | Simon Horman |
| Headers | show |
On Fri, Jun 16, 2017 at 01:41:20AM +0000, Kuninori Morimoto wrote: > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > It will be used ADG clock initial settings, and will be > sound codec's initial system clock which needs maximum clock frequency. > Thus, descending order is required > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Thanks, I have queued this up for v4.14.
Hi Simon > On Fri, Jun 16, 2017 at 01:41:20AM +0000, Kuninori Morimoto wrote: > > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > > > It will be used ADG clock initial settings, and will be > > sound codec's initial system clock which needs maximum clock frequency. > > Thus, descending order is required > > > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > Thanks, I have queued this up for v4.14. Sorry for bother you, but is it possible this patch in v4.13 ? Best regards --- Kuninori Morimoto
Hi Morimoto-san, On Mon, Jun 19, 2017 at 2:16 AM, Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> wrote: >> On Fri, Jun 16, 2017 at 01:41:20AM +0000, Kuninori Morimoto wrote: >> > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> >> > >> > It will be used ADG clock initial settings, and will be >> > sound codec's initial system clock which needs maximum clock frequency. >> > Thus, descending order is required >> > >> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> >> >> Thanks, I have queued this up for v4.14. > > Sorry for bother you, but is it possible this patch in v4.13 ? I guess you forgot to add these tags, that would have hinted Simon they are fixes for commits he was about to send a pull request for to arm-soc? Fixes: d37d2b3c0ec2708a ("arm64: dts: salvator-x: add 12288000 for sound ADG") Fixes: 0b03c32db03d63de ("arm64: dts: r8a7795: salvator-x: Add support for R-Car H3 ES2.0") In the mean time Olof has pulled them... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert > >> On Fri, Jun 16, 2017 at 01:41:20AM +0000, Kuninori Morimoto wrote: > >> > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > >> > > >> > It will be used ADG clock initial settings, and will be > >> > sound codec's initial system clock which needs maximum clock frequency. > >> > Thus, descending order is required > >> > > >> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > >> > >> Thanks, I have queued this up for v4.14. > > > > Sorry for bother you, but is it possible this patch in v4.13 ? > > I guess you forgot to add these tags, that would have hinted Simon they are > fixes for commits he was about to send a pull request for to arm-soc? > > Fixes: d37d2b3c0ec2708a ("arm64: dts: salvator-x: add 12288000 for sound ADG") > Fixes: 0b03c32db03d63de ("arm64: dts: r8a7795: salvator-x: Add support > for R-Car H3 ES2.0") > > In the mean time Olof has pulled them... Yes, it was my fault, and (maybe) I posted this patch *after* simon's closing announce. If it is OK, I can post it with above Fixes tag Best regards --- Kuninori Morimoto
On Mon, Jun 19, 2017 at 06:33:08AM +0000, Kuninori Morimoto wrote: > Hi Geert > > > >> On Fri, Jun 16, 2017 at 01:41:20AM +0000, Kuninori Morimoto wrote: > > >> > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > >> > > > >> > It will be used ADG clock initial settings, and will be > > >> > sound codec's initial system clock which needs maximum clock frequency. > > >> > Thus, descending order is required > > >> > > > >> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > >> > > >> Thanks, I have queued this up for v4.14. > > > > > > Sorry for bother you, but is it possible this patch in v4.13 ? > > > > I guess you forgot to add these tags, that would have hinted Simon they are > > fixes for commits he was about to send a pull request for to arm-soc? > > > > Fixes: d37d2b3c0ec2708a ("arm64: dts: salvator-x: add 12288000 for sound ADG") > > Fixes: 0b03c32db03d63de ("arm64: dts: r8a7795: salvator-x: Add support > > for R-Car H3 ES2.0") > > > > In the mean time Olof has pulled them... > > Yes, it was my fault, and (maybe) I posted this patch *after* simon's closing announce. > If it is OK, I can post it with above Fixes tag Its fine to post fixes after my tree closes (or at any other time) but it helps me a lot if they come with "Fixes" tags if the resolve issues in patches for which I have already sent pull requests. I'll re-apply this patch as a fix for v4.13 with the tags above. No need to repost at this stage.
Hi Simon > > > I guess you forgot to add these tags, that would have hinted Simon they are > > > fixes for commits he was about to send a pull request for to arm-soc? > > > > > > Fixes: d37d2b3c0ec2708a ("arm64: dts: salvator-x: add 12288000 for sound ADG") > > > Fixes: 0b03c32db03d63de ("arm64: dts: r8a7795: salvator-x: Add support > > > for R-Car H3 ES2.0") > > > > > > In the mean time Olof has pulled them... > > > > Yes, it was my fault, and (maybe) I posted this patch *after* simon's closing announce. > > If it is OK, I can post it with above Fixes tag > > Its fine to post fixes after my tree closes (or at any other time) but it > helps me a lot if they come with "Fixes" tags if the resolve issues in > patches for which I have already sent pull requests. I'll re-apply this > patch as a fix for v4.13 with the tags above. No need to repost at this > stage. Thanks. Above Geert's "Fixes" tags are correct. So, can you pickup it into v4.13 fixup please ? Best regards --- Kuninori Morimoto
On Mon, Jun 19, 2017 at 09:46:12AM +0000, Kuninori Morimoto wrote: > > Hi Simon > > > > > I guess you forgot to add these tags, that would have hinted Simon they are > > > > fixes for commits he was about to send a pull request for to arm-soc? > > > > > > > > Fixes: d37d2b3c0ec2708a ("arm64: dts: salvator-x: add 12288000 for sound ADG") > > > > Fixes: 0b03c32db03d63de ("arm64: dts: r8a7795: salvator-x: Add support > > > > for R-Car H3 ES2.0") > > > > > > > > In the mean time Olof has pulled them... > > > > > > Yes, it was my fault, and (maybe) I posted this patch *after* simon's closing announce. > > > If it is OK, I can post it with above Fixes tag > > > > Its fine to post fixes after my tree closes (or at any other time) but it > > helps me a lot if they come with "Fixes" tags if the resolve issues in > > patches for which I have already sent pull requests. I'll re-apply this > > patch as a fix for v4.13 with the tags above. No need to repost at this > > stage. > > Thanks. > Above Geert's "Fixes" tags are correct. > So, can you pickup it into v4.13 fixup please ? Sure, done.
diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi index aef35e0..a451996 100644 --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi @@ -508,7 +508,7 @@ /* audio_clkout0/1/2/3 */ #clock-cells = <1>; - clock-frequency = <11289600 12288000>; + clock-frequency = <12288000 11289600>; status = "okay";