[1/2] arm64: renesas: salvator-common: fixup audio_clkout

Commit Message

Kuninori Morimoto Oct. 13, 2017, 5:56 a.m. UTC

From: Kuninori Morimoto <[e-mail]>

"audio_clkout" is dummy clock of <&rcar_sound 0> to avoid clock loop
which invites probe conflct. Thus <&rcar_sound 0> and "audio_clkout"
should be same value.

On commit 5e2feac33095 ("arm64: renesas: salvator-common: sound
clock-frequency needs descending order") exchanged <&rcar_sound 0>,
but it didn't modify "audio_clkout".
This patch fixup it.

Fixes: 5e2feac33095 ("arm64: renesas: salvator-common: sound
                      clock-frequency needs descending order")
Signed-off-by: Kuninori Morimoto <[e-mail]>
---
 arch/arm64/boot/dts/renesas/salvator-common.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sergei Shtylyov Oct. 13, 2017, 8:59 a.m. UTC | #1

Hello!

On 10/13/2017 8:56 AM, Kuninori Morimoto wrote:

> From: Kuninori Morimoto <[e-mail]>
> 
> "audio_clkout" is dummy clock of <&rcar_sound 0> to avoid clock loop
> which invites probe conflct. Thus <&rcar_sound 0> and "audio_clkout"

    Conflict.

> should be same value.
> 
> On commit 5e2feac33095 ("arm64: renesas: salvator-common: sound
> clock-frequency needs descending order") exchanged <&rcar_sound 0>,
> but it didn't modify "audio_clkout".
> This patch fixup it.

    Fixes it up.

> Fixes: 5e2feac33095 ("arm64: renesas: salvator-common: sound
>                        clock-frequency needs descending order")

    Don't ever wrap the summaries around in this tag.

> Signed-off-by: Kuninori Morimoto <[e-mail]>
[...]

MBR, Sergei

Simon Horman Oct. 13, 2017, 10:41 a.m. UTC | #2

On Fri, Oct 13, 2017 at 11:59:58AM +0300, Sergei Shtylyov wrote:
> Hello!
> 
> On 10/13/2017 8:56 AM, Kuninori Morimoto wrote:
> 
> > From: Kuninori Morimoto <[e-mail]>
> > 
> > "audio_clkout" is dummy clock of <&rcar_sound 0> to avoid clock loop
> > which invites probe conflct. Thus <&rcar_sound 0> and "audio_clkout"
> 
>    Conflict.
> 
> > should be same value.
> > 
> > On commit 5e2feac33095 ("arm64: renesas: salvator-common: sound
> > clock-frequency needs descending order") exchanged <&rcar_sound 0>,
> > but it didn't modify "audio_clkout".
> > This patch fixup it.
> 
>    Fixes it up.
> 
> > Fixes: 5e2feac33095 ("arm64: renesas: salvator-common: sound
> >                        clock-frequency needs descending order")
> 
>    Don't ever wrap the summaries around in this tag.

I fixed that one up before applying the patches.

Morimoto-san, if you would like to correct the other errors let me know
and I can handle it.

> > Signed-off-by: Kuninori Morimoto <[e-mail]>
> [...]
> 
> MBR, Sergei
>

Kuninori Morimoto Oct. 15, 2017, 11:46 p.m. UTC | #3

Hi Simon

> >    Don't ever wrap the summaries around in this tag.
> 
> I fixed that one up before applying the patches.
> 
> Morimoto-san, if you would like to correct the other errors let me know
> and I can handle it.

Thanks
Then, can you please fix typo of "conflict" ?

> > > "audio_clkout" is dummy clock of <&rcar_sound 0> to avoid clock loop
> > > which invites probe conflct. Thus <&rcar_sound 0> and "audio_clkout"
> > 
> >    Conflict.


Best regards
---
Kuninori Morimoto

Simon Horman Oct. 16, 2017, 7:47 a.m. UTC | #4

On Sun, Oct 15, 2017 at 11:46:40PM +0000, Kuninori Morimoto wrote:
> 
> Hi Simon
> 
> > >    Don't ever wrap the summaries around in this tag.
> > 
> > I fixed that one up before applying the patches.
> > 
> > Morimoto-san, if you would like to correct the other errors let me know
> > and I can handle it.
> 
> Thanks
> Then, can you please fix typo of "conflict" ?

Sure, done.

Patch

diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
index 7040255..9c6e950 100644
--- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
+++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
@@ -53,7 +53,7 @@ 
 		 */
 		compatible = "fixed-clock";
 		#clock-cells = <0>;
-		clock-frequency = <11289600>;
+		clock-frequency = <12288000>;
 	};
 
 	backlight: backlight {