| Message ID | 87po7criel.wl%kuninori.morimoto.gx@renesas.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
Hello Morimoto-san, Thankk you for the patch. On Monday, 18 December 2017 02:35:18 EET Kuninori Morimoto wrote: > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > It is difficult to understand its scale if number has many 0s. > This patch uses "* 1000" to avoid it in rcar_du_dpll_divider(). > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > v3 -> v4 > > - no change > > drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c > b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c index 5685d5a..6820461f 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c > @@ -132,7 +132,7 @@ static void rcar_du_dpll_divider(struct rcar_du_crtc > *rcrtc, > > output = input * (n + 1) / (m + 1) > / (fdpll + 1); > - if (output >= 400000000) > + if (output >= 400 * 1000 * 1000) > continue; > > diff = abs((long)output - (long)target);
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c index 5685d5a..6820461f 100644 --- a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c +++ b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c @@ -132,7 +132,7 @@ static void rcar_du_dpll_divider(struct rcar_du_crtc *rcrtc, output = input * (n + 1) / (m + 1) / (fdpll + 1); - if (output >= 400000000) + if (output >= 400 * 1000 * 1000) continue; diff = abs((long)output - (long)target);