From patchwork Tue Aug 15 09:46:38 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 9901501 X-Patchwork-Delegate: geert@linux-m68k.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DB04560244 for ; Tue, 15 Aug 2017 09:46:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CBFEE28817 for ; Tue, 15 Aug 2017 09:46:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BE29128822; Tue, 15 Aug 2017 09:46:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4C6D328817 for ; Tue, 15 Aug 2017 09:46:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753496AbdHOJqw (ORCPT ); Tue, 15 Aug 2017 05:46:52 -0400 Received: from mga01.intel.com ([192.55.52.88]:12607 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752467AbdHOJqv (ORCPT ); Tue, 15 Aug 2017 05:46:51 -0400 Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Aug 2017 02:46:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,377,1498546800"; d="asc'?scan'208";a="139738642" Received: from pipin.fi.intel.com (HELO localhost) ([10.237.68.37]) by fmsmga005.fm.intel.com with ESMTP; 15 Aug 2017 02:46:48 -0700 From: Felipe Balbi To: Rob Herring , Yoshihiro Shimoda Cc: mark.rutland@arm.com, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 3/3] usb: gadget: udc: renesas_usb3: add support for R-Car M3-W In-Reply-To: <20170810174221.ovyl7bd64s6mjvyw@rob-hp-laptop> References: <1501813018-6116-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> <1501813018-6116-4-git-send-email-yoshihiro.shimoda.uh@renesas.com> <20170810174221.ovyl7bd64s6mjvyw@rob-hp-laptop> Date: Tue, 15 Aug 2017 12:46:38 +0300 Message-ID: <87pobx6u4h.fsf@linux.intel.com> MIME-Version: 1.0 Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi, Rob Herring writes: > On Fri, Aug 04, 2017 at 11:16:58AM +0900, Yoshihiro Shimoda wrote: >> This patch adds support for R-Car M3-W. This patch also adds R-Car >> Gen3 generic version's compatible and changes ".compatible" in >> the usb3_of_match from "renesas,r8a7796-usb3-peri" to >> "renesas,rcar-gen3-usb3-peri". >> >> Signed-off-by: Yoshihiro Shimoda >> --- >> Documentation/devicetree/bindings/usb/renesas_usb3.txt | 16 +++++++++++++--- >> drivers/usb/gadget/udc/renesas_usb3.c | 2 +- >> 2 files changed, 14 insertions(+), 4 deletions(-) > > Binding looks fine, but... > >> diff --git a/drivers/usb/gadget/udc/renesas_usb3.c b/drivers/usb/gadget/udc/renesas_usb3.c >> index aa2b185..b1e166c 100644 >> --- a/drivers/usb/gadget/udc/renesas_usb3.c >> +++ b/drivers/usb/gadget/udc/renesas_usb3.c >> @@ -2503,7 +2503,7 @@ static void renesas_usb3_init_ram(struct renesas_usb3 *usb3, struct device *dev, >> >> static const struct of_device_id usb3_of_match[] = { >> { >> - .compatible = "renesas,r8a7795-usb3-peri", >> + .compatible = "renesas,rcar-gen3-usb3-peri", > > You need to keep the existing string for compatibility with existing > dtbs. I've fixed it up locally: diff --git a/drivers/usb/gadget/udc/renesas_usb3.c b/drivers/usb/gadget/udc/renesas_usb3.c index ff69f4645b7c..16ceb445bee8 100644 --- a/drivers/usb/gadget/udc/renesas_usb3.c +++ b/drivers/usb/gadget/udc/renesas_usb3.c @@ -2512,6 +2512,10 @@ static const struct of_device_id usb3_of_match[] = { .compatible = "renesas,r8a7795-usb3-peri", .data = &renesas_usb3_priv_gen3, }, + { + .compatible = "renesas,rcar-gen3-usb3-peri", + .data = &renesas_usb3_priv_gen3, + }, { }, }; MODULE_DEVICE_TABLE(of, usb3_of_match);