From patchwork Wed Mar 22 04:02:43 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuninori Morimoto X-Patchwork-Id: 9638075 X-Patchwork-Delegate: geert@linux-m68k.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 74130602D6 for ; Wed, 22 Mar 2017 04:10:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 577EE277D9 for ; Wed, 22 Mar 2017 04:10:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4A9552793B; Wed, 22 Mar 2017 04:10:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B5151277D9 for ; Wed, 22 Mar 2017 04:10:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752007AbdCVEJq (ORCPT ); Wed, 22 Mar 2017 00:09:46 -0400 Received: from relmlor3.renesas.com ([210.160.252.173]:62092 "EHLO relmlie2.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751042AbdCVEJA (ORCPT ); Wed, 22 Mar 2017 00:09:00 -0400 Received: from unknown (HELO relmlir4.idc.renesas.com) ([10.200.68.154]) by relmlie2.idc.renesas.com with ESMTP; 22 Mar 2017 13:02:45 +0900 Received: from relmlac1.idc.renesas.com (relmlac1.idc.renesas.com [10.200.69.21]) by relmlir4.idc.renesas.com (Postfix) with ESMTP id 347AF3EC04; Wed, 22 Mar 2017 13:02:45 +0900 (JST) Received: by relmlac1.idc.renesas.com (Postfix, from userid 0) id 1D12F8002F; Wed, 22 Mar 2017 13:02:44 +0900 (JST) Received: from relmlac1.idc.renesas.com (localhost [127.0.0.1]) by relmlac1.idc.renesas.com (Postfix) with ESMTP id DDE5480086; Wed, 22 Mar 2017 13:02:44 +0900 (JST) Received: from relmlii2.idc.renesas.com [10.200.68.66] by relmlac1.idc.renesas.com with ESMTP id PAF27484; Wed, 22 Mar 2017 13:02:44 +0900 X-IronPort-AV: E=Sophos;i="5.36,202,1486393200"; d="scan'208";a="238204485" Received: from mail-ty1jpn01lp0179.outbound.protection.outlook.com (HELO JPN01-TY1-obe.outbound.protection.outlook.com) ([23.103.139.179]) by relmlii2.idc.renesas.com with ESMTP/TLS/AES256-SHA256; 22 Mar 2017 13:02:44 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesasgroup.onmicrosoft.com; s=selector1-renesas-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=pr7VB9dIiufGJTuHyJXMb+Vm4PhSKexNG0qRTJW3Y/g=; b=WV0x7Yz3TQfuZsrQN63aMF0Z9PnQVKn1BeWw0ar/DMeFCD6U7xPrJWlfNdndkUePqWddvvndKe775Em3gOItGBKq8mLciEe1WNkPjj/EqMUxDPPcXWCUIz6tFI6tDOx60Pe98pVRODEV3lyME8ZFMrp0G0NRiIsIuezitEC46wE= Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none; kernel.org; dmarc=none action=none header.from=renesas.com; Received: from morimoto-PC.renesas.com (211.11.155.144) by TY1PR06MB0829.apcprd06.prod.outlook.com (10.163.245.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.977.11; Wed, 22 Mar 2017 04:02:43 +0000 Message-ID: <87zigenerc.wl%kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto Subject: [PATCH] ASoC: rcar: ssi: don't set SSICR.CKDV = 000 with SSIWSR.CONT User-Agent: Wanderlust/2.15.9 Emacs/24.3 Mule/6.0 To: Mark Brown CC: Linux-ALSA , Simon , , Hiroyuki Yokoyama MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Date: Wed, 22 Mar 2017 04:02:43 +0000 X-Originating-IP: [211.11.155.144] X-ClientProxiedBy: KAWPR01CA0097.jpnprd01.prod.outlook.com (10.174.230.33) To TY1PR06MB0829.apcprd06.prod.outlook.com (10.163.245.23) X-MS-Office365-Filtering-Correlation-Id: 9a793c18-b812-4e6c-5c50-08d470d84af6 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081); SRVR:TY1PR06MB0829; X-Microsoft-Exchange-Diagnostics: 1; TY1PR06MB0829; 3:tWFBZWz5/Btiz/je1mjOhF/yUqCuCNVeU7zB1T3mMySsIxe16CGZAIqBpOYoMTcQoQUxV3vG8L/3pA/Fy5xdR5WWFkFukNKu5zdOYe0ejvmvyTBzRLj52E6khmWJyvhnwx/UZsysceTY0rcZEdMIqak5qqv1R65u0KLjoiW6kXLH5ih07wYShUbMk1vd3+cIehFOW9O4Q46cEXeydJFLbl97158P9lbsrDfwJms9Yn8Wy+qI0rW0Bca22rfh2d7RJB1MZAb/0UgDut3pxf9+ReJePHXFpJGh0jItsT3okRA=; 25:IEwTQhqAycyZPQVdmTXs1/JYsIaB4+5JGerkXoSaLXUeQejti9NpDaODGToWVkTJu3agtKFvio5/2Y4nIuf1B0J50O8Dhl8MtrZVRdKhEspNEEDo88cPg+zPv/+ffDnPUrD2/NAg/U5ZuHcGzwM84FAO8o1rpFN+9r3bBx7YCj6hAp2dG05MDa2updT/tz5EPQXY6LGsaZKzRx9tJG4Tu8vuWVXHU2a6HXFgLKt3RbsYs6SiVu3Mk3VLtMvKzE0jIR5qzHc8LfuJQjnTvjfBRAlP0KXcgszQgOBmnCIQRYvUzH+vW/pQK1/tC9qfDhzJlUQvDABNN9DVRRjPwGZEM4G/JcPLpsEls6kDe27PacfgL8aIGew4SQaUOdEXiUq3nrzRvOHyJd6vcRRCCjy2ZdWnrm4CMsQ3CmR2hMAzejrcR9MQ7J5cqzrCXB1Nd2Kj7CswNTFD4EquvvTo83Zctw== X-Microsoft-Exchange-Diagnostics: 1; TY1PR06MB0829; 31:lA8igge/OxHJ/GQwrp1MkRlKLi2YbVH4GFOcEYfppmR8yi5H9ANCNsybt36kGUqBNjUHHqUXLJUbohpzdy9NuIcv2LrVEzOhth0Eqc5UQ4xMPYSFqgjCrkfANyO76scdHL5qK6xwKThHruWweCfzeOAWGPfVBVdhHMbzM9/lSF5y6+T2t+DicKggMwFZysC5HuhTBSCJ6GwH6/2eCUAxJPkTQZf1fFE54JHrC3x7e3A=; 20:/pKuuA0X2T55O4r9fNy1ukT6zwbBzlWgocIpvA/g3yR1YXRU0xY1EaBqA4PVurRyZ3wUttxO0pzlC4cGggUijY7CkXTxHjsiXY4UMR12TWk2HcWwzMNm12JqOAtpc5wkwgtgLNYMvIypHRZ+oc65L69HLr47gzRtDt/9li7/4/RXRxRxkVbIoA6owPdrpu+9wcXJuL0eg7hufnD8r62vanA/3Q6vWxHSGXHOd1NRHDurOtWFwEtPXdwlpdSoroy6GEF/WjpyKe0BGKJ+JJOBVZGStRYvKrRrLgDLZ+xmWyh/tk/QhjsVVJRD1pAGDlcIVL1cNXGabdV4ylHLPwpvcTnjaSnq5r5QHBLw7gzAT+UKcCU7fiJsN7swXTs6v/0en5gjk1aGzyN+R2Y2rBBj8rx692o7m8bkxCYBnVQ8uuZHaQ62umVYdjPk+XjnZ7TcV8js5peSiE3eaoHvbPBPfjvT7OK95FQWGOSO8DPwb6pFgmYDkX4E2Cx6mU0vQD11 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026)(6041248)(20161123562025)(20161123564025)(20161123558025)(20161123555025)(20161123560025)(6072148); SRVR:TY1PR06MB0829; BCL:0; PCL:0; RULEID:; SRVR:TY1PR06MB0829; X-Microsoft-Exchange-Diagnostics: 1; TY1PR06MB0829; 4:vMvHZWJOBbfptD+4VBY0HXHdW2To6BrsYJi2eglS0w76Px2vM0dE9ZRzH04UAGhUNllGM2YEBmTQh6n9RDoboJ8vRKT0Ro7AKPOhDxuy7+X9tO7jzBedOEPQ8t3GJz8XgCZHlZXGWUqNMMK+d68YGRKMUXt89lk+xJRJeZ99Gu7rl5nStGOOQShcQ49F4Q21DaxkLVCC+jM5kZ5dWvuTluIGZHQCriY/H95ajebGxPoc5PW8m9b1nE90D+UUF3Wcc4LtLg3rbXWxBF76XkQ9f04zh0l6nDC9qPNzWtn6aDRd/bAj3lt3uhJvkTqj+habHqlfvS6wQ6x2HNqqhbwsMl349iXV/z+McEdnYAhvLUJTsbemOFyB6ZUBFSqBVvhPJgE+OoRYd1N/zkABQoH8IU6LlGhZMc/ofcws3cWOmvhVjZTz7OYq8VyfhaAztqzHxtxwmjpgOj2XrsRjS1LLzGxXxtopMXiyTyExC0/I1Knebcjua3BsUhCfrMTuxWwzNMffVzGpgcMXxH3Ve1pH+JsvVNbGVeZx776C6ZDGsiPy/P2HhQhQW1ZbMZyv9CkTqZWgpcNX4km6ts6+SfiFsp9+/wGeVTx3/wpJUK8mSqLVYhezCNrmBeBP+p2K3Ly0 X-Forefront-PRVS: 02543CD7CD X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(4630300001)(6009001)(39450400003)(39860400002)(39850400002)(39840400002)(39410400002)(4001350100001)(86362001)(189998001)(46406003)(54356999)(53416004)(50986999)(8676002)(42186005)(5660300001)(33646002)(50466002)(305945005)(47776003)(7736002)(6486002)(4326008)(36756003)(23726003)(25786009)(3846002)(107886003)(110136004)(6116002)(38730400002)(2906002)(6916009)(81166006)(83506001)(54906002)(53936002)(66066001)(16060500001); DIR:OUT; SFP:1102; SCL:1; SRVR:TY1PR06MB0829; H:morimoto-PC.renesas.com; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; TY1PR06MB0829; 23:kPJSMhs2tRVCLtBrfFNa2YjgrH6uAxCRZO6L5SbPH?= =?us-ascii?Q?IcAgns0ghEinD9yFzgvopLmjkQlc/0XZAqp0x0SnuGq17jpuxy9jHNrbvSdg?= =?us-ascii?Q?fO36TqAzEYbkty0wSXl7MqUBX3fu66J+CjvAtkMixrO4ZhAZzBUGU0pve7My?= =?us-ascii?Q?IYDMSgnUQkVtaxO3/GFSMmqhZuQJXOgesphiXSCFLYNJLg7LI2CQ+SbLHXL8?= =?us-ascii?Q?v496JLHtyijxV1Zptz/SyQSjrRuXTgc5suubc2WntrzbOPFkSfOQvUm5cytr?= =?us-ascii?Q?sx9S1AWeJGTmwndXUCPWx3PzMqjLb6gbd3mJAlERncrDHWr4i8G4bAXZ7nwj?= =?us-ascii?Q?OqdY8n8PeD0MSR3el8h2oQjNok+KZdwO5guLs+8cXcZBvV1UxC6uWAHHgOy8?= =?us-ascii?Q?b04INil0D/n+6VXJPE+LKHWBDfL/hBsPctvfZYKrvx7c/rYYT23uymoe0ewM?= =?us-ascii?Q?d06hQsyE5J2C/9pSjc5DeXWQUGwWvtOlWj41QPAJWa2O7bTbaRhUzSKw83YV?= =?us-ascii?Q?ABYhtQzSXMa+/dQg5N5NAj9yYvM18dkQVYEb+jjLTU7NvDbMa0e/rg6qsCGo?= =?us-ascii?Q?bG35xpBGjzyrFMn2Y7a+sHwjfv9ClZChon1pDpRjuKrwXci5qTV0IqqmaEfa?= =?us-ascii?Q?BOXlUna6swnBwYBOZuZUv06RKUJVJbZs2H/5jK1Ou14Olg8gw9LjiIGvfFIi?= =?us-ascii?Q?NWHg6uHn8UWKd/N9+ifpeL94S5olrRd8rrBGFX50K1yHrqzBedeXxQzmH+XX?= =?us-ascii?Q?X0BSILhHYiOshb7Kfl1S+lMHUldM5X+qKgH3JFGDq00Jt2yOv/bFqtoRh0gx?= =?us-ascii?Q?kz9LOPBuDBfafXtNLK7HpR2o+XhLP5HBx3KSf6mBx9NZvp9V0tZ9RmBu+u0A?= =?us-ascii?Q?VBMM0bL6BvaLj7Os15eC1GnZeofxGE1rLwsVVWWBxei7TBMclguAmdG0AcOT?= =?us-ascii?Q?EGVPrYf0IgPm/hCScLNAl7OgO30y3BeRq+k5pdvoKHvgj0uqdBdJ7zWDTnwn?= =?us-ascii?Q?sKURzaVk+OsBD+CJx1eoB8jGxUFUPY+XYglEV+wE+eCAg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; TY1PR06MB0829; 6:Ebl4FU4gSsEjAIjJTsLUNHzbk4x2OBxQ00fu5Y9nl1hOCLa81GlIiRvu6ULXEaXMtovddAh3enue2of9XsHDQrZW0WA6f+kZKTWZWqqj9j0F/EAM/jaYXy+rbOyXTyb+q9gw4mqWChNTRMslhKmvlA/5GlX9mlYAj7Pyo0Lhk4rlPKSrgntxnyJhxMvfPilLXfPDqfdr7q+lBdciwWcXH8tYmEoD9XQmeewqJ4TewLwy+qTcrHF8lgcbi18t29xxh5rxy5GlV2VzaxVQrm4/NGkbQqTKPhbxWvegqOSELtgONdIxNVFH09pJ6pqSV9OX9WhMOFa/+hGdyMLN9QdM0GkzI3hlLci8k+LW1OgzkjYCLJftxFeOOiHjLVyVO005a/Ou7wptg+kfn8t0zVAu/05OnkoJcPF8iL3jqUFdA1Y=; 5:92QrFONokUaGAGvuYgOSj219Xc0h/tc/b3plFfPUS7rKkR5qvettEJ9siBs8Jt5OEnNkaOPpmzfnxBlEca5M7OrX5ccrhTuNN520q0juaUQsUwweafgNlTUIOIlSe2PX6B3IzDj95bEMgyY6plZkxA==; 24:wvvfrh159nUdejjzT0q664jABATQjyedxLB1fugxfseg3qUvv7MDFxiSATN8HLVKTIZ2J2qOil0O3aqNg7cud+iydq+k52gAl5zfRKY/c70= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; TY1PR06MB0829; 7:Ay8LPz+tRxv6quAXHtjTe65tp+xYunB2Wn9+U03vvWCzl2hiImTwspkH1inDV1JpjsgTKPh2DvaKwxrX60+0Ij3fzPVHu6dk4FP0+s/5x3JmSnunBoUqgpc7BUGOyhGJS3OEKIindFgldvEwa7eYvmHzDozmK17myb9CUpbteYZYePcCc3/rWWwBD4caGMWtZkhJUMfYSThVO3jWwfM3L+4qVFdKcVLGkaIdQB9JsqX5h0RQx15dZrgniW7BifN1PdOB1yR0ap5eYKa3xLlSUBAcUiYEi7E/KVaTqvrNaQWsuwEeP6bmT2SDUnen7i9XspHjohGFuD7XUFgdIaJpvg==; 20:u31gPkxD6PG2hSpxe049qyAyf3p+juUApXSiQKaPHVtDjM/NFz8DSVhRYHnk5euxaANQb5zOHu8fhsvXgjL0OaVaCgM3QbqG8P6rE0q/N+DPzfnWZXGLnKlRkOT04v/r45pq78IQujNuae0Vco3UvkCOuXdaremdvWWBuJMOCWE= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2017 04:02:43.7707 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY1PR06MB0829 Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Kuninori Morimoto R-Car Datasheet is indicating "SSICR.CKDV = 000 is invalid when SSIWSR.WS_MODE = 1 or SSIWSR.CONT = 1". Current driver will set CONT, thus, we shouldn't use CKDV = 000. This patch fixup it. Reported-by: Hiroyuki Yokoyama Signed-off-by: Kuninori Morimoto Tested-by: Hiroyuki Yokoyama --- sound/soc/sh/rcar/ssi.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/sound/soc/sh/rcar/ssi.c b/sound/soc/sh/rcar/ssi.c index 9594d44..d0602c1 100644 --- a/sound/soc/sh/rcar/ssi.c +++ b/sound/soc/sh/rcar/ssi.c @@ -245,6 +245,15 @@ static int rsnd_ssi_master_clk_start(struct rsnd_mod *mod, for (j = 0; j < ARRAY_SIZE(ssi_clk_mul_table); j++) { /* + * It will set SSIWSR.CONT here, but SSICR.CKDV = 000 + * with it is not allowed. (SSIWSR.WS_MODE with + * SSICR.CKDV = 000 is not allowed either). + * Skip it. See SSICR.CKDV + */ + if (j == 0) + continue; + + /* * this driver is assuming that * system word is 32bit x chan * see rsnd_ssi_init()