| Message ID | 8c72d27f-8b1a-23cf-3f41-781944cd1388@cogentembedded.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
Hi Sergei, On Mon, Jun 25, 2018 at 10:37 PM Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote: > The *enum* RPADIR_BIT was declared in the commit 86a74ff21a7a ("net: > sh_eth: add support for Renesas SuperH Ethernet") adding SH771x support, > however the SH771x manual doesn't have the RPADIR register described and, > moreover, tells why the padding insertion must not be used. The newer SoC > manuals do have RPADIR documented, though with somewhat different layout -- > update the *enum* according to these manuals... > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Thanks for your patch! Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- net-next.orig/drivers/net/ethernet/renesas/sh_eth.h > +++ net-next/drivers/net/ethernet/renesas/sh_eth.h > @@ -403,8 +403,7 @@ enum DESC_I_BIT { > > /* RPADIR */ > enum RPADIR_BIT { > - RPADIR_PADS1 = 0x20000, RPADIR_PADS0 = 0x10000, > - RPADIR_PADR = 0x0003f, > + RPADIR_PADS = 0x1f0000, RPADIR_PADR = 0xffff, Perhaps add some comments? RPADIR_PADS = 0x1f0000; /* Padding Size (insert N bytes of padding) */ RPADIR_PADR = 0xffff; /* Padding Slot (insert padding at byte N) */ > }; Note that none of the RPADIR enums are actually used. Gr{oetje,eeting}s, Geert
On 6/26/2018 10:25 AM, Geert Uytterhoeven wrote: >> The *enum* RPADIR_BIT was declared in the commit 86a74ff21a7a ("net: >> sh_eth: add support for Renesas SuperH Ethernet") adding SH771x support, >> however the SH771x manual doesn't have the RPADIR register described and, >> moreover, tells why the padding insertion must not be used. The newer SoC >> manuals do have RPADIR documented, though with somewhat different layout -- >> update the *enum* according to these manuals... >> >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > Thanks for your patch! > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > >> --- net-next.orig/drivers/net/ethernet/renesas/sh_eth.h >> +++ net-next/drivers/net/ethernet/renesas/sh_eth.h >> @@ -403,8 +403,7 @@ enum DESC_I_BIT { >> >> /* RPADIR */ >> enum RPADIR_BIT { >> - RPADIR_PADS1 = 0x20000, RPADIR_PADS0 = 0x10000, >> - RPADIR_PADR = 0x0003f, >> + RPADIR_PADS = 0x1f0000, RPADIR_PADR = 0xffff, > > Perhaps add some comments? > > RPADIR_PADS = 0x1f0000; /* Padding Size (insert N bytes of padding) */ > RPADIR_PADR = 0xffff; /* Padding Slot (insert padding at byte N) */ It would be nice but inconsistent with what we do for the other registers... >> }; > > Note that none of the RPADIR enums are actually used. I'd surely noted that. :-) > Gr{oetje,eeting}s, > > Geert > MBR, Sergei
Index: net-next/drivers/net/ethernet/renesas/sh_eth.h =================================================================== --- net-next.orig/drivers/net/ethernet/renesas/sh_eth.h +++ net-next/drivers/net/ethernet/renesas/sh_eth.h @@ -403,8 +403,7 @@ enum DESC_I_BIT { /* RPADIR */ enum RPADIR_BIT { - RPADIR_PADS1 = 0x20000, RPADIR_PADS0 = 0x10000, - RPADIR_PADR = 0x0003f, + RPADIR_PADS = 0x1f0000, RPADIR_PADR = 0xffff, }; /* FDR */
The *enum* RPADIR_BIT was declared in the commit 86a74ff21a7a ("net: sh_eth: add support for Renesas SuperH Ethernet") adding SH771x support, however the SH771x manual doesn't have the RPADIR register described and, moreover, tells why the padding insertion must not be used. The newer SoC manuals do have RPADIR documented, though with somewhat different layout -- update the *enum* according to these manuals... Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> --- drivers/net/ethernet/renesas/sh_eth.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)