From patchwork Thu Apr 21 03:41:14 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yoshihiro Shimoda X-Patchwork-Id: 8895871 X-Patchwork-Delegate: horms@verge.net.au Return-Path: X-Original-To: patchwork-linux-renesas-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 3429FBF29F for ; Thu, 21 Apr 2016 03:41:23 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 6EF2E202FE for ; Thu, 21 Apr 2016 03:41:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A1CAB202F2 for ; Thu, 21 Apr 2016 03:41:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751743AbcDUDlV (ORCPT ); Wed, 20 Apr 2016 23:41:21 -0400 Received: from relmlor4.renesas.com ([210.160.252.174]:29188 "EHLO relmlie3.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751720AbcDUDlT convert rfc822-to-8bit (ORCPT ); Wed, 20 Apr 2016 23:41:19 -0400 Received: from unknown (HELO relmlir1.idc.renesas.com) ([10.200.68.151]) by relmlie3.idc.renesas.com with ESMTP; 21 Apr 2016 12:41:16 +0900 Received: from relmlac2.idc.renesas.com (relmlac2.idc.renesas.com [10.200.69.22]) by relmlir1.idc.renesas.com (Postfix) with ESMTP id 8D73C4CBEF; Thu, 21 Apr 2016 12:41:16 +0900 (JST) Received: by relmlac2.idc.renesas.com (Postfix, from userid 0) id 6A3722806E; Thu, 21 Apr 2016 12:41:16 +0900 (JST) Received: from relmlac2.idc.renesas.com (localhost [127.0.0.1]) by relmlac2.idc.renesas.com (Postfix) with ESMTP id 5E5842806D; Thu, 21 Apr 2016 12:41:16 +0900 (JST) Received: from relmlii1.idc.renesas.com [10.200.68.65] by relmlac2.idc.renesas.com with ESMTP id NAJ21462; Thu, 21 Apr 2016 12:41:16 +0900 X-IronPort-AV: E=Sophos;i="5.22,559,1449500400"; d="scan'208";a="209384878" Received: from mail-sg2apc01lp0243.outbound.protection.outlook.com (HELO APC01-SG2-obe.outbound.protection.outlook.com) ([65.55.88.243]) by relmlii1.idc.renesas.com with ESMTP/TLS/AES256-SHA; 21 Apr 2016 12:41:15 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesasgroup.onmicrosoft.com; s=selector1-renesas-com; h=From:To:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Fk8pOiOpp3VI8Iz47CMN70V+CIdrpxz6rqrJEv9x0N0=; b=kM/AVDcOvQTaKk0lKQ8wSfPmg6aSIxHCA3C1RMJuf/6ih016jWztTDtZ60CrU9A17IX2xbMxrKVKz+5bH/Ufbpfh4qWWf0Yhi9aybQYWvHgakdT4+RWbyjFs+Uk8de0/0QEFnVY7tDUWvyajSoRJtujmXyuQmAwjZkNg/+mgXPM= Received: from SG2PR06MB0919.apcprd06.prod.outlook.com (10.162.204.152) by SG2PR06MB0917.apcprd06.prod.outlook.com (10.162.200.158) with Microsoft SMTP Server (TLS) id 15.1.466.19; Thu, 21 Apr 2016 03:41:14 +0000 Received: from SG2PR06MB0919.apcprd06.prod.outlook.com ([10.162.204.152]) by SG2PR06MB0919.apcprd06.prod.outlook.com ([10.162.204.152]) with mapi id 15.01.0466.023; Thu, 21 Apr 2016 03:41:14 +0000 From: Yoshihiro Shimoda To: Simon Horman CC: "magnus.damm@gmail.com" , "robh+dt@kernel.org" , "pawel.moll@arm.com" , "mark.rutland@arm.com" , "ijc+devicetree@hellion.org.uk" , "galak@codeaurora.org" , "devicetree@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" Subject: RE: [PATCH] arm64: defconfig: Add Renesas R-Car USB 3.0 driver support Thread-Topic: [PATCH] arm64: defconfig: Add Renesas R-Car USB 3.0 driver support Thread-Index: AQHRmuFAGx+gIYCa2k+bJhgES+qOX5+TwkgAgAAEvWA= Date: Thu, 21 Apr 2016 03:41:14 +0000 Message-ID: References: <1461142034-5008-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> <20160421031514.GB11116@verge.net.au> In-Reply-To: <20160421031514.GB11116@verge.net.au> Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: verge.net.au; dkim=none (message not signed) header.d=none; verge.net.au; dmarc=none action=none header.from=renesas.com; x-originating-ip: [211.11.155.144] x-ms-office365-filtering-correlation-id: a8d7824f-8788-4622-a71c-08d36996c9ea x-microsoft-exchange-diagnostics: 1; SG2PR06MB0917; 5:9xhNvi0k9rjRgVqfmeFrl5QOG4yKSY1hTsT/tcYN6s3DcLrKMHCrH6y/XtEsXM245FCKyaXB635XVW2v3At29sW/abSdY41A8czDc5nbzL78BOEu/EYTrBuupgcwlNT4xEpiYKuE5FOBu7tOFdy0QZXRxAoRmbFdLlV1GhHteBvCKoLAb+WYtYAmRSAxowQX; 24:5wBDB7uaKytQQistT378XgAuFWhJm6o8ui8cP5xfNOv9vqGojb8J0gwWhb21KrJtL4MePvGTO8NQ5hd9QdgzeJSZ+rTNH49h+qy3GgYBSOk=; 7:i2RmZ3ugC8ERdZCj0a53lrWu92bAdtaXc4v9vpEXAQ1U2+FA8iWosZ1hgay+qJ9F0FstbrPz6hhXdcNVw7ow9RI9aIpRSurW/sByRKLHoXriw+Tk6Q+9ht7dcxASTFKwrEHO37UbB4Vc7BjUHa9OAmqBCQo9GT3sK50GCKKXtBLF6UWcl8kfuDKzocGO5KHOvN4DODMvziL5imXdONOmeJwnmB7Qdy8/djgp6pg93Nc=; 20:LAI4n+lrUCcJDqZmgWM85b7Zb8lvBi8LVGpSX9F/36FyvO10y6BATmbfm4jO9LDTc4pmyqUmitpGHRonboc/4ntEUYjFEJEVNGPEzriJYbSGPk8EHcP+Y0+2tyOrPkC497IrbxuoJMwYL2qCU4uDvryP+F9CuWVzN0jPQvDKtx0= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SG2PR06MB0917; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(9101521026)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026); SRVR:SG2PR06MB0917; BCL:0; PCL:0; RULEID:; SRVR:SG2PR06MB0917; x-forefront-prvs: 091949432C x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(54534003)(377454003)(24454002)(5002640100001)(2950100001)(9686002)(81166005)(3280700002)(189998001)(2906002)(76176999)(54356999)(5003600100002)(3660700001)(92566002)(110136002)(5004730100002)(77096005)(122556002)(2900100001)(74316001)(87936001)(1220700001)(10400500002)(33656002)(5008740100001)(11100500001)(19580405001)(19580395003)(586003)(6116002)(102836003)(3846002)(66066001)(50986999)(106116001)(86362001)(76576001)(1096002); DIR:OUT; SFP:1102; SCL:1; SRVR:SG2PR06MB0917; H:SG2PR06MB0919.apcprd06.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2016 03:41:14.1418 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB0917 Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Simon-san, > From: Simon Horman > Sent: Thursday, April 21, 2016 12:15 PM > > Hi Shimoda-san, > > On Wed, Apr 20, 2016 at 05:47:14PM +0900, Yoshihiro Shimoda wrote: > > If we doesn't enable this configuration and runs on R-Car Gen3, > > xhci host driver will cause timeout in xhci_reset() because > > the R-Car Gen3 xHCI controller needs specific initialization. > > > > [ 1.565605] xhci-hcd ee000000.usb: xHCI Host Controller > > [ 1.570636] xhci-hcd ee000000.usb: new USB bus registered, assigned bus number 5 > > [ 22.270160] xhci-hcd ee000000.usb: can't setup: -110 > > [ 22.274931] xhci-hcd ee000000.usb: USB bus 5 deregistered > > [ 22.280158] xhci-hcd: probe of ee000000.usb failed with error -110 I'm afraid but this issue can be fixed if we apply the following patch into xhci-rcar.h. So, I will submit such a patch to USB ML later. ============================================================================== Also I will remove this commit log from in this patch. > > Remarks: > > The timestamp doesn't work correctly on R-Car H3 ES1.0. It should be > > 10 seconds. > > > > Signed-off-by: Yoshihiro Shimoda > > --- > > arch/arm64/configs/defconfig | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > > index a44ef99..a95751d 100644 > > --- a/arch/arm64/configs/defconfig > > +++ b/arch/arm64/configs/defconfig > > @@ -1,7 +1,6 @@ > > # CONFIG_LOCALVERSION_AUTO is not set > > CONFIG_SYSVIPC=y > > CONFIG_POSIX_MQUEUE=y > > -CONFIG_FHANDLE=y > > CONFIG_AUDIT=y > > CONFIG_NO_HZ_IDLE=y > > CONFIG_HIGH_RES_TIMERS=y > > Is the hunk above intended? > It does not seem to match my reading of the changelog. Perhaps I should make a patch for this change because if I did the following commands, this change appeared. on renesas-devel-20160420-v4.6-rc4 $ make defconfig $ cp defconfig arch/arm64/config $ git diff Best regards, Yoshihiro Shimoda > > @@ -192,7 +191,7 @@ CONFIG_SND_SOC_AK4613=y > > CONFIG_USB=y > > CONFIG_USB_OTG=y > > CONFIG_USB_XHCI_HCD=y > > -CONFIG_USB_XHCI_PLATFORM=y > > +CONFIG_USB_XHCI_RCAR=y > > CONFIG_USB_EHCI_HCD=y > > CONFIG_USB_EHCI_MSM=y > > CONFIG_USB_EHCI_HCD_PLATFORM=y > > -- > > 1.9.1 ============================================================================== diff --git a/drivers/usb/host/xhci-rcar.h b/drivers/usb/host/xhci-rcar.h index 2941a25..0681235 100644 --- a/drivers/usb/host/xhci-rcar.h +++ b/drivers/usb/host/xhci-rcar.h @@ -24,7 +24,7 @@ static inline void xhci_rcar_start(struct usb_hcd *hcd) static inline int xhci_rcar_init_quirk(struct usb_hcd *hcd) { - return 0; + return -ENODEV; } #endif #endif /* _XHCI_RCAR_H */