| Message ID | aa1a92cf69dc341724bcb5662de994a54cb14422.1690382707.git.geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | [PATCH/RFT] arm64: dts: renesas: spider-cpu: Add GP LEDs | expand |
On Wed, Jul 26, 2023 at 4:46 PM Geert Uytterhoeven <geert+renesas@glider.be> wrote: > Describe the two General Purpose LEDs LED7 and LED8 on the Spider CPU > board, so they can be used as indicator LEDs. > > Note that General Purpose LEDs LED9 to LED11 are not added, as they are > connected to GPIO block 4, which can only be accessed from the Control > Domain. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > I do not have physical access to a Spider development board. > Thanks for testing! Kieran and I held a remote test session over IRC and Jitsi, and the LEDs are working as expected. Thanks Kieran! Gr{oetje,eeting}s, Geert
Quoting Geert Uytterhoeven (2023-07-26 15:45:57) > Describe the two General Purpose LEDs LED7 and LED8 on the Spider CPU > board, so they can be used as indicator LEDs. > > Note that General Purpose LEDs LED9 to LED11 are not added, as they are > connected to GPIO block 4, which can only be accessed from the Control > Domain. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > I do not have physical access to a Spider development board. > Thanks for testing! In collaboration with Geert, Tested-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > --- > .../boot/dts/renesas/r8a779f0-spider-cpu.dtsi | 20 +++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a779f0-spider-cpu.dtsi b/arch/arm64/boot/dts/renesas/r8a779f0-spider-cpu.dtsi > index dd8e0e1595260b3d..76a94812875ef261 100644 > --- a/arch/arm64/boot/dts/renesas/r8a779f0-spider-cpu.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a779f0-spider-cpu.dtsi > @@ -6,6 +6,8 @@ > */ > > #include <dt-bindings/gpio/gpio.h> > +#include <dt-bindings/leds/common.h> > + > #include "r8a779f0.dtsi" > > / { > @@ -22,6 +24,24 @@ chosen { > stdout-path = "serial0:1843200n8"; > }; > > + leds { > + compatible = "gpio-leds"; > + > + led-7 { I presume there is a reason to start the sequence at 7? But that's fine with me anyway... Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > + gpios = <&gpio0 11 GPIO_ACTIVE_HIGH>; > + color = <LED_COLOR_ID_GREEN>; > + function = LED_FUNCTION_INDICATOR; > + function-enumerator = <7>; > + }; > + > + led-8 { > + gpios = <&gpio0 14 GPIO_ACTIVE_HIGH>; > + color = <LED_COLOR_ID_GREEN>; > + function = LED_FUNCTION_INDICATOR; > + function-enumerator = <8>; > + }; > + }; > + > memory@48000000 { > device_type = "memory"; > /* first 128MB is reserved for secure area. */ > -- > 2.34.1 >
Hi Kieran, On Wed, Jul 26, 2023 at 5:45 PM Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> wrote: > Quoting Geert Uytterhoeven (2023-07-26 15:45:57) > > Describe the two General Purpose LEDs LED7 and LED8 on the Spider CPU > > board, so they can be used as indicator LEDs. > > > > Note that General Purpose LEDs LED9 to LED11 are not added, as they are > > connected to GPIO block 4, which can only be accessed from the Control > > Domain. > > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > --- > > I do not have physical access to a Spider development board. > > Thanks for testing! > > In collaboration with Geert, > > Tested-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > > > --- > > .../boot/dts/renesas/r8a779f0-spider-cpu.dtsi | 20 +++++++++++++++++++ > > 1 file changed, 20 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/renesas/r8a779f0-spider-cpu.dtsi b/arch/arm64/boot/dts/renesas/r8a779f0-spider-cpu.dtsi > > index dd8e0e1595260b3d..76a94812875ef261 100644 > > --- a/arch/arm64/boot/dts/renesas/r8a779f0-spider-cpu.dtsi > > +++ b/arch/arm64/boot/dts/renesas/r8a779f0-spider-cpu.dtsi > > @@ -6,6 +6,8 @@ > > */ > > > > #include <dt-bindings/gpio/gpio.h> > > +#include <dt-bindings/leds/common.h> > > + > > #include "r8a779f0.dtsi" > > > > / { > > @@ -22,6 +24,24 @@ chosen { > > stdout-path = "serial0:1843200n8"; > > }; > > > > + leds { > > + compatible = "gpio-leds"; > > + > > + led-7 { > > I presume there is a reason to start the sequence at 7? > But that's fine with me anyway... They're called LED7 and LED8 in the schematics... Gr{oetje,eeting}s, Geert
Hi Geert-san, > From: Geert Uytterhoeven, Sent: Wednesday, July 26, 2023 11:46 PM > > Describe the two General Purpose LEDs LED7 and LED8 on the Spider CPU > board, so they can be used as indicator LEDs. > > Note that General Purpose LEDs LED9 to LED11 are not added, as they are > connected to GPIO block 4, which can only be accessed from the Control > Domain. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Thank you for the patch! Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> And, I tested test patch on my environment. Tested-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Best regards, Yoshihiro Shimoda > --- > I do not have physical access to a Spider development board. > Thanks for testing! > --- > .../boot/dts/renesas/r8a779f0-spider-cpu.dtsi | 20 +++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a779f0-spider-cpu.dtsi > b/arch/arm64/boot/dts/renesas/r8a779f0-spider-cpu.dtsi > index dd8e0e1595260b3d..76a94812875ef261 100644 > --- a/arch/arm64/boot/dts/renesas/r8a779f0-spider-cpu.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a779f0-spider-cpu.dtsi > @@ -6,6 +6,8 @@ > */ > > #include <dt-bindings/gpio/gpio.h> > +#include <dt-bindings/leds/common.h> > + > #include "r8a779f0.dtsi" > > / { > @@ -22,6 +24,24 @@ chosen { > stdout-path = "serial0:1843200n8"; > }; > > + leds { > + compatible = "gpio-leds"; > + > + led-7 { > + gpios = <&gpio0 11 GPIO_ACTIVE_HIGH>; > + color = <LED_COLOR_ID_GREEN>; > + function = LED_FUNCTION_INDICATOR; > + function-enumerator = <7>; > + }; > + > + led-8 { > + gpios = <&gpio0 14 GPIO_ACTIVE_HIGH>; > + color = <LED_COLOR_ID_GREEN>; > + function = LED_FUNCTION_INDICATOR; > + function-enumerator = <8>; > + }; > + }; > + > memory@48000000 { > device_type = "memory"; > /* first 128MB is reserved for secure area. */ > -- > 2.34.1
diff --git a/arch/arm64/boot/dts/renesas/r8a779f0-spider-cpu.dtsi b/arch/arm64/boot/dts/renesas/r8a779f0-spider-cpu.dtsi index dd8e0e1595260b3d..76a94812875ef261 100644 --- a/arch/arm64/boot/dts/renesas/r8a779f0-spider-cpu.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a779f0-spider-cpu.dtsi @@ -6,6 +6,8 @@ */ #include <dt-bindings/gpio/gpio.h> +#include <dt-bindings/leds/common.h> + #include "r8a779f0.dtsi" / { @@ -22,6 +24,24 @@ chosen { stdout-path = "serial0:1843200n8"; }; + leds { + compatible = "gpio-leds"; + + led-7 { + gpios = <&gpio0 11 GPIO_ACTIVE_HIGH>; + color = <LED_COLOR_ID_GREEN>; + function = LED_FUNCTION_INDICATOR; + function-enumerator = <7>; + }; + + led-8 { + gpios = <&gpio0 14 GPIO_ACTIVE_HIGH>; + color = <LED_COLOR_ID_GREEN>; + function = LED_FUNCTION_INDICATOR; + function-enumerator = <8>; + }; + }; + memory@48000000 { device_type = "memory"; /* first 128MB is reserved for secure area. */
Describe the two General Purpose LEDs LED7 and LED8 on the Spider CPU board, so they can be used as indicator LEDs. Note that General Purpose LEDs LED9 to LED11 are not added, as they are connected to GPIO block 4, which can only be accessed from the Control Domain. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- I do not have physical access to a Spider development board. Thanks for testing! --- .../boot/dts/renesas/r8a779f0-spider-cpu.dtsi | 20 +++++++++++++++++++ 1 file changed, 20 insertions(+)