From patchwork Fri Mar 20 16:12:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Riesen X-Patchwork-Id: 11449837 X-Patchwork-Delegate: kieran@bingham.xyz Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7CFBB13B1 for ; Fri, 20 Mar 2020 16:38:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 64FAE20709 for ; Fri, 20 Mar 2020 16:38:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727519AbgCTQiI (ORCPT ); Fri, 20 Mar 2020 12:38:08 -0400 Received: from mout.kundenserver.de ([217.72.192.75]:57623 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727093AbgCTQiH (ORCPT ); Fri, 20 Mar 2020 12:38:07 -0400 Received: from mail.cetitecgmbh.com ([87.190.42.90]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MoOpq-1jdLni3E6a-00ops3 for ; Fri, 20 Mar 2020 17:38:06 +0100 Received: from pflvmailgateway.corp.cetitec.com (unknown [127.0.0.1]) by mail.cetitecgmbh.com (Postfix) with ESMTP id 8A918650123 for ; Fri, 20 Mar 2020 16:38:06 +0000 (UTC) X-Virus-Scanned: amavisd-new at cetitec.com Received: from mail.cetitecgmbh.com ([127.0.0.1]) by pflvmailgateway.corp.cetitec.com (pflvmailgateway.corp.cetitec.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UCCVUAskblkt for ; Fri, 20 Mar 2020 17:38:06 +0100 (CET) Received: from pfwsexchange.corp.cetitec.com (unknown [10.10.1.99]) by mail.cetitecgmbh.com (Postfix) with ESMTPS id 4341464E0F8 for ; Fri, 20 Mar 2020 17:38:06 +0100 (CET) Received: from pflmari.corp.cetitec.com (10.8.5.41) by PFWSEXCHANGE.corp.cetitec.com (10.10.1.99) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 20 Mar 2020 17:38:06 +0100 Received: by pflmari.corp.cetitec.com (Postfix, from userid 1000) id 9E6F480504; Fri, 20 Mar 2020 17:12:02 +0100 (CET) Date: Fri, 20 Mar 2020 17:12:02 +0100 From: Alex Riesen To: Kieran Bingham CC: Geert Uytterhoeven , Mauro Carvalho Chehab , Hans Verkuil , "Laurent Pinchart" , Rob Herring , Mark Rutland , Kuninori Morimoto , , , , , Subject: [PATCH v3 07/11] media: adv748x: only activate DAI if it is described in device tree Message-ID: Mail-Followup-To: Alex Riesen , Kieran Bingham , Geert Uytterhoeven , Mauro Carvalho Chehab , Hans Verkuil , Laurent Pinchart , Rob Herring , Mark Rutland , Kuninori Morimoto , devel@driverdev.osuosl.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Originating-IP: [10.8.5.41] X-ClientProxiedBy: PFWSEXCHANGE.corp.cetitec.com (10.10.1.99) To PFWSEXCHANGE.corp.cetitec.com (10.10.1.99) X-EsetResult: clean, is OK X-EsetId: 37303A290D7F536A6D7660 X-Provags-ID: V03:K1:HddHdWPPzV+3nJLEq2WEJhJnRC01Ta3u94WnOuNhwBmh2nBBOIL oe9TOfDbetg05yT64sNO1wKBNeQpp+0ufQq+EmTN5DThixfKcOl/ix9Afg8Pic33eF7NMG8 LIWGS4PiClYEtaZtu6ssok83wRc8fkW2RmoODtX485QjyoiKZEcfljEF/X/rS8UROs6apUp wvGFrZ+i9P69Tl0sHVe2A== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:ZODtHJEdC9U=:10fMQB9PJxy/sVqliPmzCE BmPQIQkvCI9NYCIA1UVmCTdm/BcK2SYE86TVoVYC1BnQrwGota6WtsrafI0QERZSbjFMrSARi jUMi46bA4mmk7Zj1pwHXWE8gbApHqDrczdmBSfckvlmNe83x4R4bVlA3ipgYDWUkaiuoTPBmg vBD7Wi8zlYQs5cfhn3a73ijrtoX1jCyeeGvkMjkJs7fCil+odQ0LiIpzLGnLGGXp2tZ1/IeoW 41DQ5RURSX4CM9sdyShDPKy9jIFv/p+WfUY5kIbv+6kr+0Cx0uAdQBSFCzgF+lGb3oH8V9KS1 Ylf2Wh4czCs/C0dmE66iUBE/6pKGV1QLfkEnaNv89ludEJYz5JYCAhkXrfY4nOMStHSNqZ0Fb UTFU8c3Ksb0yjHmxZ5AVSAeiqaYVePONP8YGu+7cG/SjMKF6SBhKESV1kISP7Rsg/U4/f3ZgX Xyi5sosIZpEQGMe84TSj2hwFjJq9IaFNimPdgXh9Z+J4njCfz+BLxt09kEoibKks/p7zu/6CW NkA7FQxu5RD+1egcDsuBT2GxXgJ9sJfpacWawKOKZM8OyHyk0Fz6ghLJWak9lLlMj2Z/J9JCg s4eYGUZ3RdTE4/0H87un1CcppEn/vVGeOVl7CiY2lTj/IooazQDJAVENaGnTMC7cqBYw1Uu1E Hlg72r78lUVr9dPJMEbVJhkEt5YmidURt9Vmqj8FTuUxUkpAy2aHXKK7yu/NzH51kzlHQykeO LIkkoIgyYGHwwzwkUDydETs9AzkeaLJJ8TmxLFfw+54rFFAbBnD2INO1U9zr6FYBdA627Myby McpNds+WYZqhpBb1b6Z+r87tl3Yw/Rnh0E2ukGF6gCcYaTIlie6GP02+fCfuMqe1kZe0WQzMJ n3mT1KB+2il8xc73+tgzkpBY4aYqKXlvqrcsVGS1Ti8D2j97UQUMjRhE6YJk1JK1njjJck5E+ JWsTepfE+Ydd0OIFXG6t/Y+DwOP5ZLhU= Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org To avoid setting it up even if the hardware is not actually connected to anything physically. Besides, the bindings explicitly notes that port definitions are "optional if they are not connected to anything at the hardware level". Signed-off-by: Alexander Riesen --- drivers/media/i2c/adv748x/adv748x-dai.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/media/i2c/adv748x/adv748x-dai.c b/drivers/media/i2c/adv748x/adv748x-dai.c index 1c673efd4745..f22566094568 100644 --- a/drivers/media/i2c/adv748x/adv748x-dai.c +++ b/drivers/media/i2c/adv748x/adv748x-dai.c @@ -216,6 +216,11 @@ int adv748x_dai_init(struct adv748x_dai *dai) int ret; struct adv748x_state *state = adv748x_dai_to_state(dai); + if (!state->endpoints[ADV748X_PORT_I2S]) { + adv_info(state, "no I2S port, DAI disabled\n"); + ret = 0; + goto fail; + } dai->mclk_name = kasprintf(GFP_KERNEL, "%s.%s-i2s-mclk", state->dev->driver->name, dev_name(state->dev));