From patchwork Mon Mar 10 13:12:20 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 14009987 X-Patchwork-Delegate: geert@linux-m68k.org Received: from baptiste.telenet-ops.be (baptiste.telenet-ops.be [195.130.132.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DBB9227E90 for ; Mon, 10 Mar 2025 13:12:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.130.132.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741612355; cv=none; b=HGxt2qXSNZM0XMVA1N6iWhffEyEGSXpUoLjqJEWFcZtaNhZakh0xsNyhPJWLD9scxT0g5bQDJ4t84L+zhY/EvW0O9ipvgavwB0uVrs2t71Npwk40JYwmvB1j4JkksW2CN4d7g/oGavliXZfIKCGdg/FJ7GG+sL0Yv3dZFMKuInw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741612355; c=relaxed/simple; bh=nAvuHzzzD1vjk4IVAEMk2VVjvLtAEdLA21AfJteG4g0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=LsBWgySQ9DnMAdnIov2AJsgtnKxE8+kYeKHCOyvIM0TeC6CMqjDUzxjAxyYU/QSDRMDmcGlUwqoLtZztrd2VZu6jHgFhmh1oEenqItPmgNEiEmLxE1a4e+ujy18V3HZNch8lNc0iVRQi6+Hl3SpLf6ZiF6upTI4wQdVXa2pjzY0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=glider.be; spf=none smtp.mailfrom=linux-m68k.org; arc=none smtp.client-ip=195.130.132.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=glider.be Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux-m68k.org Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed80:777d:24a3:a680:631e]) by baptiste.telenet-ops.be with cmsmtp id P1CP2E0064XipzN011CPiH; Mon, 10 Mar 2025 14:12:25 +0100 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.97) (envelope-from ) id 1trcvI-0000000DSFS-1IAc; Mon, 10 Mar 2025 14:12:23 +0100 Received: from geert by rox.of.borg with local (Exim 4.97) (envelope-from ) id 1trcve-0000000HCUx-3PbE; Mon, 10 Mar 2025 14:12:22 +0100 From: Geert Uytterhoeven To: Magnus Damm , Russell King , Nicolas Pitre , Simon Horman , Kees Cook Cc: linux-renesas-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH] ARM: shmobile: smp: Enforce shmobile_smp_* alignment Date: Mon, 10 Mar 2025 14:12:20 +0100 Message-ID: X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-renesas-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 When the addresses of the shmobile_smp_mpidr, shmobile_smp_fn, and shmobile_smp_arg variables are not multiples of 4 bytes, secondary CPU bring-up fails: smp: Bringing up secondary CPUs ... CPU1: failed to come online CPU2: failed to come online CPU3: failed to come online smp: Brought up 1 node, 1 CPU Fix this by adding the missing alignment directive. Fixes: 4e960f52fce16a3b ("ARM: shmobile: Move shmobile_smp_{mpidr, fn, arg}[] from .text to .bss") Closes: https://lore.kernel.org/r/CAMuHMdU=QR-JLgEHKWpsr6SbaZRc-Hz9r91JfpP8c3n2G-OjqA@mail.gmail.com Signed-off-by: Geert Uytterhoeven Tested-by: Lad Prabhakar --- To be queued in renesas-fixes-for-v6.14. --- arch/arm/mach-shmobile/headsmp.S | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-shmobile/headsmp.S b/arch/arm/mach-shmobile/headsmp.S index a956b489b6ea12ca..2bc7e73a8582d2b3 100644 --- a/arch/arm/mach-shmobile/headsmp.S +++ b/arch/arm/mach-shmobile/headsmp.S @@ -136,6 +136,7 @@ ENDPROC(shmobile_smp_sleep) .long shmobile_smp_arg - 1b .bss + .align 2 .globl shmobile_smp_mpidr shmobile_smp_mpidr: .space NR_CPUS * 4