diff mbox series

[PATCH/LOCAL] arm64: renesas: defconfig: Disable CONFIG_PROVE_LOCKING

Message ID c8439b6b731cd44c0d2442f437d4ceef336125b0.1737390987.git.geert+renesas@glider.be (mailing list archive)
State Mainlined
Commit 95b6babc16ef42bad035e90a64403220cff09850
Delegated to: Geert Uytterhoeven
Headers show
Series [PATCH/LOCAL] arm64: renesas: defconfig: Disable CONFIG_PROVE_LOCKING | expand

Commit Message

Geert Uytterhoeven Jan. 20, 2025, 4:37 p.m. UTC
Proving that all locking that occurs in the kernel runtime is
mathematically correct has an impact on performance.  Hence it is
disabled in most defconfigs.

Suggested-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Not intended for upstream merge.
To be applied to the topic/renesas-defconfig branch.
---
 arch/arm64/configs/renesas_defconfig | 1 -
 1 file changed, 1 deletion(-)

Comments

Paul Barker Jan. 24, 2025, 9:12 a.m. UTC | #1
On 20/01/2025 16:37, Geert Uytterhoeven wrote:
> Proving that all locking that occurs in the kernel runtime is
> mathematically correct has an impact on performance.  Hence it is
> disabled in most defconfigs.
> 
> Suggested-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Not intended for upstream merge.
> To be applied to the topic/renesas-defconfig branch.
> ---
>  arch/arm64/configs/renesas_defconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm64/configs/renesas_defconfig b/arch/arm64/configs/renesas_defconfig
> index 30a865507d6e5ad4..a3a324ae9e3867ad 100644
> --- a/arch/arm64/configs/renesas_defconfig
> +++ b/arch/arm64/configs/renesas_defconfig
> @@ -455,5 +472,4 @@ CONFIG_DEBUG_KERNEL=y
>  CONFIG_MAGIC_SYSRQ=y
>  CONFIG_DEBUG_FS=y
>  # CONFIG_SCHED_DEBUG is not set
> -CONFIG_PROVE_LOCKING=y
>  # CONFIG_FTRACE is not set

Good timing on this patch! We've also been discussing this recently due
to the performance impact and we plan to make the same change to the
configs in the cip-kernel-config repo. I'll propose the change there
once this has landed on your topic branch.

Reviewed-by: Paul Barker <paul.barker.ct@bp.renesas.com>
Biju Das Jan. 24, 2025, 9:24 a.m. UTC | #2
Hi Geert,

> -----Original Message-----
> From: Geert Uytterhoeven <geert+renesas@glider.be>
> Sent: 20 January 2025 16:38
> Subject: [PATCH/LOCAL] arm64: renesas: defconfig: Disable CONFIG_PROVE_LOCKING
> 
> Proving that all locking that occurs in the kernel runtime is mathematically correct has an impact on
> performance.  Hence it is disabled in most defconfigs.
> 
> Suggested-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Not intended for upstream merge.
> To be applied to the topic/renesas-defconfig branch.
> ---
>  arch/arm64/configs/renesas_defconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm64/configs/renesas_defconfig b/arch/arm64/configs/renesas_defconfig
> index 30a865507d6e5ad4..a3a324ae9e3867ad 100644
> --- a/arch/arm64/configs/renesas_defconfig
> +++ b/arch/arm64/configs/renesas_defconfig
> @@ -455,5 +472,4 @@ CONFIG_DEBUG_KERNEL=y  CONFIG_MAGIC_SYSRQ=y  CONFIG_DEBUG_FS=y  #
> CONFIG_SCHED_DEBUG is not set -CONFIG_PROVE_LOCKING=y  # CONFIG_FTRACE is not set


This config used to catch lot of bugs during development. Now we need to apply
It manually. But on the positive side, CIP uses renesas_defconfig for testing
and that will have performance improvement with this change.

So,

Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>

Cheers,
Biju
diff mbox series

Patch

diff --git a/arch/arm64/configs/renesas_defconfig b/arch/arm64/configs/renesas_defconfig
index 30a865507d6e5ad4..a3a324ae9e3867ad 100644
--- a/arch/arm64/configs/renesas_defconfig
+++ b/arch/arm64/configs/renesas_defconfig
@@ -455,5 +472,4 @@  CONFIG_DEBUG_KERNEL=y
 CONFIG_MAGIC_SYSRQ=y
 CONFIG_DEBUG_FS=y
 # CONFIG_SCHED_DEBUG is not set
-CONFIG_PROVE_LOCKING=y
 # CONFIG_FTRACE is not set