From patchwork Thu Jul 27 21:26:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Charlie Jenkins X-Patchwork-Id: 13330791 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1004CC04A94 for ; Thu, 27 Jul 2023 21:27:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=PGSSeUbo+Cz7hDufhgNkyrQmItXMYS/Ro/Ixj5nXj3A=; b=uf5+zW0/DNnOst cDXjuiV8j92ELA62b/sIWGeHwy1HM/Mk1i9yDYMEDGJ2z9hsLlpP2B4cqzP1UcEF28dkDAsFiBi4I 8ludrB4u6m1PY9Y8gYB1vRefYdhNro/uT9hDu6BBMN8EQDCxSwiDRbDc+MUo2/8soA/aEQp/bwa/s o1rbxfMlPzpNjIdbM19FiIl1dwmKIxbLyRru78uMA10ZyC78bP5ZytaHYJseVX/9qxHs6pKk+0G5r aZRX8v4nxjdj36aU8SwgywToXTMcsVuUH4zXgBa5cC0RljNiHs8GxN3pHhJl7rmF3gToYkuWKJ0Ma 5og9iY+lEq2ZJTGC0v7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qP8Vf-000c0k-0n; Thu, 27 Jul 2023 21:26:59 +0000 Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qP8Vc-000bxB-17 for linux-riscv@lists.infradead.org; Thu, 27 Jul 2023 21:26:58 +0000 Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-686f38692b3so1100508b3a.2 for ; Thu, 27 Jul 2023 14:26:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20221208.gappssmtp.com; s=20221208; t=1690493211; x=1691098011; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=u1j+kMh0iOsH0JqfJ3WA4QtOF313IMeXkg3gc/f9dpg=; b=UW/Zl61NXORbuErLMYKrPm9BFy7QuUh39/eAy5ZU0tDpiY0EdHKcfvtC+GjtpmoDS8 UmDlC5OLbd58dgYVEmXHluzRe1t2fY8rL1HiaDUFiSJTNyiVKx7Yj/LsR1iXdWF2JcNt tnIjNEFLAtyVNtQnc5o/YyMDw8iqDLdEFxqRSU0Vz15wWVg7u5g7H6whC3n/cJHzTAky FzfPpDUZfB16CXzC3uQVY4b74zmqkbLxl/LvpVr/5df/t64hI95eiPpq/tX3SGZn8pXV wROKldHqphBhUMtg69MS22I/iovR/Qy3rcvDDNxH4lNhhgWxzukwhDjXh3ehAlzbnPa8 7Cyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690493211; x=1691098011; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=u1j+kMh0iOsH0JqfJ3WA4QtOF313IMeXkg3gc/f9dpg=; b=XjOG9fXYt6+cDGUanuivBxs/hNHBLt57snXwnGDh8LD8qVvwPmPYp39oDxHFzna/cQ ruaxuY7MDi5qBVtXKASP+2Vfy34QKw3+UUFcZkxRiqCVBXpfcdOPNwIkdu7RiL5aOg3A cRYoUmkUDdNxD8Zsy2g4wRGafHANYyQ8Cdmfh9VX+P4S/Pr9YLhjhPbcmYlu1TozU5xl 1RLSIluSP1WYxH5+PsiFWP6w+RLkYQEcEAJ/W++pgVU/bYP/CCbeC924URPlFcLmJZae bcNJU9NGYIRwdVGjsr/QlQCobLacqpKW8kmSWBwTShJCiXaN+efbzcd4zSk19EouNlQk 0m4A== X-Gm-Message-State: ABy/qLbiH1iPF0uYDVFjdiOhlzBqL5tWHceVVUeyexcGHx/OFB0OxHmv JrmU6BjgXt/Cbun0yrNTv6spp8OgNOiM9o8oo3M= X-Google-Smtp-Source: APBJJlHqQrVV0xCK9fwk96H8JBXhaJwlU8jA71nZ4nPqPKjFylYfA9+6fmKC0mo2E6CfNC7prqLhUw== X-Received: by 2002:a05:6a20:2c98:b0:13b:ceea:6b50 with SMTP id g24-20020a056a202c9800b0013bceea6b50mr262249pzj.47.1690493211124; Thu, 27 Jul 2023 14:26:51 -0700 (PDT) Received: from charlie.ba.rivosinc.com ([66.220.2.162]) by smtp.gmail.com with ESMTPSA id c5-20020aa78c05000000b00682562b1549sm1912312pfd.24.2023.07.27.14.26.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jul 2023 14:26:50 -0700 (PDT) From: Charlie Jenkins To: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Cc: charlie@rivosinc.com, conor@kernel.org, paul.walmsley@sifive.com, palmer@rivosinc.com, aou@eecs.berkeley.edu, anup@brainfault.org, konstantin@linuxfoundation.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, mick@ics.forth.gr, jrtc27@jrtc27.com, rdunlap@infradead.org, alexghiti@rivosinc.com Subject: [PATCH v8 0/4] RISC-V: mm: Make SV48 the default address space Date: Thu, 27 Jul 2023 14:26:25 -0700 Message-ID: <20230727212647.4182407-1-charlie@rivosinc.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230727_142656_385501_39F60562 X-CRM114-Status: GOOD ( 12.82 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Make sv48 the default address space for mmap as some applications currently depend on this assumption. Users can now select a desired address space using a non-zero hint address to mmap. Previously, requesting the default address space from mmap by passing zero as the hint address would result in using the largest address space possible. Some applications depend on empty bits in the virtual address space, like Go and Java, so this patch provides more flexibility for application developers. -Charlie --- v8: - Fix RV32 and the RV32 compat mode of RV64 - Extract out addr and base from the mmap macros v7: - Changing RLIMIT_STACK inside of an executing program does not trigger arch_pick_mmap_layout(), so rewrite tests to change RLIMIT_STACK from a script before executing tests. RLIMIT_STACK of infinity forces bottomup mmap allocation. - Make arch_get_mmap_base macro more readible by extracting out the rnd calculation. - Use MMAP_MIN_VA_BITS in TASK_UNMAPPED_BASE to support case when mmap attempts to allocate address smaller than DEFAULT_MAP_WINDOW. - Fix incorrect wording in documentation. v6: - Rebase onto the correct base v5: - Minor wording change in documentation - Change some parenthesis in arch_get_mmap_ macros - Added case for addr==0 in arch_get_mmap_ because without this, programs would crash if RLIMIT_STACK was modified before executing the program. This was tested using the libhugetlbfs tests. v4: - Split testcases/document patch into test cases, in-code documentation, and formal documentation patches - Modified the mmap_base macro to be more legible and better represent memory layout - Fixed documentation to better reflect the implmentation - Renamed DEFAULT_VA_BITS to MMAP_VA_BITS - Added additional test case for rlimit changes --- Charlie Jenkins (4): RISC-V: mm: Restrict address space for sv39,sv48,sv57 RISC-V: mm: Add tests for RISC-V mm RISC-V: mm: Update pgtable comment documentation RISC-V: mm: Document mmap changes Documentation/riscv/vm-layout.rst | 22 +++++++ arch/riscv/include/asm/elf.h | 2 +- arch/riscv/include/asm/pgtable.h | 28 ++++++-- arch/riscv/include/asm/processor.h | 52 +++++++++++++-- tools/testing/selftests/riscv/Makefile | 2 +- tools/testing/selftests/riscv/mm/.gitignore | 2 + tools/testing/selftests/riscv/mm/Makefile | 15 +++++ .../riscv/mm/testcases/mmap_bottomup.c | 35 ++++++++++ .../riscv/mm/testcases/mmap_default.c | 35 ++++++++++ .../selftests/riscv/mm/testcases/mmap_test.h | 64 +++++++++++++++++++ .../selftests/riscv/mm/testcases/run_mmap.sh | 12 ++++ 11 files changed, 257 insertions(+), 12 deletions(-) create mode 100644 tools/testing/selftests/riscv/mm/.gitignore create mode 100644 tools/testing/selftests/riscv/mm/Makefile create mode 100644 tools/testing/selftests/riscv/mm/testcases/mmap_bottomup.c create mode 100644 tools/testing/selftests/riscv/mm/testcases/mmap_default.c create mode 100644 tools/testing/selftests/riscv/mm/testcases/mmap_test.h create mode 100755 tools/testing/selftests/riscv/mm/testcases/run_mmap.sh