From patchwork Thu Apr 3 11:25:19 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?UmFkaW0gS3LEjW3DocWZ?= X-Patchwork-Id: 14037360 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 496A0C3600C for ; Thu, 3 Apr 2025 11:37:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=mxlSxBhEplId9IVJpqBwcPVQH0C54EV1SLfCM+odPbM=; b=Zj5ROvkXztZ+AT Ea1jACWJS5NLMpeGopO4w3cOMQ1tEdcNuRmy1mK/aKM7PZ3PSKGh6mGpqvbjzb0GrM9hu5Jahi36B bv6oMhJ69m1fc9bkhYF09d/FZVJW70kAolZ7tdoZ3hLxnF1tJ3W0NZH7fkZdYIF2aWCGxG3M9OlsR z4/Vd2bt0ZS6jRwW0MPfk5kgiZ9i/kyEt5DsoFtKAIKMqtTkY/sRT5FEFM7eI8Q8TB1+A15HZhirB x4ICnkPo1TvDmANNodSFe/oAse+9IvwVVC6y6GHAVmsvrdKhqnXrxaV+/AMqJezFAZ+7reLN+qVcp P2c1s1axiMZWVVCHk0qg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1u0ItB-00000008jRO-134b; Thu, 03 Apr 2025 11:37:41 +0000 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1u0Int-00000008iRK-28OV for linux-riscv@lists.infradead.org; Thu, 03 Apr 2025 11:32:14 +0000 Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-3912ebb8e88so115088f8f.0 for ; Thu, 03 Apr 2025 04:32:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1743679931; x=1744284731; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=uzJLKlljfvfxPvPUZeysuKSPBVSnoaOxnTXwCnBbatE=; b=PrvxqRkQQnmzTOBKSVH2V+ljWYx10W08diu/1F0Iywp8fQF4c7ImAzZDTfiyrD8l5u yHadJlE7/8vY/rgeITGlH2/mmXqDTaI4BJdVCRhup87zY4K7EPNofvlDYYuysLoL5d8m iR+w/i2rtIr039iknonV1WNYDGz7LpHiPSbX7AimUCFHqgJER2pYbA8YuUtP8//yvtBt YP3Zhk3Go2Y6LmZl2zQ3UGCBJALSNfGFXiAoZd0L9M9xMI6AJqEI+xAk+1UtFrDS6mpb VRA/5Cni3R12br7iTCJWqmrbffleKR2jURzDR+f8QkiretTfhJJvlPSxljO9qkzV93eJ AE1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743679931; x=1744284731; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uzJLKlljfvfxPvPUZeysuKSPBVSnoaOxnTXwCnBbatE=; b=Uag2mPwLWoMcKY8X6ZDbyz8eqmxGy+Tx5gtcEjjrCIAONHc8H0tAmNgghjzEr0HGQk IgL/hMrNZatti6v9pGZYFXwdPJtZdIdMd9VKeFqh7RxNWEFw+qieGDB3PyA4m1xwWaK7 h3dvDTo42Dys8Do3lwfie/1wuYz4G61eH8cs+3DLYHtbXfPGriV6ypNrv8fy+rM7uTdk nWt1brXtwHe8Fi70n23sqYPEAcjBVL69ArEZbZXdA77cIur1p5QflKK5zzceBJjaxuQe YVHH+VQq8zZmakho6Mv18qOE1dTh6g7zxf12Llg8fwqD0z/7vwsykxZffVuXyWaoExI/ mKCA== X-Forwarded-Encrypted: i=1; AJvYcCUYXCqPxdL3uwLJZLZxkbPEtpUKTe/B+h92cobVlhQfEKmbB5Yo7rjD8dknaLU6C+pLSLPmiPjfoZAo/A==@lists.infradead.org X-Gm-Message-State: AOJu0YxQcBWzJDWbPNxFVH6RnupAXT3jSq/EeUoeTSjABNBsPvntWmp7 wqBkbN+ZKUKh7WJMXC+Qmjtv+kfzHyA00zaFC6tiKNtxU+OzoxOoA8nW8VEpyTs= X-Gm-Gg: ASbGncug5njeSu/vK83xXjsz2VK/Z+QPfOslI1qEentmF2IDFa0ZtQM/xhUoBDjXut4 DsnWOhqZOdFWtlAih5+WAnglhTrIYNL7y8jmhChou7XjkFI4WKA7+YOb4CAsbbrzorTMqAw6E6S VBcW2DCAPFymS1J1y0AMC+DAYvDNK16izpsPy2OOpSOQBYIhb2z3meIhndGk/Nx+r7YiMg+z2Zq hBwFfeQkk4CyqFMMjxOnGe4ETRyCaYdbRA9AmWE+DXoDPccx/yKFsuwRs/JywmNzws2lNdLZq8Y PXRwYxW+KhDDoKz74+JRdLZS54qC6xm8m9LgdcfqEC42DVUC+rBGVB5QKS+ZvCfSDQc5EWlcXkw 56g== X-Google-Smtp-Source: AGHT+IH6xifwXMVfMLClIlm2BzAh7GveRJDcwc65VzrAXzSC6fsdF3OjurjTLfO2TtkYTUXlVLDtBQ== X-Received: by 2002:a5d:64e9:0:b0:391:2a9a:47a6 with SMTP id ffacd0b85a97d-39c120db3demr6114098f8f.4.1743679931180; Thu, 03 Apr 2025 04:32:11 -0700 (PDT) Received: from localhost (cst2-173-141.cust.vodafone.cz. [31.30.173.141]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ec3669d0fsm15884455e9.36.2025.04.03.04.32.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Apr 2025 04:32:10 -0700 (PDT) From: =?utf-8?b?UmFkaW0gS3LEjW3DocWZ?= To: kvm-riscv@lists.infradead.org Cc: kvm@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Anup Patel , Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Andrew Jones , Mayuresh Chitale Subject: [PATCH 0/5] KVM: RISC-V: VCPU reset fixes Date: Thu, 3 Apr 2025 13:25:19 +0200 Message-ID: <20250403112522.1566629-3-rkrcmar@ventanamicro.com> X-Mailer: git-send-email 2.48.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250403_043213_551023_D425D180 X-CRM114-Status: GOOD ( 14.22 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Hello, this series started with a simple fix [5/5], which sadly didn't fix enough without [4/5]. [1-3/5] are refactors to make the reset a bit easier to follow. ([1-3,5/5] are applicable without [4/5].) [4/5] changes the userspace ABI and I'd like to gather your opinions on how the ABI is supposed to work. As another proposal, what do you think about an IOCTL that allows userspace to invoke any KVM SBI ecall? Userspace could call the KVM HSM implementation to reset and start a VCPU, but I think that kvm_mp_state is an SBI HSM interface, so we have an obscure IOCTL for it already. I was also thinking about using KVM_MP_STATE_UNINITIALIZED to distinguish that KVM should reset the state when becoming runnable. I recommend to start with the following hunk in [4/5], as it's the only significant part of this series: @@ -520,6 +525,10 @@ int kvm_arch_vcpu_ioctl_set_mpstate(struct kvm_vcpu *vcpu, switch (mp_state->mp_state) { case KVM_MP_STATE_RUNNABLE: + if (riscv_vcpu_supports_sbi_ext(vcpu, KVM_RISCV_SBI_EXT_HSM) && + vcpu->arch.ran_atleast_once && + kvm_riscv_vcpu_stopped(vcpu)) + kvm_riscv_vcpu_sbi_request_reset_from_userspace(vcpu); Thanks. Radim Krčmář (5): KVM: RISC-V: refactor vector state reset KVM: RISC-V: refactor sbi reset request KVM: RISC-V: remove unnecessary SBI reset state KVM: RISC-V: reset VCPU state when becoming runnable KVM: RISC-V: reset smstateen CSRs arch/riscv/include/asm/kvm_aia.h | 3 -- arch/riscv/include/asm/kvm_host.h | 13 +++-- arch/riscv/include/asm/kvm_vcpu_sbi.h | 5 ++ arch/riscv/include/asm/kvm_vcpu_vector.h | 6 +-- arch/riscv/kvm/aia_device.c | 4 +- arch/riscv/kvm/vcpu.c | 69 +++++++++++++++--------- arch/riscv/kvm/vcpu_sbi.c | 28 ++++++++++ arch/riscv/kvm/vcpu_sbi_hsm.c | 13 +---- arch/riscv/kvm/vcpu_sbi_system.c | 10 +--- arch/riscv/kvm/vcpu_vector.c | 13 ++--- 10 files changed, 97 insertions(+), 67 deletions(-)