From patchwork Wed Apr 22 02:57:12 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Guru Das Srinagesh X-Patchwork-Id: 11502767 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6E78E139F for ; Wed, 22 Apr 2020 02:57:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4C921206D5 for ; Wed, 22 Apr 2020 02:57:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IF2GrVmB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4C921206D5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+patchwork-linux-riscv=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:Message-Id:Date:Subject: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=PbxotYZiNCXyAKJzyrNZae2t98+bnH977L1tj/7XKQQ=; b=IF2GrVmBYqSONQ 4Rd1N23kUynATeMWU5WI9l1Kcouuen4BdbKrox7e+jzuZHrs/fXtO3Vepg16kw3kUdExHMHmCuyua 3CFmKCXJAZO80PLMI3YPrJv109+i8NFM157KkeKuEr7iY6HI+38tsJsRcCq01iKru48fAuvx42kJO 7uC78AW9Ur6tJyC5/B9StLAhrJPF5ffzpxBc20zHLEV3lwu+5gwPkS6qf4HrWWRWvjSu+Q7f7ExXB ZmmPJYCHF+QDx7UE59QfYdTyu95yhGD0uK16HeAT3lUES8YfHUtYBFDTdPz6yKM9CRf6tOutFz3ct Jn9WZjSB2F/Pq/JW4aFQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jR5Zt-00084t-WD; Wed, 22 Apr 2020 02:57:34 +0000 Received: from alexa-out-sd-01.qualcomm.com ([199.106.114.38]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jR5Zp-00082R-BE for linux-riscv@lists.infradead.org; Wed, 22 Apr 2020 02:57:31 +0000 Received: from unknown (HELO ironmsg03-sd.qualcomm.com) ([10.53.140.143]) by alexa-out-sd-01.qualcomm.com with ESMTP; 21 Apr 2020 19:57:28 -0700 Received: from gurus-linux.qualcomm.com ([10.46.162.81]) by ironmsg03-sd.qualcomm.com with ESMTP; 21 Apr 2020 19:57:26 -0700 Received: by gurus-linux.qualcomm.com (Postfix, from userid 383780) id 8A1B94CB2; Tue, 21 Apr 2020 19:57:26 -0700 (PDT) From: Guru Das Srinagesh To: linux-pwm@vger.kernel.org Subject: [PATCH v13 00/11] Convert PWM period and duty cycle to u64 Date: Tue, 21 Apr 2020 19:57:12 -0700 Message-Id: X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200421_195729_963146_D874F94C X-CRM114-Status: GOOD ( 20.73 ) X-Spam-Score: -2.0 (--) X-Spam-Report: SpamAssassin version 3.4.4 on bombadil.infradead.org summary: Content analysis details: (-2.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [199.106.114.38 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kate Stewart , linux-fbdev@vger.kernel.org, David Collins , Liam Girdwood , David Airlie , Michael Turquette , Joonas Lahtinen , Kamil Debski , dri-devel@lists.freedesktop.org, Chris Wilson , Atish Patra , Thierry Reding , linux-riscv@lists.infradead.org, Fabio Estevam , linux-clk@vger.kernel.org, =?utf-8?b?VmlsbGUgU3lyasOkbMOk?= , Guru Das Srinagesh , Daniel Thompson , Mauro Carvalho Chehab , Alexander Shiyan , Lee Jones , Chen-Yu Tsai , NXP Linux Team , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Philipp Zabel , Sascha Hauer , Guenter Roeck , linux-media@vger.kernel.org, Jean Delvare , Alexandre Torgue , Arnd Bergmann , Bartlomiej Zolnierkiewicz , intel-gfx@lists.freedesktop.org, Maxime Ripard , Mark Brown , Paul Walmsley , Subbaraman Narayanamurthy , Thomas Gleixner , Fabrice Gasnier , Pengutronix Kernel Team , Allison Randal , linux-hwmon@vger.kernel.org, Maxime Coquelin , Richard Fontana , Stephen Boyd , Jingoo Han , linux-kernel@vger.kernel.org, Yash Shah , Palmer Dabbelt , Dan Carpenter , Daniel Vetter , Joe Perches , Shawn Guo Sender: "linux-riscv" Errors-To: linux-riscv-bounces+patchwork-linux-riscv=patchwork.kernel.org@lists.infradead.org [REQUEST] Would it be possible for the patches that have already received Acked-by's in this series to be accepted and applied to the tree? I lost an Acked-by (in intel-panel.c) because it had a merge conflict with a new change that came in after I rebased to tip. I wasn't sure earlier about accepting single patches as opposed to the entire series en masse, but this event has got me thinking. [COVER LETTER] Because period and duty cycle are defined in the PWM framework structs as ints with units of nanoseconds, the maximum time duration that can be set is limited to ~2.147 seconds. Consequently, applications desiring to set greater time periods via the PWM framework are not be able to do so - like, for instance, causing an LED to blink at an interval of 5 seconds. Redefining the period and duty cycle struct members in the core PWM framework structs as u64 values will enable larger time durations to be set and solve this problem. Such a change to the framework mandates that drivers using these struct members (and corresponding helper functions) also be modified correctly in order to prevent compilation errors. This patch series introduces the changes to all the drivers first, followed by the framework change at the very end so that when the latter is applied, all the drivers are in good shape and there are no compilation errors. Changes from v12: - Rebased to tip of for-next - Collected Acked-by for sun4i - Reworked patch for intel-panel.c due to rebase, dropped Jani's Acked-by as a result Changes from v11: - Rebased to tip of for-next. - Collected "Acked-by:" for v7 (unchanged) of pwm: sifive: [4] - Squished stm32-lp.c change with final patch in series - sun4i: Used nsecs_to_jiffies() - imx27: Added overflow handling logic - clps711x: Corrected the if condition for skipping the division - clk: pwm: Reverted to v8 version, added check to prevent division-by-zero Changes from v10: - Carefully added back all the "Reviewed-by: " and "Acked-by: " tags received so far that had gotten missed in v9. No other changes. Changes from v9: - Gathered the received "Reviewed-by: " tag - Added back the clk-pwm.c patch because kbuild test robot complained [3] and addressed received review comments. - clps711x: Addressed review comments. Changes from v8: - Gathered all received "Acked-by: " and "Reviewed-by: " tags - Dropped patch to clk-pwm.c for reasons mentiond in [2] - Expanded audience of unreviewed patches Changes from v7: - Changed commit messages of all patches to be brief and to the point. - Added explanation of change in cover letter. - Dropped change to pwm-sti.c as upon review it was unnecessary as struct pwm_capture is not being modified in the PWM core. Changes from v6: - Split out the driver changes out into separate patches, one patch per file for ease of reviewing. Changes from v5: - Dropped the conversion of struct pwm_capture to u64 for reasons mentioned in https://www.spinics.net/lists/linux-pwm/msg11541.html Changes from v4: - Split the patch into two: one for changes to the drivers, and the actual switch to u64 for ease of reverting should the need arise. - Re-examined the patch and made the following corrections: * intel_panel.c: DIV64_U64_ROUND_UP -> DIV_ROUND_UP_ULL (as only the numerator would be 64-bit in this case). * pwm-sti.c: do_div -> div_u64 (do_div is optimized only for x86 architectures, and div_u64's comment block suggests to use this as much as possible). Changes from v3: - Rebased to current tip of for-next. Changes from v2: - Fixed %u -> %llu in a dev_dbg in pwm-stm32-lp.c, thanks to kbuild test robot - Added a couple of fixes to pwm-imx-tpm.c and pwm-sifive.c Changes from v1: - Fixed compilation errors seen when compiling for different archs. v1: - Reworked the change pushed upstream earlier [1] so as to not add an extension to an obsolete API. With this change, pwm_ops->apply() can be used to set pwm_state parameters as usual. [1] https://lore.kernel.org/lkml/20190916140048.GB7488@ulmo/ [2] https://lore.kernel.org/lkml/20200312190859.GA19605@codeaurora.org/ [3] https://www.spinics.net/lists/linux-pwm/msg11906.html [4] https://www.spinics.net/lists/linux-pwm/msg11986.html To: Arnd Bergmann To: David Laight To: Jani Nikula Cc: Alexander Shiyan Cc: Alexandre Torgue Cc: Allison Randal Cc: Arnd Bergmann Cc: Atish Patra Cc: Bartlomiej Zolnierkiewicz Cc: Chen-Yu Tsai Cc: Chris Wilson Cc: Dan Carpenter Cc: Daniel Thompson Cc: Daniel Vetter Cc: David Airlie Cc: David Collins Cc: dri-devel@lists.freedesktop.org Cc: Fabio Estevam Cc: Fabrice Gasnier Cc: Guenter Roeck Cc: intel-gfx@lists.freedesktop.org Cc: Jean Delvare Cc: Jingoo Han Cc: Joe Perches Cc: Joonas Lahtinen Cc: Kamil Debski Cc: Kate Stewart Cc: Lee Jones Cc: Liam Girdwood Cc: linux-clk@vger.kernel.org Cc: linux-fbdev@vger.kernel.org Cc: linux-hwmon@vger.kernel.org Cc: linux-media@vger.kernel.org Cc: linux-pwm@vger.kernel.org Cc: linux-riscv@lists.infradead.org Cc: Mark Brown Cc: Mauro Carvalho Chehab Cc: Maxime Coquelin Cc: Maxime Ripard Cc: Michael Turquette Cc: NXP Linux Team Cc: Palmer Dabbelt Cc: Paul Walmsley Cc: Pengutronix Kernel Team Cc: Philipp Zabel Cc: Richard Fontana Cc: Sascha Hauer Cc: Shawn Guo Cc: Stephen Boyd Cc: Thomas Gleixner Cc: "Ville Syrjälä" Cc: Yash Shah Guru Das Srinagesh (11): drm/i915: Use 64-bit division macro hwmon: pwm-fan: Use 64-bit division macro ir-rx51: Use 64-bit division macro pwm: clps711x: Cast period to u32 before use as divisor pwm: pwm-imx-tpm: Use 64-bit division macro pwm: imx27: Use 64-bit division macro and function pwm: sifive: Use 64-bit division macro pwm: sun4i: Use nsecs_to_jiffies to avoid a division backlight: pwm_bl: Use 64-bit division function clk: pwm: Use 64-bit division function pwm: core: Convert period and duty cycle to u64 drivers/clk/clk-pwm.c | 7 +++- drivers/gpu/drm/i915/display/intel_panel.c | 2 +- drivers/hwmon/pwm-fan.c | 2 +- drivers/media/rc/ir-rx51.c | 3 +- drivers/pwm/core.c | 14 ++++---- drivers/pwm/pwm-clps711x.c | 5 ++- drivers/pwm/pwm-imx-tpm.c | 2 +- drivers/pwm/pwm-imx27.c | 53 +++++++++++++++++++++++++----- drivers/pwm/pwm-sifive.c | 2 +- drivers/pwm/pwm-stm32-lp.c | 2 +- drivers/pwm/pwm-sun4i.c | 2 +- drivers/pwm/sysfs.c | 8 ++--- drivers/video/backlight/pwm_bl.c | 3 +- include/linux/pwm.h | 12 +++---- 14 files changed, 82 insertions(+), 35 deletions(-) Acked-by: Lee Jones