From patchwork Tue Jan 8 09:38:34 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Atish Patra X-Patchwork-Id: 10751721 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6D1476C5 for ; Tue, 8 Jan 2019 09:38:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 575EE2625B for ; Tue, 8 Jan 2019 09:38:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4A8F328864; Tue, 8 Jan 2019 09:38:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 059122625B for ; Tue, 8 Jan 2019 09:38:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=iaVQLkgs2QWgkqE3Qtu8mqs865dfS2z9DuCvBdss/gs=; b=Xx6uFDT1BQRRhSFfI+uMNYOJQh qiffvX/cmjr9+cIb/FFIHuhOItZPB8sZ9LiYa0oGY3SkYByccc7eAZv+YtnKJVVcs3ZdmpIvcGcwB TPO837UxYy/gEprfEbaWm8hKYc6VEd53hlXRgM0DuThhG5I/Gd7n3EssTJdSDn3wBGnh+ubPJ6OX/ gs0ViGARVyHHoHm9s0NUXISW3LZSF399PfQ1Oi82U1rVco4GvrVyyD7ihpHdW8bfLwKqknaq0jYzo 7gfJUJWGx77HKexFqkz9BluAPyzAoZ4ig+QU0hojctdE7NXves0QVYasqi42ihGkdp8Xm9NIffAHs gwD2O5Iw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1ggnqb-0003un-29; Tue, 08 Jan 2019 09:38:57 +0000 Received: from esa6.hgst.iphmx.com ([216.71.154.45]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1ggnqT-0003lv-Ak for linux-riscv@lists.infradead.org; Tue, 08 Jan 2019 09:38:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1546940330; x=1578476330; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=c3GlsSU9hpztl0F7FBnfC5nPlii3rUi/viUc2pT+k2g=; b=JDRKqt76G/lqPd5zX/UzTvH8wE7a4teB0xD1e3y8d+Q1mAqdAruQugHe /W8RIafPy9EjX91bcEIGUKslq2ECRPgZjsteidMhSg4d1ovdv0D1J+YG/ SVkOv6zZhTjLlSc/+7CHBynGYHmsKwx9wCKoHYMsnTGtiyFmjRTgF1QsF AqBcm3VyGyy9OvZ2bgVxjuaP5yl/2qEHlPg3kPQUP16g2zdEkN01PuxdY we6PAMoQo4jadbb4n+BCsSnAjn3j9xH+hUOBALMNiadZvKDD3vU4DYbL/ MktkemhHfY99GLGt6iZ7NwZ98uJXP7M50zqwcsbNTXjh5+iLzT4AUHAQL Q==; X-IronPort-AV: E=Sophos;i="5.56,453,1539619200"; d="scan'208";a="100000254" Received: from uls-op-cesaip01.wdc.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 08 Jan 2019 17:38:48 +0800 Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP; 08 Jan 2019 01:18:51 -0800 Received: from jedi-01.sdcorp.global.sandisk.com (HELO jedi-01.int.fusionio.com) ([10.11.143.218]) by uls-op-cesaip02.wdc.com with ESMTP; 08 Jan 2019 01:38:46 -0800 From: Atish Patra To: linux-riscv@lists.infradead.org Subject: [PATCH v2 4/8] RISC-V: Allow hartid-to-cpuid function to fail. Date: Tue, 8 Jan 2019 01:38:34 -0800 Message-Id: <1546940318-9752-5-git-send-email-atish.patra@wdc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1546940318-9752-1-git-send-email-atish.patra@wdc.com> References: <1546940318-9752-1-git-send-email-atish.patra@wdc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190108_013849_482014_025F8A13 X-CRM114-Status: GOOD ( 11.11 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Patrick_St=C3=A4hlin?= , Albert Ou , Jason Cooper , Alan Kao , Dmitriy Cherkasov , Anup Patel , Daniel Lezcano , linux-kernel@vger.kernel.org, Michael Clark , Atish Patra , Palmer Dabbelt , Andreas Schwab , Marc Zyngier , Thomas Gleixner , Zong Li MIME-Version: 1.0 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+patchwork-linux-riscv=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP It is perfectly okay to call riscv_hartid_to_cpuid for a hartid that is not mapped with an CPU id. It can happen if the calling functions retrieves the hartid from DT. However, that hartid was never brought online by the firmware or kernel for any reasons. No need to BUG() in the above case. A negative error return is sufficient and the calling function should check for the return value always. Signed-off-by: Atish Patra Reviewed-by: Anup Patel Reviewed-by: Christoph Hellwig --- arch/riscv/kernel/smp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/riscv/kernel/smp.c b/arch/riscv/kernel/smp.c index e407bd4f..ce9a2e73 100644 --- a/arch/riscv/kernel/smp.c +++ b/arch/riscv/kernel/smp.c @@ -58,7 +58,6 @@ int riscv_hartid_to_cpuid(int hartid) return i; pr_err("Couldn't find cpu id for hartid [%d]\n", hartid); - BUG(); return i; }