From patchwork Fri Feb 8 01:51:18 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Atish Patra X-Patchwork-Id: 10802359 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1FF0013B5 for ; Fri, 8 Feb 2019 01:52:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 10CB92E5D5 for ; Fri, 8 Feb 2019 01:52:05 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 051FE2E5EE; Fri, 8 Feb 2019 01:52:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 7BFC62E5E9 for ; Fri, 8 Feb 2019 01:52:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=AOG8QA4B4+NI0AuMKPbfk5e0ntZdmlYMjI4ElZCqp9E=; b=aZ8aGKuWADSfy89k4kIXUTzX1S R9HRY5sdWMdB0ieZzdsIBkFvTebIeKvYyZTTCG/GpUYpuZsAGnQ/ftov36tF4LBux6y4dfU8cdixy n/AqtIXpPbwupXZGk+5mar1s/RK01eMLZVxz5nS9dZEWk74tRLo8U4E+OCUHqZt4ABDaOotTNoKPu D/dhYksHW1A3p7TpGdx+rg+iyBaREqrdqjxNeCDGBElYO+NNsP8daR/Wd02MtRFPUD/aXJu5ecXrp 0xxdFPNA7tcBtyVOouMvCmbLt+UJ99jdcYwthqVHLsgXqT6O1fqgusOBgltLqQ//Zg9AXWKhvLBgZ TKypEyYQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1grvKj-0002nU-TJ; Fri, 08 Feb 2019 01:52:01 +0000 Received: from esa6.hgst.iphmx.com ([216.71.154.45]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1grvKX-0002Zy-LT for linux-riscv@lists.infradead.org; Fri, 08 Feb 2019 01:51:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1549590709; x=1581126709; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=a5eO8iqcCF0fX5LzHmEyvUks9ILPsjzZwae5L7sLHgs=; b=eQaA2m/nwkQz1NjSzz1GRna2u66fHY7tXs/yhW2jNMjUyvSLgCwk8PGE PiE7AK2EUKzA6MYh9kXPtRdL7lYG42oL9gnkkcdHIlshdgjmn/v1FwfpD 0rWgGy2egLrZQuJUPj6M3588sZl3pNVW5Rvvf1QZ0C3a8MScFFSW/8ybF rg5aKql0DWKpMRWt4Dvi+f3IYWFF1GPNiLefgG3C3i8ZW5zomnCvs95es zEvXxVAXRoffxUE0XigoJtLdmKBmlpMRNildFrl11qXt+6IGIkWIGd2XF j0ayI4gPH1x495xWEjOU9VtQkdknQLQX7zk+ckYQ3anrQ0aNirSKHOB0X Q==; X-IronPort-AV: E=Sophos;i="5.58,346,1544457600"; d="scan'208";a="102533284" Received: from uls-op-cesaip01.wdc.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 08 Feb 2019 09:51:36 +0800 Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP; 07 Feb 2019 17:30:19 -0800 Received: from jedi-01.sdcorp.global.sandisk.com (HELO jedi-01.int.fusionio.com) ([10.11.143.218]) by uls-op-cesaip02.wdc.com with ESMTP; 07 Feb 2019 17:51:36 -0800 From: Atish Patra To: linux-riscv@lists.infradead.org Subject: [v3 PATCH 5/8] RISC-V: Compare cpuid with NR_CPUS before mapping. Date: Thu, 7 Feb 2019 17:51:18 -0800 Message-Id: <1549590681-24125-6-git-send-email-atish.patra@wdc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1549590681-24125-1-git-send-email-atish.patra@wdc.com> References: <1549590681-24125-1-git-send-email-atish.patra@wdc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190207_175149_940164_CA77258A X-CRM114-Status: UNSURE ( 9.91 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Patrick_St=C3=A4hlin?= , Albert Ou , Damien Le Moal , Jason Cooper , Alan Kao , Dmitriy Cherkasov , Anup Patel , Daniel Lezcano , linux-kernel@vger.kernel.org, Zong Li , Atish Patra , Palmer Dabbelt , Paul Walmsley , Andreas Schwab , Marc Zyngier , Thomas Gleixner MIME-Version: 1.0 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+patchwork-linux-riscv=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP We should never have a cpuid greater that NR_CPUS. Compare with NR_CPUS before creating the mapping between logical and physical CPU ids. This is also mandatory as NR_CPUS check is removed from riscv_of_processor_hartid. Signed-off-by: Atish Patra Reviewed-by: Anup Patel Reviewed-by: Christoph Hellwig --- arch/riscv/kernel/smpboot.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/arch/riscv/kernel/smpboot.c b/arch/riscv/kernel/smpboot.c index 669eb332..f120d325 100644 --- a/arch/riscv/kernel/smpboot.c +++ b/arch/riscv/kernel/smpboot.c @@ -66,6 +66,11 @@ void __init setup_smp(void) found_boot_cpu = 1; continue; } + if (cpuid >= NR_CPUS) { + pr_warn("Invalid cpuid [%d] for hartid [%d]\n", + cpuid, hart); + break; + } cpuid_to_hartid_map(cpuid) = hart; set_cpu_possible(cpuid, true);