| Message ID | 1558445574-16471-2-git-send-email-sagar.kadam@sifive.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Extend dt bindings to support I2C on sifive devices and a fix broken IRQ in polling mode. | expand |
> Required properties: > -- compatible : "opencores,i2c-ocores" or "aeroflexgaisler,i2cmst" > +- compatible : "opencores,i2c-ocores", > + "aeroflexgaisler,i2cmst", > + "sifive,fu540-c000-i2c","sifive,i2c0". > + For Opencore based I2C IP block reimplemented in It looks like there are some tabs vs space issues here. Andrew
Hi Andrew, On Tue, May 21, 2019 at 7:26 PM Andrew Lunn <andrew@lunn.ch> wrote: > > > Required properties: > > -- compatible : "opencores,i2c-ocores" or "aeroflexgaisler,i2cmst" > > +- compatible : "opencores,i2c-ocores", > > + "aeroflexgaisler,i2cmst", > > + "sifive,fu540-c000-i2c","sifive,i2c0". > > + For Opencore based I2C IP block reimplemented in > > It looks like there are some tabs vs space issues here. Ohh. It was not catched in checkpatch.pl. I will update it. Thanks, Sagar Kadam > Andrew
diff --git a/Documentation/devicetree/bindings/i2c/i2c-ocores.txt b/Documentation/devicetree/bindings/i2c/i2c-ocores.txt index 17bef9a..6ac062c 100644 --- a/Documentation/devicetree/bindings/i2c/i2c-ocores.txt +++ b/Documentation/devicetree/bindings/i2c/i2c-ocores.txt @@ -1,9 +1,13 @@ Device tree configuration for i2c-ocores Required properties: -- compatible : "opencores,i2c-ocores" or "aeroflexgaisler,i2cmst" +- compatible : "opencores,i2c-ocores", + "aeroflexgaisler,i2cmst", + "sifive,fu540-c000-i2c","sifive,i2c0". + For Opencore based I2C IP block reimplemented in + FU540-C000 SoC.Please refer sifive-blocks-ip-versioning.txt + for additional details. - reg : bus address start and address range size of device -- interrupts : interrupt number - clocks : handle to the controller clock; see the note below. Mutually exclusive with opencores,ip-clock-frequency - opencores,ip-clock-frequency: frequency of the controller clock in Hz; @@ -12,6 +16,7 @@ Required properties: - #size-cells : should be <0> Optional properties: +- interrupts : interrupt number. - clock-frequency : frequency of bus clock in Hz; see the note below. Defaults to 100 KHz when the property is not specified - reg-shift : device register offsets are shifted by this value
Reformatted compatibility strings to one valid combination on each line. Add FU540-C000 specific device tree bindings to already available i2-ocores file. This device is available on HiFive Unleashed Rev A00 board. Move interrupt under optional property list as this can be optional. The FU540-C000 SoC from sifive, has an Opencore's I2C block reimplementation. The DT compatibility string for this IP is present in HDL and available at. https://github.com/sifive/sifive-blocks/blob/master/src/main/scala/devices/i2c/I2C.scala#L73 Signed-off-by: Sagar Shrikant Kadam <sagar.kadam@sifive.com> --- Documentation/devicetree/bindings/i2c/i2c-ocores.txt | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)