From patchwork Sat May 9 10:24:12 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sagar Shrikant Kadam X-Patchwork-Id: 11538199 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9FE5714C0 for ; Sat, 9 May 2020 10:24:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 71F5F24958 for ; Sat, 9 May 2020 10:24:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CA9mJQZz"; dkim=pass (1024-bit key) header.d=sifive.com header.i=@sifive.com header.b="I0jwwVV9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 71F5F24958 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+patchwork-linux-riscv=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version: Content-Type:References:In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GT3UTH3unlFwims7hK3k+7BQPZIQauXuKeJKChl6ubs=; b=CA9mJQZzqwB2ggNuQBvEkVjWM wf1ZHQR8xWBNsPKdVpZN8RQ4Dgwl4U/UClMDR+4U20V8Z4bXlbxz7UbtOZLX9L6pyjql5E42dqFxC DznFNaHJYKbcsduylags8vgLLjPhRj+e1qbHCtJMlR34c0KZNyoDb7sYSeWY4O8lYyc36mxcsWiEa P8iQxNBiB52gQk8XeNN8OP04puZyFBv5kUg+r2Tpt9gxKx8E0ebGGqJ7uc79mmIE2JPkWao+HX+ep KKIU0XQysY5/L9p4eaPpeHcmqipsBncJpgFye5KBNYJ9p30KWzK091RkXL65sdRM04r06xZqZOYIA 4N5k5zPAw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jXMf5-0000S6-1I; Sat, 09 May 2020 10:24:51 +0000 Received: from mail-mw2nam12on2074.outbound.protection.outlook.com ([40.107.244.74] helo=NAM12-MW2-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jXMf2-0000QJ-8G for linux-riscv@lists.infradead.org; Sat, 09 May 2020 10:24:49 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EnKAZfOUlxTKvWkWD4MlOjB/2mZ8AiGyJRU8BfK65kA6DXDDkPVNlywJAFEfIcaLRGuoNuOvjPBFOLNndeXHeRqzwx6Bp3GtstPKyZp4Y65q1olJrmB7J7kaphI3XaJEERfEYBHhZ+OwgS+d/t5Yv8pymILlaKRHa6vI6noG2P9ls774QzuKkOJv8f5JizBLUe/aAYJNxlt5LMPvk5VnzwexcmtCfj6LbovJ8y24RmV06m5bqCnPZJLSZFLWyy2kFgT1pKIH2/44Z7ZLQ31jucnXW0iuT8K71hkoW0Q3caaSxGlZbFwH/CJwyOoxHwxRab0fWw2IKBVEMIvyiktrNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GT3UTH3unlFwims7hK3k+7BQPZIQauXuKeJKChl6ubs=; b=IzlDZG4okQbch/m0kAoFjbkOob3cF7CcTPF4argjT/maoU618IihEreptnikzINkhv29XzD8eDwP4qJOF7sz/y858OJoX+bwcv+OysGC8qoAsENa/x+AlcrVQBkQUxbTXmXLHYV5qLJbSUVTXijR4l+9V6wDtFUIwjCYD9RAeW5Acgz3IDwSYrpZyCp27TpHSQzM8h4RSr+DROikk7RGegUtkqga/OALpArNSU3PItspmFgbtJDhClBwEGYLMTfDkgioXQHNK0jj4ncGBWxjvLD7S/BK8XY9zu5HbPolaGcNZOM34XniIQ90IE3jnKtf5LEJB3PBUmZi+HboCUHx2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=sifive.com; dmarc=pass action=none header.from=sifive.com; dkim=pass header.d=sifive.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GT3UTH3unlFwims7hK3k+7BQPZIQauXuKeJKChl6ubs=; b=I0jwwVV9PiFDGjk9DyeCgTBzKyzv2J+1oGj8sslD8jVl8sFSvkaET/7xY49ET85EVICH4C/6Ypk3z2zMKGz0ZERWANwqpRxBSNE9GaJiJFRUTA8VB3FiDlfjk0xW4krMHKlMnHFF4OaBwH4Pec2WU24+qlgh+QvuCrarVSNC/sE= Authentication-Results: linuxfoundation.org; dkim=none (message not signed) header.d=none;linuxfoundation.org; dmarc=none action=none header.from=sifive.com; Received: from BN8PR13MB2611.namprd13.prod.outlook.com (2603:10b6:408:81::17) by BN8PR13MB2724.namprd13.prod.outlook.com (2603:10b6:408:83::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.13; Sat, 9 May 2020 10:24:43 +0000 Received: from BN8PR13MB2611.namprd13.prod.outlook.com ([fe80::c129:8fca:5ed:8929]) by BN8PR13MB2611.namprd13.prod.outlook.com ([fe80::c129:8fca:5ed:8929%6]) with mapi id 15.20.3000.011; Sat, 9 May 2020 10:24:43 +0000 From: Sagar Shrikant Kadam To: gregkh@linuxfoundation.org, linux-serial@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 1/1] tty: serial: add missing spin_lock_init for SiFive serial console Date: Sat, 9 May 2020 03:24:12 -0700 Message-Id: <1589019852-21505-2-git-send-email-sagar.kadam@sifive.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1589019852-21505-1-git-send-email-sagar.kadam@sifive.com> References: <1589019852-21505-1-git-send-email-sagar.kadam@sifive.com> X-ClientProxiedBy: BYAPR01CA0056.prod.exchangelabs.com (2603:10b6:a03:94::33) To BN8PR13MB2611.namprd13.prod.outlook.com (2603:10b6:408:81::17) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from gamma07.internal.sifive.com (64.62.193.194) by BYAPR01CA0056.prod.exchangelabs.com (2603:10b6:a03:94::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.2979.27 via Frontend Transport; Sat, 9 May 2020 10:24:42 +0000 X-Mailer: git-send-email 2.7.4 X-Originating-IP: [64.62.193.194] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2c2b23d0-35b2-456a-c621-08d7f403304b X-MS-TrafficTypeDiagnostic: BN8PR13MB2724: X-LD-Processed: 22f88e9d-ae0d-4ed9-b984-cdc9be1529f1,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4941; X-Forefront-PRVS: 03982FDC1D X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: l0sve2qwUV1ISg9tRM9XhDQ6c+lxkwq2TPsQ4kZkAe18bsZxaKmk61t5HmxLRrQSO/81Alg/x0CG7EabFMchdeo6YHP/0rnwJ5d2U5cacPrsDp65xUEVB0PMWK6T9N11Dj6cF5kSAqW8HE2/Jl3A9eiuK4DR7G4vkHJjY40WMQj+sb69FL1rhFzvu3YHiauxacZxl140qeW6kzWvYQeEuJzdpMBj8yqt2HbsR+7/2z66Xlu5lChazv193Y47CJIkAnsvnkIcyk9f0CZ9K17+okjOYJuDT97kJS+jsxoSBuCAfZXDbjq5YznJ5V6w6scyTS80t3HjhgGj5vDDW9tt5EikybVTXoCjBAFaa/K17EITrquSJXIYLO7EEaaUK0Zq1dvVaijwZgNKi25E9SEs8nsR90DqY7NxdtkPOkOoXlmQ+6XIrXhCYnGMyJ8TztZHfQfdgORUUxIBm55/8ZF5T17npCLJdnAmWmoeiLDWcuGTPDq+qN9nAAaCQXpfmec/0tLDYNpeDTGcsLDbOTdLEId2oz9/KLjAMBhcICe3gDjaeK8Zsez5oN+l4ROPW5IVvIasEMPzL7b97nCl4QVT76hKywooSfLuIkme4iPzGNU= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR13MB2611.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(6029001)(376002)(396003)(366004)(346002)(39840400004)(136003)(33430700001)(86362001)(8676002)(107886003)(8936002)(36756003)(4326008)(956004)(2616005)(4744005)(6486002)(186003)(16526019)(5660300002)(26005)(966005)(6666004)(316002)(478600001)(2906002)(66556008)(52116002)(66476007)(33440700001)(66946007)(7696005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: Dz4OezNYHZcProe9aSmZIKmxNvvkkf5Berzry4ILVCnvSyt1wETtwPfzp7OoSfatUiFAUX+XO7KwaEtHoz2D8Ece5F3HL1O9uL3/73+e6PF8NueI6gM2Bulj8inq3TC8EAckPxU5W5wDRlu+6Mt8pBq8GIlONUWZxFmf/LvZdmNgNQxJiqpwhWqyjUL0NFNFiNrQz6di5qm59HGJEpYeNSZJPbRUzJioOyhtazkei3mR00B06ANT9rVxT2eFrPs34N5PS71k1ncukIK0Hv2w0me8v6rctkU3uijFWP9ky4l7jT393dRtFPFpT5kHXLa5ok27dNYVdCPMtplOCCLJY2a5bv05XGRWASK1mddKeRUspvudEOuJIi+rUmEYrPF6jl3UiYLMk3BRh1PH+HgNP03R52iyszVLSHKL+pHITMJ69oZC1Kg/BCl3nzfu1DjnNfZ9h2J+QYQoBlYhXYnZrXoyeH47+jxkKhVIqhz652c= X-OriginatorOrg: sifive.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2c2b23d0-35b2-456a-c621-08d7f403304b X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2020 10:24:43.3053 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 22f88e9d-ae0d-4ed9-b984-cdc9be1529f1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: H47gJm8m8zHr61iGLTsk3vs2ykGtYznYrn5N0AUBmnLig8NRYjIjEFhAJs1hyV4gICmOCoVtILx2G7H/PE7G+g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR13MB2724 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200509_032448_292145_973F9976 X-CRM114-Status: UNSURE ( 8.58 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on bombadil.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [40.107.244.74 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [40.107.244.74 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 MSGID_FROM_MTA_HEADER Message-Id was added by a relay X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: aou@eecs.berkeley.edu, anup.patel@wdc.com, atish.patra@wdc.com, palmer@dabbelt.com, Sagar Shrikant Kadam , paul.walmsley@sifive.com Sender: "linux-riscv" Errors-To: linux-riscv-bounces+patchwork-linux-riscv=patchwork.kernel.org@lists.infradead.org An uninitialised spin lock for sifive serial console raises a bad magic spin_lock error as reported and discussed here [1]. Initialising the spin lock resolves the issue. The fix is tested on HiFive Unleashed A00 board with Linux 5.7-rc4 and OpenSBI v0.7 [1] https://lore.kernel.org/linux-riscv/b9fe49483a903f404e7acc15a6efbef756db28ae.camel@wdc.com Fixes: 45c054d0815b ("tty: serial: add driver for the SiFive UART") Reported-by: Atish Patra Signed-off-by: Sagar Shrikant Kadam Reviewed-by: Palmer Dabbelt Acked-by: Palmer Dabbelt --- drivers/tty/serial/sifive.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/tty/serial/sifive.c b/drivers/tty/serial/sifive.c index 13eadcb..0b5110d 100644 --- a/drivers/tty/serial/sifive.c +++ b/drivers/tty/serial/sifive.c @@ -883,6 +883,7 @@ console_initcall(sifive_console_init); static void __ssp_add_console_port(struct sifive_serial_port *ssp) { + spin_lock_init(&ssp->port.lock); sifive_serial_console_ports[ssp->port.line] = ssp; }