diff mbox series

riscv: only select serial sifive if TTY is enabled

Message ID 20191024072003.87116-1-wangkefeng.wang@huawei.com (mailing list archive)
State New, archived
Headers show
Series riscv: only select serial sifive if TTY is enabled | expand

Commit Message

Kefeng Wang Oct. 24, 2019, 7:20 a.m. UTC
There is some warning if TTY is not enabled, and lead to
build error, only select serial sifive if TTY enabled, and
this also makes randconfig happy.

Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
 arch/riscv/Kconfig.socs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Paul Walmsley Oct. 24, 2019, 4:12 p.m. UTC | #1
On Thu, 24 Oct 2019, Kefeng Wang wrote:

> There is some warning if TTY is not enabled, and lead to
> build error, only select serial sifive if TTY enabled, and
> this also makes randconfig happy.
> 
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>

Thanks for doing these randconfig tests!  Queued for v5.4-rc.


- Paul
Kefeng Wang Nov. 29, 2019, 6:47 a.m. UTC | #2
On 2019/10/25 0:12, Paul Walmsley wrote:
> On Thu, 24 Oct 2019, Kefeng Wang wrote:
> 
>> There is some warning if TTY is not enabled, and lead to
>> build error, only select serial sifive if TTY enabled, and
>> this also makes randconfig happy.
>>
>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> 
> Thanks for doing these randconfig tests!  Queued for v5.4-rc.

Hi Paul, this patch is not in v5.4 :)

> 
> 
> - Paul
> 
>
Paul Walmsley Dec. 9, 2019, 4:24 a.m. UTC | #3
Hi Kefeng Wang,

On Fri, 29 Nov 2019, Kefeng Wang wrote:

> On 2019/10/25 0:12, Paul Walmsley wrote:
> > On Thu, 24 Oct 2019, Kefeng Wang wrote:
> > 
> >> There is some warning if TTY is not enabled, and lead to
> >> build error, only select serial sifive if TTY enabled, and
> >> this also makes randconfig happy.
> >>
> >> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> > 
> > Thanks for doing these randconfig tests!  Queued for v5.4-rc.
> 
> Hi Paul, this patch is not in v5.4 :)

Sorry about that.  I've re-queued it for v5.5-rc.


- Paul
diff mbox series

Patch

diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs
index 536c0ef4aee8..c1043799e194 100644
--- a/arch/riscv/Kconfig.socs
+++ b/arch/riscv/Kconfig.socs
@@ -2,8 +2,8 @@  menu "SoC selection"
 
 config SOC_SIFIVE
        bool "SiFive SoCs"
-       select SERIAL_SIFIVE
-       select SERIAL_SIFIVE_CONSOLE
+       select SERIAL_SIFIVE if TTY
+       select SERIAL_SIFIVE_CONSOLE if TTY
        select CLK_SIFIVE
        select CLK_SIFIVE_FU540_PRCI
        select SIFIVE_PLIC