| Message ID | 20210920130248.145058-2-krzysztof.kozlowski@canonical.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [RESEND,v2,1/5] riscv: dts: sifive: use only generic JEDEC SPI NOR flash compatible | expand |
On 20/09/2021 15:02, Krzysztof Kozlowski wrote: > Add missing sifive,fu540 compatible to fix dtbs_check warnings: > > arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dt.yaml: /: compatible: 'oneOf' conditional failed, one must be fixed: > ['sifive,hifive-unleashed-a00', 'sifive,fu540-c000'] is too short > 'sifive,hifive-unleashed-a00' is not one of ['sifive,hifive-unmatched-a00'] > 'sifive,fu740-c000' was expected > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > > --- > > Changes since v1: > 1. None > --- > arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Anyone maintains RISC-V boards? I got no replies for the first patch, then for the second version and finally for the resend. If no one is interested, I'll pick it up. Best regards, Krzysztof
On Mon, Sep 20, 2021 at 3:05 PM Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> wrote: > > Add missing sifive,fu540 compatible to fix dtbs_check warnings: > > arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dt.yaml: /: compatible: 'oneOf' conditional failed, one must be fixed: > ['sifive,hifive-unleashed-a00', 'sifive,fu540-c000'] is too short > 'sifive,hifive-unleashed-a00' is not one of ['sifive,hifive-unmatched-a00'] > 'sifive,fu740-c000' was expected > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > > --- > > Changes since v1: > 1. None > --- > arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts > index 633b31b6e25c..2b4af7b4cc2f 100644 > --- a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts > +++ b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts > @@ -11,7 +11,8 @@ / { > #address-cells = <2>; > #size-cells = <2>; > model = "SiFive HiFive Unleashed A00"; > - compatible = "sifive,hifive-unleashed-a00", "sifive,fu540-c000"; > + compatible = "sifive,hifive-unleashed-a00", "sifive,fu540-c000", > + "sifive,fu540"; > > chosen { > stdout-path = "serial0"; > -- > 2.30.2 > > This looks good to me, you can add: Reviewed-by: Alexandre Ghiti <alexandre.ghiti@canonical.com> Tested-by: Alexandre Ghiti <alexandre.ghiti@canonical.com> Thanks, Alex > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv
diff --git a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts index 633b31b6e25c..2b4af7b4cc2f 100644 --- a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts +++ b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts @@ -11,7 +11,8 @@ / { #address-cells = <2>; #size-cells = <2>; model = "SiFive HiFive Unleashed A00"; - compatible = "sifive,hifive-unleashed-a00", "sifive,fu540-c000"; + compatible = "sifive,hifive-unleashed-a00", "sifive,fu540-c000", + "sifive,fu540"; chosen { stdout-path = "serial0";
Add missing sifive,fu540 compatible to fix dtbs_check warnings: arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dt.yaml: /: compatible: 'oneOf' conditional failed, one must be fixed: ['sifive,hifive-unleashed-a00', 'sifive,fu540-c000'] is too short 'sifive,hifive-unleashed-a00' is not one of ['sifive,hifive-unmatched-a00'] 'sifive,fu740-c000' was expected Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> --- Changes since v1: 1. None --- arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)