| Message ID | 20211108214629.1730870-1-aurelien@aurel32.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | riscv: dts: enable more DA9063 functions for the SiFive HiFive Unmatched | expand |
On Mon, 08 Nov 2021 13:46:29 PST (-0800), aurelien@aurel32.net wrote: > The DA9063 PMIC found on the SiFive HiFive Unmatched also provides an > RTC, a watchdog and the power button input. > > Signed-off-by: Aurelien Jarno <aurelien@aurel32.net> > --- > arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts > index 2e4ea84f27e7..c357b48582f7 100644 > --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts > +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts > @@ -70,6 +70,10 @@ pmic@58 { > interrupts = <1 IRQ_TYPE_LEVEL_LOW>; > interrupt-controller; > > + onkey { > + compatible = "dlg,da9063-onkey"; > + }; > + > regulators { > vdd_bcore1: bcore1 { > regulator-min-microvolt = <900000>; > @@ -205,6 +209,14 @@ vdd_ldo11: ldo11 { > regulator-always-on; > }; > }; > + > + rtc { > + compatible = "dlg,da9063-rtc"; > + }; > + > + wdt { > + compatible = "dlg,da9063-watchdog"; > + }; > }; > }; Thanks, this is on for-next.
On 2021-12-13 18:13, Palmer Dabbelt wrote: > On Mon, 08 Nov 2021 13:46:29 PST (-0800), aurelien@aurel32.net wrote: > > The DA9063 PMIC found on the SiFive HiFive Unmatched also provides an > > RTC, a watchdog and the power button input. > > > > Signed-off-by: Aurelien Jarno <aurelien@aurel32.net> > > --- > > arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts > > index 2e4ea84f27e7..c357b48582f7 100644 > > --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts > > +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts > > @@ -70,6 +70,10 @@ pmic@58 { > > interrupts = <1 IRQ_TYPE_LEVEL_LOW>; > > interrupt-controller; > > > > + onkey { > > + compatible = "dlg,da9063-onkey"; > > + }; > > + > > regulators { > > vdd_bcore1: bcore1 { > > regulator-min-microvolt = <900000>; > > @@ -205,6 +209,14 @@ vdd_ldo11: ldo11 { > > regulator-always-on; > > }; > > }; > > + > > + rtc { > > + compatible = "dlg,da9063-rtc"; > > + }; > > + > > + wdt { > > + compatible = "dlg,da9063-watchdog"; > > + }; > > }; > > }; Thanks. However, wouldn't be better to merged this patch and the whole series instead: http://lists.infradead.org/pipermail/linux-riscv/2021-November/010234.html Regards, Aurelien
On Tue, 14 Dec 2021 10:56:05 +0100, Aurelien Jarno <aurelien@aurel32.net> wrote: > On 2021-12-13 18:13, Palmer Dabbelt wrote: > > On Mon, 08 Nov 2021 13:46:29 PST (-0800), aurelien@aurel32.net wrote: > > > The DA9063 PMIC found on the SiFive HiFive Unmatched also provides an > > > RTC, a watchdog and the power button input. > > > > > > Signed-off-by: Aurelien Jarno <aurelien@aurel32.net> > > > --- > > > arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 12 ++++++++++++ > > > 1 file changed, 12 insertions(+) > > > > > > diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts > > > index 2e4ea84f27e7..c357b48582f7 100644 > > > --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts > > > +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts > > > @@ -70,6 +70,10 @@ pmic@58 { > > > interrupts = <1 IRQ_TYPE_LEVEL_LOW>; > > > interrupt-controller; > > > > > > + onkey { > > > + compatible = "dlg,da9063-onkey"; > > > + }; > > > + > > > regulators { > > > vdd_bcore1: bcore1 { > > > regulator-min-microvolt = <900000>; > > > @@ -205,6 +209,14 @@ vdd_ldo11: ldo11 { > > > regulator-always-on; > > > }; > > > }; > > > + > > > + rtc { > > > + compatible = "dlg,da9063-rtc"; > > > + }; > > > + > > > + wdt { > > > + compatible = "dlg,da9063-watchdog"; > > > + }; > > > }; > > > }; > > Thanks. However, wouldn't be better to merged this patch and the whole > series instead: > > http://lists.infradead.org/pipermail/linux-riscv/2021-November/010234.html My apologies about this, by the way: I had prepared that patch stack last summer and was witholding it until the IRQ-fires-only-once situation was resolved (it does affect at least the onkey subfunction, although in a non-obvious way when the event triggers a shutdown or a reboot). I did not think of checking recent submissions until it was too late.
diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts index 2e4ea84f27e7..c357b48582f7 100644 --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts @@ -70,6 +70,10 @@ pmic@58 { interrupts = <1 IRQ_TYPE_LEVEL_LOW>; interrupt-controller; + onkey { + compatible = "dlg,da9063-onkey"; + }; + regulators { vdd_bcore1: bcore1 { regulator-min-microvolt = <900000>; @@ -205,6 +209,14 @@ vdd_ldo11: ldo11 { regulator-always-on; }; }; + + rtc { + compatible = "dlg,da9063-rtc"; + }; + + wdt { + compatible = "dlg,da9063-watchdog"; + }; }; };
The DA9063 PMIC found on the SiFive HiFive Unmatched also provides an RTC, a watchdog and the power button input. Signed-off-by: Aurelien Jarno <aurelien@aurel32.net> --- arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 12 ++++++++++++ 1 file changed, 12 insertions(+)