Message ID | 20220805155405.1504081-6-mail@conchuod.ie (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | QEMU: Fix RISC-V virt & spike machines' dtbs | expand |
On Sat, Aug 6, 2022 at 2:02 AM Conor Dooley <mail@conchuod.ie> wrote: > > From: Conor Dooley <conor.dooley@microchip.com> > > "platform" is not a valid name for a bus node in dt-schema, so warnings > can be see in dt-validate on a dump of the riscv virt dtb: > > /stuff/qemu/qemu.dtb: platform@4000000: $nodename:0: 'platform@4000000' does not match '^([a-z][a-z0-9\\-]+-bus|bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$' > From schema: /home/conor/.local/lib/python3.9/site-packages/dtschema/schemas/simple-bus.yaml > "platform-bus" is a valid name, so use that instead. > > CC: Rob Herring <robh@kernel.org> > Fixes: 11d306b9df ("hw/arm/sysbus-fdt: helpers for platform bus nodes addition") > Signed-off-by: Conor Dooley <conor.dooley@microchip.com> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Alistair > --- > hw/core/sysbus-fdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/core/sysbus-fdt.c b/hw/core/sysbus-fdt.c > index 19d22cbe73..edb0c49b19 100644 > --- a/hw/core/sysbus-fdt.c > +++ b/hw/core/sysbus-fdt.c > @@ -539,7 +539,7 @@ void platform_bus_add_all_fdt_nodes(void *fdt, const char *intc, hwaddr addr, > > assert(fdt); > > - node = g_strdup_printf("/platform@%"PRIx64, addr); > + node = g_strdup_printf("/platform-bus@%"PRIx64, addr); > > /* Create a /platform node that we can put all devices into */ > qemu_fdt_add_subnode(fdt, node); > -- > 2.37.1 > >
diff --git a/hw/core/sysbus-fdt.c b/hw/core/sysbus-fdt.c index 19d22cbe73..edb0c49b19 100644 --- a/hw/core/sysbus-fdt.c +++ b/hw/core/sysbus-fdt.c @@ -539,7 +539,7 @@ void platform_bus_add_all_fdt_nodes(void *fdt, const char *intc, hwaddr addr, assert(fdt); - node = g_strdup_printf("/platform@%"PRIx64, addr); + node = g_strdup_printf("/platform-bus@%"PRIx64, addr); /* Create a /platform node that we can put all devices into */ qemu_fdt_add_subnode(fdt, node);