| Message ID | 20230221185603.570882-6-ajones@ventanamicro.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | riscv: alternative/cpufeature related cleanups | expand |
| Context | Check | Description |
|---|---|---|
| conchuod/cover_letter | success | Series has a cover letter |
| conchuod/fixes_present | success | Fixes tag not required for -next series |
| conchuod/maintainers_pattern | success | MAINTAINERS pattern errors before the patch: 13 and now 13 |
| conchuod/verify_signedoff | success | Signed-off-by tag matches author and committer |
| conchuod/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| conchuod/build_rv64_clang_allmodconfig | success | Errors and warnings before: 0 this patch: 0 |
| conchuod/module_param | success | Was 0 now: 0 |
| conchuod/build_rv64_gcc_allmodconfig | success | Errors and warnings before: 0 this patch: 0 |
| conchuod/alphanumeric_selects | success | Out of order selects before the patch: 727 and now 727 |
| conchuod/build_rv32_defconfig | success | Build OK |
| conchuod/dtb_warn_rv64 | success | Errors and warnings before: 2 this patch: 2 |
| conchuod/header_inline | success | No static functions without inline keyword in header files |
| conchuod/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 19 lines checked |
| conchuod/source_inline | success | Was 0 now: 0 |
| conchuod/build_rv64_nommu_k210_defconfig | success | Build OK |
| conchuod/verify_fixes | success | No Fixes tag |
| conchuod/build_rv64_nommu_virt_defconfig | success | Build OK |
| conchuod/tree_selection | fail | Failed to apply to next/pending-fixes or riscv/for-next |
On Tue, Feb 21, 2023 at 07:56:03PM +0100, Andrew Jones wrote: > Do some additional include pruning while dropping errata_list.h, > which is getting dropped, since cpufeature.c includes hwcap.h > directly to get cpufeature IDs. This commit message is a wee bit confusingly written. Not advocating for a respin by any means, but putting the thing that motivated the change before the opportunistic cleanups would have made more sense to me. /shrug Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > Signed-off-by: Andrew Jones <ajones@ventanamicro.com> > --- > arch/riscv/kernel/cpufeature.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/arch/riscv/kernel/cpufeature.c b/arch/riscv/kernel/cpufeature.c > index 85c99ae64017..151e1a715db9 100644 > --- a/arch/riscv/kernel/cpufeature.c > +++ b/arch/riscv/kernel/cpufeature.c > @@ -8,19 +8,14 @@ > > #include <linux/bitmap.h> > #include <linux/ctype.h> > -#include <linux/libfdt.h> > #include <linux/log2.h> > #include <linux/module.h> > #include <linux/of.h> > #include <asm/alternative.h> > #include <asm/cacheflush.h> > -#include <asm/errata_list.h> > #include <asm/hwcap.h> > #include <asm/patch.h> > -#include <asm/pgtable.h> > #include <asm/processor.h> > -#include <asm/smp.h> > -#include <asm/switch_to.h> > > #define NUM_ALPHA_EXTS ('z' - 'a' + 1) > > -- > 2.39.1 > > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv
On Thu, Feb 23, 2023 at 11:29:43PM +0000, Conor Dooley wrote: > On Tue, Feb 21, 2023 at 07:56:03PM +0100, Andrew Jones wrote: > > Do some additional include pruning while dropping errata_list.h, > > which is getting dropped, since cpufeature.c includes hwcap.h > > directly to get cpufeature IDs. > > This commit message is a wee bit confusingly written. Not advocating > for a respin by any means, but putting the thing that motivated the > change before the opportunistic cleanups would have made more sense to I'll rearrange the text for v2. > me. /shrug > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Thanks, drew > > > > Signed-off-by: Andrew Jones <ajones@ventanamicro.com> > > --- > > arch/riscv/kernel/cpufeature.c | 5 ----- > > 1 file changed, 5 deletions(-) > > > > diff --git a/arch/riscv/kernel/cpufeature.c b/arch/riscv/kernel/cpufeature.c > > index 85c99ae64017..151e1a715db9 100644 > > --- a/arch/riscv/kernel/cpufeature.c > > +++ b/arch/riscv/kernel/cpufeature.c > > @@ -8,19 +8,14 @@ > > > > #include <linux/bitmap.h> > > #include <linux/ctype.h> > > -#include <linux/libfdt.h> > > #include <linux/log2.h> > > #include <linux/module.h> > > #include <linux/of.h> > > #include <asm/alternative.h> > > #include <asm/cacheflush.h> > > -#include <asm/errata_list.h> > > #include <asm/hwcap.h> > > #include <asm/patch.h> > > -#include <asm/pgtable.h> > > #include <asm/processor.h> > > -#include <asm/smp.h> > > -#include <asm/switch_to.h> > > > > #define NUM_ALPHA_EXTS ('z' - 'a' + 1) > > > > -- > > 2.39.1 > > > > > > _______________________________________________ > > linux-riscv mailing list > > linux-riscv@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-riscv
Am Dienstag, 21. Februar 2023, 19:56:03 CET schrieb Andrew Jones: > Do some additional include pruning while dropping errata_list.h, > which is getting dropped, since cpufeature.c includes hwcap.h > directly to get cpufeature IDs. > > Signed-off-by: Andrew Jones <ajones@ventanamicro.com> Reviewed-by: Heiko Stuebner <heiko.stuebner@vrull.eu>
diff --git a/arch/riscv/kernel/cpufeature.c b/arch/riscv/kernel/cpufeature.c index 85c99ae64017..151e1a715db9 100644 --- a/arch/riscv/kernel/cpufeature.c +++ b/arch/riscv/kernel/cpufeature.c @@ -8,19 +8,14 @@ #include <linux/bitmap.h> #include <linux/ctype.h> -#include <linux/libfdt.h> #include <linux/log2.h> #include <linux/module.h> #include <linux/of.h> #include <asm/alternative.h> #include <asm/cacheflush.h> -#include <asm/errata_list.h> #include <asm/hwcap.h> #include <asm/patch.h> -#include <asm/pgtable.h> #include <asm/processor.h> -#include <asm/smp.h> -#include <asm/switch_to.h> #define NUM_ALPHA_EXTS ('z' - 'a' + 1)
Do some additional include pruning while dropping errata_list.h, which is getting dropped, since cpufeature.c includes hwcap.h directly to get cpufeature IDs. Signed-off-by: Andrew Jones <ajones@ventanamicro.com> --- arch/riscv/kernel/cpufeature.c | 5 ----- 1 file changed, 5 deletions(-)