diff mbox series

[1/2] RISC-V: KVM: Alphabetize selects

Message ID 20230322192858.1189272-2-ajones@ventanamicro.com (mailing list archive)
State Handled Elsewhere
Headers show
Series RISC-V: KVM: Require alternatives | expand

Checks

Context Check Description
conchuod/cover_letter success Series has a cover letter
conchuod/tree_selection success Guessed tree name to be fixes
conchuod/fixes_present success Fixes tag present in non-next series
conchuod/maintainers_pattern success MAINTAINERS pattern errors before the patch: 1 and now 1
conchuod/verify_signedoff success Signed-off-by tag matches author and committer
conchuod/kdoc success Errors and warnings before: 0 this patch: 0
conchuod/build_rv64_clang_allmodconfig success Errors and warnings before: 18 this patch: 18
conchuod/module_param success Was 0 now: 0
conchuod/build_rv64_gcc_allmodconfig success Errors and warnings before: 18 this patch: 18
conchuod/build_rv32_defconfig success Build OK
conchuod/dtb_warn_rv64 success Errors and warnings before: 3 this patch: 3
conchuod/header_inline success No static functions without inline keyword in header files
conchuod/checkpatch success total: 0 errors, 0 warnings, 0 checks, 19 lines checked
conchuod/source_inline success Was 0 now: 0
conchuod/build_rv64_nommu_k210_defconfig success Build OK
conchuod/verify_fixes success No Fixes tag
conchuod/build_rv64_nommu_virt_defconfig success Build OK

Commit Message

Andrew Jones March 22, 2023, 7:28 p.m. UTC
While alphabetized lists tend to become unalphabetized almost
as quickly as they get fixed up, it is preferred to keep select
lists in Kconfigs in order. Let's fix KVM's up.

Signed-off-by: Andrew Jones <ajones@ventanamicro.com>
---
 arch/riscv/kvm/Kconfig | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Comments

Anup Patel April 7, 2023, 11:47 a.m. UTC | #1
On Thu, Mar 23, 2023 at 12:59 AM Andrew Jones <ajones@ventanamicro.com> wrote:
>
> While alphabetized lists tend to become unalphabetized almost
> as quickly as they get fixed up, it is preferred to keep select
> lists in Kconfigs in order. Let's fix KVM's up.
>
> Signed-off-by: Andrew Jones <ajones@ventanamicro.com>

Reviewed-by: Anup Patel <anup@brainfault.org>

Queued this patch for Linux-6.4

Thanks,
Anup

> ---
>  arch/riscv/kvm/Kconfig | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/riscv/kvm/Kconfig b/arch/riscv/kvm/Kconfig
> index d5a658a047a7..5bcb2d519b95 100644
> --- a/arch/riscv/kvm/Kconfig
> +++ b/arch/riscv/kvm/Kconfig
> @@ -20,14 +20,14 @@ if VIRTUALIZATION
>  config KVM
>         tristate "Kernel-based Virtual Machine (KVM) support (EXPERIMENTAL)"
>         depends on RISCV_SBI && MMU
> +       select HAVE_KVM_EVENTFD
> +       select HAVE_KVM_VCPU_ASYNC_IOCTL
> +       select KVM_GENERIC_DIRTYLOG_READ_PROTECT
>         select KVM_GENERIC_HARDWARE_ENABLING
> -       select MMU_NOTIFIER
> -       select PREEMPT_NOTIFIERS
>         select KVM_MMIO
> -       select KVM_GENERIC_DIRTYLOG_READ_PROTECT
>         select KVM_XFER_TO_GUEST_WORK
> -       select HAVE_KVM_VCPU_ASYNC_IOCTL
> -       select HAVE_KVM_EVENTFD
> +       select MMU_NOTIFIER
> +       select PREEMPT_NOTIFIERS
>         select SRCU
>         help
>           Support hosting virtualized guest machines.
> --
> 2.39.2
>
diff mbox series

Patch

diff --git a/arch/riscv/kvm/Kconfig b/arch/riscv/kvm/Kconfig
index d5a658a047a7..5bcb2d519b95 100644
--- a/arch/riscv/kvm/Kconfig
+++ b/arch/riscv/kvm/Kconfig
@@ -20,14 +20,14 @@  if VIRTUALIZATION
 config KVM
 	tristate "Kernel-based Virtual Machine (KVM) support (EXPERIMENTAL)"
 	depends on RISCV_SBI && MMU
+	select HAVE_KVM_EVENTFD
+	select HAVE_KVM_VCPU_ASYNC_IOCTL
+	select KVM_GENERIC_DIRTYLOG_READ_PROTECT
 	select KVM_GENERIC_HARDWARE_ENABLING
-	select MMU_NOTIFIER
-	select PREEMPT_NOTIFIERS
 	select KVM_MMIO
-	select KVM_GENERIC_DIRTYLOG_READ_PROTECT
 	select KVM_XFER_TO_GUEST_WORK
-	select HAVE_KVM_VCPU_ASYNC_IOCTL
-	select HAVE_KVM_EVENTFD
+	select MMU_NOTIFIER
+	select PREEMPT_NOTIFIERS
 	select SRCU
 	help
 	  Support hosting virtualized guest machines.