| Message ID | 20230605110724.21391-21-andy.chiu@sifive.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 50724efcb370c61c64f75614763fb411e087f70c |
| Headers | show |
| Series | riscv: Add vector ISA support | expand |
| Context | Check | Description |
|---|---|---|
| conchuod/cover_letter | success | Series has a cover letter |
| conchuod/tree_selection | success | Guessed tree name to be for-next at HEAD 90502d51ab90 |
| conchuod/fixes_present | success | Fixes tag not required for -next series |
| conchuod/maintainers_pattern | success | MAINTAINERS pattern errors before the patch: 6 and now 6 |
| conchuod/verify_signedoff | success | Signed-off-by tag matches author and committer |
| conchuod/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| conchuod/build_rv64_clang_allmodconfig | success | Errors and warnings before: 2832 this patch: 2832 |
| conchuod/module_param | success | Was 0 now: 0 |
| conchuod/build_rv64_gcc_allmodconfig | success | Errors and warnings before: 16510 this patch: 16510 |
| conchuod/build_rv32_defconfig | success | Build OK |
| conchuod/dtb_warn_rv64 | success | Errors and warnings before: 3 this patch: 3 |
| conchuod/header_inline | success | No static functions without inline keyword in header files |
| conchuod/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 27 lines checked |
| conchuod/build_rv64_nommu_k210_defconfig | success | Build OK |
| conchuod/verify_fixes | success | No Fixes tag |
| conchuod/build_rv64_nommu_virt_defconfig | success | Build OK |
On Mon, Jun 05, 2023 at 11:07:17AM +0000, Andy Chiu wrote: > Using a function is flexible to represent ELF_HWCAP. So the kernel may > encode hwcap reflecting supported hardware features just at the moment of > the start of each program. > > This will be helpful when we introduce prctl/sysctl interface to control > per-process availability of Vector extension in following patches. > Programs started with V disabled should see V masked off in theirs > ELF_HWCAP. For the uninformed, like myself, this needs to be a function, rather than open coding the masking of the V bit at the one user of ELF_HWCAP this series adds, because the binfmt stuff needs to get the value in create_elf_fdpic_tables() & co? If that's your purpose, Reviewed-by: Conor Dooley <conor.dooley@microchip.com> One minor comment below. > > Signed-off-by: Andy Chiu <andy.chiu@sifive.com> > --- > arch/riscv/include/asm/elf.h | 2 +- > arch/riscv/include/asm/hwcap.h | 2 ++ > arch/riscv/kernel/cpufeature.c | 5 +++++ > 3 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/arch/riscv/include/asm/elf.h b/arch/riscv/include/asm/elf.h > index ca23c4f6c440..c24280774caf 100644 > --- a/arch/riscv/include/asm/elf.h > +++ b/arch/riscv/include/asm/elf.h > @@ -66,7 +66,7 @@ extern bool compat_elf_check_arch(Elf32_Ehdr *hdr); > * via a bitmap that coorespends to each single-letter ISA extension. This is > * essentially defunct, but will remain for compatibility with userspace. > */ > -#define ELF_HWCAP (elf_hwcap & ((1UL << RISCV_ISA_EXT_BASE) - 1)) > +#define ELF_HWCAP riscv_get_elf_hwcap() > extern unsigned long elf_hwcap; > > /* > diff --git a/arch/riscv/include/asm/hwcap.h b/arch/riscv/include/asm/hwcap.h > index 574385930ba7..e6c288ac4581 100644 > --- a/arch/riscv/include/asm/hwcap.h > +++ b/arch/riscv/include/asm/hwcap.h > @@ -61,6 +61,8 @@ > > #include <linux/jump_label.h> > > +unsigned long riscv_get_elf_hwcap(void); > + > struct riscv_isa_ext_data { > /* Name of the extension displayed to userspace via /proc/cpuinfo */ > char uprop[RISCV_ISA_EXT_NAME_LEN_MAX]; > diff --git a/arch/riscv/kernel/cpufeature.c b/arch/riscv/kernel/cpufeature.c > index 28032b083463..29c0680652a0 100644 > --- a/arch/riscv/kernel/cpufeature.c > +++ b/arch/riscv/kernel/cpufeature.c > @@ -293,6 +293,11 @@ void __init riscv_fill_hwcap(void) > pr_info("riscv: ELF capabilities %s\n", print_str); > } > > +unsigned long riscv_get_elf_hwcap(void) > +{ > + return (elf_hwcap & ((1UL << RISCV_ISA_EXT_BASE) - 1)); If you respin for some other reason, could you drop the open coded mask creation as part of these changes? Cheers, Conor. > +} > + > #ifdef CONFIG_RISCV_ALTERNATIVE > /* > * Alternative patch sites consider 48 bits when determining when to patch > -- > 2.17.1 > > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv
Le maanantaina 5. kesäkuuta 2023, 19.24.53 EEST Conor Dooley a écrit : > On Mon, Jun 05, 2023 at 11:07:17AM +0000, Andy Chiu wrote: > > Using a function is flexible to represent ELF_HWCAP. So the kernel may > > encode hwcap reflecting supported hardware features just at the moment of > > the start of each program. > > > > This will be helpful when we introduce prctl/sysctl interface to control > > per-process availability of Vector extension in following patches. > > Programs started with V disabled should see V masked off in theirs > > ELF_HWCAP. > > For the uninformed, like myself, this needs to be a function, rather > than open coding the masking of the V bit at the one user of ELF_HWCAP > this series adds, because the binfmt stuff needs to get the value in > create_elf_fdpic_tables() & co? No, this is to deal with existing userspace that expects vectors to "just work" when the V bit is set (e.g. FFmpeg 6.0).
On Mon, Jun 12, 2023 at 05:36:32PM +0300, Rémi Denis-Courmont wrote: > Le maanantaina 5. kesäkuuta 2023, 19.24.53 EEST Conor Dooley a écrit : > > On Mon, Jun 05, 2023 at 11:07:17AM +0000, Andy Chiu wrote: > > > Using a function is flexible to represent ELF_HWCAP. So the kernel may > > > encode hwcap reflecting supported hardware features just at the moment of > > > the start of each program. > > > > > > This will be helpful when we introduce prctl/sysctl interface to control > > > per-process availability of Vector extension in following patches. > > > Programs started with V disabled should see V masked off in theirs > > > ELF_HWCAP. > > > > For the uninformed, like myself, this needs to be a function, rather > > than open coding the masking of the V bit at the one user of ELF_HWCAP > > this series adds, because the binfmt stuff needs to get the value in > > create_elf_fdpic_tables() & co? > > No, this is to deal with existing userspace that expects vectors to "just > work" when the V bit is set (e.g. FFmpeg 6.0). Is that not what create_elf_fdpic_tables() & its ilk do? Inform userspace of whether the V bit is set? Cheers, Conor.
diff --git a/arch/riscv/include/asm/elf.h b/arch/riscv/include/asm/elf.h index ca23c4f6c440..c24280774caf 100644 --- a/arch/riscv/include/asm/elf.h +++ b/arch/riscv/include/asm/elf.h @@ -66,7 +66,7 @@ extern bool compat_elf_check_arch(Elf32_Ehdr *hdr); * via a bitmap that coorespends to each single-letter ISA extension. This is * essentially defunct, but will remain for compatibility with userspace. */ -#define ELF_HWCAP (elf_hwcap & ((1UL << RISCV_ISA_EXT_BASE) - 1)) +#define ELF_HWCAP riscv_get_elf_hwcap() extern unsigned long elf_hwcap; /* diff --git a/arch/riscv/include/asm/hwcap.h b/arch/riscv/include/asm/hwcap.h index 574385930ba7..e6c288ac4581 100644 --- a/arch/riscv/include/asm/hwcap.h +++ b/arch/riscv/include/asm/hwcap.h @@ -61,6 +61,8 @@ #include <linux/jump_label.h> +unsigned long riscv_get_elf_hwcap(void); + struct riscv_isa_ext_data { /* Name of the extension displayed to userspace via /proc/cpuinfo */ char uprop[RISCV_ISA_EXT_NAME_LEN_MAX]; diff --git a/arch/riscv/kernel/cpufeature.c b/arch/riscv/kernel/cpufeature.c index 28032b083463..29c0680652a0 100644 --- a/arch/riscv/kernel/cpufeature.c +++ b/arch/riscv/kernel/cpufeature.c @@ -293,6 +293,11 @@ void __init riscv_fill_hwcap(void) pr_info("riscv: ELF capabilities %s\n", print_str); } +unsigned long riscv_get_elf_hwcap(void) +{ + return (elf_hwcap & ((1UL << RISCV_ISA_EXT_BASE) - 1)); +} + #ifdef CONFIG_RISCV_ALTERNATIVE /* * Alternative patch sites consider 48 bits when determining when to patch
Using a function is flexible to represent ELF_HWCAP. So the kernel may encode hwcap reflecting supported hardware features just at the moment of the start of each program. This will be helpful when we introduce prctl/sysctl interface to control per-process availability of Vector extension in following patches. Programs started with V disabled should see V masked off in theirs ELF_HWCAP. Signed-off-by: Andy Chiu <andy.chiu@sifive.com> --- arch/riscv/include/asm/elf.h | 2 +- arch/riscv/include/asm/hwcap.h | 2 ++ arch/riscv/kernel/cpufeature.c | 5 +++++ 3 files changed, 8 insertions(+), 1 deletion(-)