From patchwork Fri Nov 10 15:30:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13452481 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0E087C4167D for ; Fri, 10 Nov 2023 15:31:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YXfAxk0XwxGap9Vtk+TWQdM9CAXCBBJFChfaGjjTrEY=; b=pbW5zR8rp1u5Pg CuzUrnYhkg8MN9DlCUsAvcrtfCU0qLAB4GsW6/6eNAQdNLMYKS+Z9gsOzNi49uON75nIQNubEOeww VcojhfceXLHUNvgy43Z3Zhv5Ns/K+SziH2Uzv+Yx4IWqoDrZ67UeUWEIXU1bqy76M7/yieuAxCxyt uJk1D39jXDJ3XCjanfuu6ViX+t772t7los8ktnQBP432YOca9Tr8mYw5ejZUDYzOV9/T372ZXaYXt 5oSABbDQL7N6gbbhYqH6Cr33hp36Z14ahSSPF6jd9diZsSGRXCG40brkVThAZjnu+qjUKckhIUmDW comqDd1W81VfDHAuXFEw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r1TTe-0090zw-12; Fri, 10 Nov 2023 15:31:22 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r1TTN-0090n1-1f for linux-riscv@lists.infradead.org; Fri, 10 Nov 2023 15:31:06 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r1TT7-0006Qj-6M; Fri, 10 Nov 2023 16:30:49 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r1TT5-0083L8-R0; Fri, 10 Nov 2023 16:30:47 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r1TT5-00GnxP-Hd; Fri, 10 Nov 2023 16:30:47 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Greg Kroah-Hartman , Jiri Slaby Cc: Palmer Dabbelt , Paul Walmsley , Ben Dooks , Nick Hu , Tobias Klauser , Samuel Holland , Ruan Jinjie , Thomas Gleixner , Yangtao Li , kernel@pengutronix.de, linux-serial@vger.kernel.org, linux-riscv@lists.infradead.org Subject: [PATCH 39/52] serial: sifive: Convert to platform remove callback returning void Date: Fri, 10 Nov 2023 16:30:07 +0100 Message-ID: <20231110152927.70601-40-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231110152927.70601-1-u.kleine-koenig@pengutronix.de> References: <20231110152927.70601-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2002; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=LLOyW1hbM0/SN58Bgrwns/zlLR/bVWIngKf4jnPWkd0=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlTkyJRJnUsGPDONa/lKdc3LcXHVgixiKyNcrZf Ql98Gr9N66JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZU5MiQAKCRCPgPtYfRL+ TtI5B/4jgW6OlsjFTMzan1QKVqk5oRoSVSC44upo/WbaxMGlfGN/boqM1VGFtDAFLsjZ3tXPa+E L0CvM1rrNsgOkjPdS/dtjtVLS5ZHDXfXn4kOlADqDTWrSkP3kT5Xgph78LFVtnAq6dl/LKkFefY sRsdi2Zh5llDfiODVzPLWwiqEPrK8GhmBwlJO08eRFNzMCWkwjHfKXRxpnL8csaB+8G3ub0bLUn +O+H8o6AZBu5dhvTgfmE0Rjd3IHHahBIOsizkso7yTGTEwFZSoTIFWmMRzB/JwOoN9WacIXb2lo 4NvBq/PRAnuzI/fENiGvcyYJEj84GuL1WFkffkO3X1Zvhvdf X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-riscv@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231110_073105_559962_9E520FA7 X-CRM114-Status: GOOD ( 16.02 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: Samuel Holland --- drivers/tty/serial/sifive.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/tty/serial/sifive.c b/drivers/tty/serial/sifive.c index b296e57a9dee..3541235a3ab6 100644 --- a/drivers/tty/serial/sifive.c +++ b/drivers/tty/serial/sifive.c @@ -1007,7 +1007,7 @@ static int sifive_serial_probe(struct platform_device *pdev) return r; } -static int sifive_serial_remove(struct platform_device *dev) +static void sifive_serial_remove(struct platform_device *dev) { struct sifive_serial_port *ssp = platform_get_drvdata(dev); @@ -1015,8 +1015,6 @@ static int sifive_serial_remove(struct platform_device *dev) uart_remove_one_port(&sifive_serial_uart_driver, &ssp->port); free_irq(ssp->port.irq, ssp); clk_notifier_unregister(ssp->clk, &ssp->clk_notifier); - - return 0; } static int sifive_serial_suspend(struct device *dev) @@ -1045,7 +1043,7 @@ MODULE_DEVICE_TABLE(of, sifive_serial_of_match); static struct platform_driver sifive_serial_platform_driver = { .probe = sifive_serial_probe, - .remove = sifive_serial_remove, + .remove_new = sifive_serial_remove, .driver = { .name = SIFIVE_SERIAL_NAME, .pm = pm_sleep_ptr(&sifive_uart_pm_ops),