From patchwork Thu Nov 30 12:56:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Lad, Prabhakar" X-Patchwork-Id: 13474363 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C5F16C4167B for ; Thu, 30 Nov 2023 12:56:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=3LoKveYZDyOESF+BjPwEwu6817kmQe2LtP14WCF41GA=; b=nhn4VYfHK9Mr/K fCpNboG7FI80y0dgZ933Rp/vhoJofd5chXhLZmtH/z/8XRyXKEXEtq0mlom5ZcxX28veoHisbHnR2 GUpe6+yaNzPV7TTPwO/f83rrJ25JGTjNz49X3ArM9T7qg56eiYI4HZn/6x8/pmUVUl/bBfnofRH4s SuiDtpko/A1j8RU8XLbcuiXuWFbCjD09lxScJSO9jlvPm1Go+mVc+Wgy9IwHmZN3/glKFhhmU3Hu1 Vezuzl5Yx48459cde+w6ssepisjDQzj+di8wU2cRe5gwbulRpdxnUZrkhaPh+PFZyw51C/UM/ohVS bQzcptqJemhHOdvV+4Kw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r8gau-00Av9P-0D; Thu, 30 Nov 2023 12:56:40 +0000 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r8gaq-00Av90-1h for linux-riscv@lists.infradead.org; Thu, 30 Nov 2023 12:56:38 +0000 Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-332fd78fa9dso567535f8f.3 for ; Thu, 30 Nov 2023 04:56:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701348994; x=1701953794; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=kyD+yl2bHZjrxQ6uqMRfoBj0ywuOG/6z0iIPw0pQbBM=; b=hOvSVgkccwR7jjFW7P66fRQcbAp+Q+xqbJm+uRRAtIhF4AKuzuW/d9NfiUki85drI9 Pej3orme0nSgyPCWgJWFkHfsVTFKh5Qk4iGJsDPm472eikU1Iozs0tcwv34dEhpN+hSu xgWj/j2dtpGapqpoATKGGSUDJWNAJb9nFeTOZTakmyZTWBuX/0q4mIVVePntTtcUrXcf 98UCk/RaPwl2tGmBMM0g6ySbiR7i91mR1mcbsurGn2eTPTubMOOepyKy8LwDEJA9aqC0 MfjOLZ6UwK77CnIIRnrdjVbkPGB3ndxgTA5PnrSSed6oDwbBDsb+jPUmh8sVZsizI1YD VOwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701348994; x=1701953794; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kyD+yl2bHZjrxQ6uqMRfoBj0ywuOG/6z0iIPw0pQbBM=; b=nWGe807qEKC/wNd2levtM0lySqBS55B/XmAuU5HIq4UDO/b8tQXxR8Xprt52L/b4+E 6MSMVhYasIvTUO18iY3BdkesLTrcbk4whegeoY1uvZ0qysvtI1suuNkbswAqK88ptOGs JmSZIHqq761sXOyyuJnV3sWsakJy2Fz/PcOGXN3t86F4ACQYpQGAkYCf1A8jk7ZmKJxt yi4nABDKi6/zOHrnmP616pjL9aPh7voOaDgObce6SfQAM1W5KbxHXxmyyg9R63uBLt7k 4RI1+YQGlsBRzhxarLYHG5V3aK6bv3KcPlWjKGp+gK1Ih5+cg2SYHObnMDZKAYAAbeAn NRVw== X-Gm-Message-State: AOJu0YxMe3eOjh7R27iXsDM4KoQssWwZVpuj+9hX0GLrolyCfQFCMsaL 5RIINVUtZF+6KZUBzpajp9w= X-Google-Smtp-Source: AGHT+IH7MbMZQhB4klE0BbfdgOc2EVNygz66QSdNWQ8VAEJy9K365/fx1q+fEAVewBWf1IDSVP1Hzw== X-Received: by 2002:adf:e841:0:b0:333:179:d8ef with SMTP id d1-20020adfe841000000b003330179d8efmr7830573wrn.24.1701348993691; Thu, 30 Nov 2023 04:56:33 -0800 (PST) Received: from prasmi.home ([2a00:23c8:2500:a01:3c2e:cd45:f50f:f083]) by smtp.gmail.com with ESMTPSA id t9-20020a5d6a49000000b0033172f984eesm1488463wrw.50.2023.11.30.04.56.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 04:56:33 -0800 (PST) From: Prabhakar X-Google-Original-From: Prabhakar To: Paul Walmsley , Palmer Dabbelt , Albert Ou , Conor Dooley , Geert Uytterhoeven Cc: Yu Chien Peter Lin , Samuel Holland , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Prabhakar , Biju Das , Lad Prabhakar Subject: [PATCH v2] riscv: errata: andes: Probe for IOCP only once in boot stage Date: Thu, 30 Nov 2023 12:56:06 +0000 Message-Id: <20231130125606.64931-1-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231130_045636_570367_61E02B95 X-CRM114-Status: GOOD ( 14.61 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org From: Lad Prabhakar We need to probe for IOCP only once during boot stage, as we were probing for IOCP for all the stages this caused the below issue during module-init stage, [9.019104] Unable to handle kernel paging request at virtual address ffffffff8100d3a0 [9.027153] Oops [#1] [9.029421] Modules linked in: rcar_canfd renesas_usbhs i2c_riic can_dev spi_rspi i2c_core [9.037686] CPU: 0 PID: 90 Comm: udevd Not tainted 6.7.0-rc1+ #57 [9.043756] Hardware name: Renesas SMARC EVK based on r9a07g043f01 (DT) [9.050339] epc : riscv_noncoherent_supported+0x10/0x3e [9.055558]  ra : andes_errata_patch_func+0x4a/0x52 [9.060418] epc : ffffffff8000d8c2 ra : ffffffff8000d95c sp : ffffffc8003abb00 [9.067607]  gp : ffffffff814e25a0 tp : ffffffd80361e540 t0 : 0000000000000000 [9.074795]  t1 : 000000000900031e t2 : 0000000000000001 s0 : ffffffc8003abb20 [9.081984]  s1 : ffffffff015b57c7 a0 : 0000000000000000 a1 : 0000000000000001 [9.089172]  a2 : 0000000000000000 a3 : 0000000000000000 a4 : ffffffff8100d8be [9.096360]  a5 : 0000000000000001 a6 : 0000000000000001 a7 : 000000000900031e [9.103548]  s2 : ffffffff015b57d7 s3 : 0000000000000001 s4 : 000000000000031e [9.110736]  s5 : 8000000000008a45 s6 : 0000000000000500 s7 : 000000000000003f [9.117924]  s8 : ffffffc8003abd48 s9 : ffffffff015b1140 s10: ffffffff8151a1b0 [9.125113]  s11: ffffffff015b1000 t3 : 0000000000000001 t4 : fefefefefefefeff [9.132301]  t5 : ffffffff015b57c7 t6 : ffffffd8b63a6000 [9.137587] status: 0000000200000120 badaddr: ffffffff8100d3a0 cause: 000000000000000f [9.145468] [] riscv_noncoherent_supported+0x10/0x3e [9.151972] [] _apply_alternatives+0x84/0x86 [9.157784] [] apply_module_alternatives+0x10/0x1a [9.164113] [] module_finalize+0x5e/0x7a [9.169583] [] load_module+0xfd8/0x179c [9.174965] [] init_module_from_file+0x76/0xaa [9.180948] [] __riscv_sys_finit_module+0x176/0x2a8 [9.187365] [] do_trap_ecall_u+0xbe/0x130 [9.192922] [] ret_from_exception+0x0/0x64 [9.198573] Code: 0009 b7e9 6797 014d a783 85a7 c799 4785 0717 0100 (0123) aef7 [9.205994] ---[ end trace 0000000000000000 ]--- This is because we called riscv_noncoherent_supported() for all the stages during IOCP probe. riscv_noncoherent_supported() function sets noncoherent_supported variable to true which has an annotation set to "__ro_after_init" due to which we were seeing the above splat. Fix this by probing for IOCP only once in boot stage by having a boolean variable is_iocp_probe_done which will be set to true upon IOCP probe in errata_probe_iocp() and we bail out early if is_iocp_probe_done is set. While at it make return type of errata_probe_iocp() to void as we were not checking the return value in andes_errata_patch_func(). Fixes: e021ae7f5145 ("riscv: errata: Add Andes alternative ports") Signed-off-by: Lad Prabhakar --- v1->v2 * As RISCV_ALTERNATIVES_BOOT stage can happen twice add a is_iocp_probe_done variable to probe for IOCP only once. * Updated commit message * Make return value of errata_probe_iocp() to void --- arch/riscv/errata/andes/errata.c | 23 +++++++++++++++-------- 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/arch/riscv/errata/andes/errata.c b/arch/riscv/errata/andes/errata.c index 197db68cc8da..b8eadb3b10d8 100644 --- a/arch/riscv/errata/andes/errata.c +++ b/arch/riscv/errata/andes/errata.c @@ -38,29 +38,36 @@ static long ax45mp_iocp_sw_workaround(void) return ret.error ? 0 : ret.value; } -static bool errata_probe_iocp(unsigned int stage, unsigned long arch_id, unsigned long impid) +static void errata_probe_iocp(unsigned int stage, unsigned long arch_id, unsigned long impid) { + static bool is_iocp_probe_done; + if (!IS_ENABLED(CONFIG_ERRATA_ANDES_CMO)) - return false; + return; + + if (is_iocp_probe_done) + return; if (arch_id != ANDESTECH_AX45MP_MARCHID || impid != ANDESTECH_AX45MP_MIMPID) - return false; + return; - if (!ax45mp_iocp_sw_workaround()) - return false; + if (!ax45mp_iocp_sw_workaround()) { + is_iocp_probe_done = true; + return; + } /* Set this just to make core cbo code happy */ riscv_cbom_block_size = 1; riscv_noncoherent_supported(); - - return true; + is_iocp_probe_done = true; } void __init_or_module andes_errata_patch_func(struct alt_entry *begin, struct alt_entry *end, unsigned long archid, unsigned long impid, unsigned int stage) { - errata_probe_iocp(stage, archid, impid); + if (stage == RISCV_ALTERNATIVES_BOOT) + errata_probe_iocp(stage, archid, impid); /* we have nothing to patch here ATM so just return back */ }