From patchwork Fri Dec 8 17:12:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Conor Dooley X-Patchwork-Id: 13485699 X-Patchwork-Delegate: mail@conchuod.ie Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 56867C10DC1 for ; Fri, 8 Dec 2023 17:13:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=H3FT7CfsqucBuJrcsvGHAtr+R53RhAO/1QP0htiztik=; b=0nIKNB7yTt5HhH tMdMUvbP8TmVu9CR+mk5IoCYz0GKH2cXGIaDrZsLI/UQ490DHeqJ8vOGRakAfbuZUNlaMzjN6sMfX /vXKeGwvVYSWoJqcMX879FEIkph4oZvyesBTY596B2M7heavfzwrGTFyd2El1ni58I+hb6/jEPbOy YnGIDpd+uzuw1EN2Avjdyk+jxZzAyzV/9TOH/G4ueKSdL2PqVKliYYLfmNuBqyBjmhPqlJ/Nf22Vy XEdAHXVmvWGdqplC4zzKr7345T1dHrg4JjBxrELw4I9rLP4ghmzxzFaKbuQ+xIMtlL9B+QG4FSilR A9cXNs6dyUC59nW47RrQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rBePR-00G8Wf-0D; Fri, 08 Dec 2023 17:13:05 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rBePO-00G8VB-0R for linux-riscv@lists.infradead.org; Fri, 08 Dec 2023 17:13:04 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id A4C0C62526; Fri, 8 Dec 2023 17:13:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 56995C433B9; Fri, 8 Dec 2023 17:12:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702055581; bh=eOwkSq/WwMGsBDJxIoKyyiwasgmQQYpNauvY4yRRwsE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KHk8a5tZwx6HzsT8T5BnndKAcsPltUq64Ek4Pr5fovixj2Aq/i9OEQXYhY+w6CuIB iQ713l1de5Asz5Ax4hK6RGHX7DC9QEYGeaWRNgbiDq3hDTLN7j1D5mgaj0jjqzZ7Xu 1aB87nlMv7p+TlIYR4E4rcHY/JiUJpxGIg++fsAWcK87pRUKQYMBgZHsDiDJ5g+U8/ GtwCtIK7kY0TJZE4KCj4b6NFP89gICI5qYZkGl0Ja20tWFXDy8Y3/wQVROVliaZjzC KkeyJScyQ+CQ8bkVKg1sPQwblR2SFrf4hHKg9DAsw6n0GcGtDVGerkBdQMiMAiG08l NfWbBDmM8zYqQ== From: Conor Dooley To: linux-riscv@lists.infradead.org Cc: conor@kernel.org, Conor Dooley , Daire McNamara , Wolfgang Grandegger , Marc Kleine-Budde , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Michael Turquette , Stephen Boyd , linux-can@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Subject: [PATCH RESEND v1 2/7] dt-bindings: can: mpfs: add missing required clock Date: Fri, 8 Dec 2023 17:12:24 +0000 Message-Id: <20231208-palpitate-passable-c79bacf2036c@spud> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231208-reenter-ajar-b6223e5134b3@spud> References: <20231208-reenter-ajar-b6223e5134b3@spud> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1442; i=conor.dooley@microchip.com; h=from:subject:message-id; bh=t/lsdJsWux+0djN2ESjLKlgMF40rkcl8R8FM1XRhzgA=; b=owGbwMvMwCFWscWwfUFT0iXG02pJDKnFfuUPWvbyRO6Tbtj3XqD4/x2h2j8HPA3+TjArX7qZR 3nqsvs/O0pZGMQ4GGTFFFkSb/e1SK3/47LDuectzBxWJpAhDFycAjCR9GaGP9yJsZf/zW2rSddd 9SykPKmwPsXIv9vR85b+VLVjN0PVQxn++zcH+hXx6GgvW2xp8sDt9Pna46/0LFtPtVv3PxGL+zW bAQA= X-Developer-Key: i=conor.dooley@microchip.com; a=openpgp; fpr=F9ECA03CF54F12CD01F1655722E2C55B37CF380C X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231208_091302_259851_95DC5D44 X-CRM114-Status: UNSURE ( 9.49 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org From: Conor Dooley The CAN controller on PolarFire SoC has an AHB peripheral clock _and_ a CAN bus clock. The bus clock was omitted when the binding was written, but is required for operation. Make up for lost time and add it. Cautionary tale in adding bindings without having implemented a real user for them perhaps. Fixes: c878d518d7b6 ("dt-bindings: can: mpfs: document the mpfs CAN controller") Signed-off-by: Conor Dooley --- .../devicetree/bindings/net/can/microchip,mpfs-can.yaml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml b/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml index 45aa3de7cf01..05f680f15b17 100644 --- a/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml +++ b/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml @@ -24,7 +24,10 @@ properties: maxItems: 1 clocks: - maxItems: 1 + maxItems: 2 + items: + - description: AHB peripheral clock + - description: CAN bus clock required: - compatible @@ -39,7 +42,7 @@ examples: can@2010c000 { compatible = "microchip,mpfs-can"; reg = <0x2010c000 0x1000>; - clocks = <&clkcfg 17>; + clocks = <&clkcfg 17>, <&clkcfg 37>; interrupt-parent = <&plic>; interrupts = <56>; };