From patchwork Wed May 1 12:56:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13650639 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 77E6BC10F1A for ; Wed, 1 May 2024 12:50:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To:In-Reply-To: References:Message-Id:Subject:Date:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=fH139/Id/u/YX5nGJjmMK6BH0PzNfsOYFmoOeshFzrw=; b=MRJwwumgYl7dhL0yC+SvNPtd1w eQ3q091upVGhOWd9ngFKqCeycZ1MhDW5FVgBzgxBDJBPsMdeiRUMCxGs180/dT5zvXSQ2/Ud0+F1X E7oIVk/MokfEBsZmhIURuMYOy6y2QZ0Asy2+zjVBWr5Scc6K7VrwTbftOayNbrT+agU4A1Vyn6g4f jmHXS1Ua/huhddupdLE9F5Lsp/R0tmYLsWGbQLa9Vxysvc+k1Twl/mW8VvEyJa7ivi+4UF+nccR7t eMyZ2oQNgAeqbQM4gpcOobaxJmwHPJ6oCF15z9ugCnYxvuovtR/nz5cX0GuEJ+NAMN7UHQAxKA2BN PEGMUY3w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s29PX-00000009YzC-2TRK; Wed, 01 May 2024 12:50:11 +0000 Received: from mail-he1eur01on0610.outbound.protection.outlook.com ([2a01:111:f400:fe1e::610] helo=EUR01-HE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s29PQ-00000009YtM-3n5t; Wed, 01 May 2024 12:50:07 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Lhv1eTm7xvunKW9nrQbYUw6o64/7RgXliZ2QCHTS2bxKvyHLwGFdX8dPqYPu1CDauO46kyGkV2lBJExChqWL+4+PAak0QMpvgTnwWB8AFNItcVpNEB8aDVq9mU8s5PLmUhxTpKWe4MWkf/T+Qy6Uz+QDfqQPC8v4QdklsHoPaQj2HPzl3EiC3GtD+WsKnayB2P+KLLyaPq4pPpGJvwWWWroYVH6fSe4Kld0KBPzn61688C0sZ7mFY9N4Wj3JafYW8RuOyoYUqoMJPa1z/DkQ4RdIajWMAq8dalZJlmmGNQ+9L+0rWt21ifKfGSYZBglaCAHlYHFxymjUGEyrMrlWrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Wlbn/xB/PZwPV7ROj5DqSEALVDss+DndXNnPfNwAESg=; b=kB1mwpdK6vW/OhPu1g5ZbbKKvNxrjbcs55N4d+z5FtBYh9KUvOI9mjriAdo9Skj/jBM38nlr+Sn3qSlGX7nkKcksYEwDb4znJEMUlraiUbLiFCIzWhxB5mO4XVeq8p674RX/Gki01hBCd/Byo+qrXszWHM46QPFjT/MwhZfjWzWKmYTA38Nvr1yeNFsrJ6BBVYkAmDUVpI7Hjc9YyW2Jtg7tlsn0lbIoM7jZcmR7M6quIFev291wVv7HH8LIpBoN9rOSsyfzripn54xlFpTxULydO7al2z7R5FHt0PmBBzBl5IBaVkRayXn/ikKDBhqQYxpuYHIwyut8M1fg3kZDCA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Wlbn/xB/PZwPV7ROj5DqSEALVDss+DndXNnPfNwAESg=; b=mP2fBb9II0l3GeKaliashAz8NJejLF3MK/r6w9BzUaDj/X7zXYHKb9x7HauCtaXpmfJo4FZbTXSn7gjfjmn9uRwzxSaQkiNJEtqxirHEfdcLS0A014uAFHK3GXynGnojTaoEziZLFfs8+i77ybXaQH37okheUM/Xg4Y9+IgXUS8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by DBAPR04MB7448.eurprd04.prod.outlook.com (2603:10a6:10:1a6::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.38; Wed, 1 May 2024 12:49:59 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d%4]) with mapi id 15.20.7519.031; Wed, 1 May 2024 12:49:59 +0000 From: "Peng Fan (OSS)" Date: Wed, 01 May 2024 20:56:04 +0800 Subject: [PATCH 06/21] pinctrl: sprd: Use scope based of_node_put() cleanups Message-Id: <20240501-pinctrl-cleanup-v1-6-797ceca46e5c@nxp.com> References: <20240501-pinctrl-cleanup-v1-0-797ceca46e5c@nxp.com> In-Reply-To: <20240501-pinctrl-cleanup-v1-0-797ceca46e5c@nxp.com> To: Linus Walleij , Thierry Reding , Jonathan Hunter , Dvorkin Dmitry , Wells Lu , Maxime Coquelin , Alexandre Torgue , Emil Renner Berthing , Jianlong Huang , Hal Feng , Orson Zhai , Baolin Wang , Chunyan Zhang , Viresh Kumar , Shiraz Hashim , soc@kernel.org, Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar , Geert Uytterhoeven , Patrice Chotard , Heiko Stuebner , Damien Le Moal , Ludovic Desroches , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Dong Aisheng , Fabio Estevam , Shawn Guo , Jacky Bai , Pengutronix Kernel Team , Chester Lin , Matthias Brugger , Ghennadi Procopciuc , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Sascha Hauer , Andrew Jeffery , Joel Stanley , Dan Carpenter Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, linux-mediatek@lists.infradead.org, imx@lists.linux.dev, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, Peng Fan X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1714568179; l=1540; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=BMqLHOrX8EQjg9Z3uUGPLv8QrQVTIzjrj8QOQ3y5znM=; b=uzJS94q3JPQHLA5Dfym/hBeiB+V5HFBQEhABQJBlklJZsJPGzVQEg5YpRg/g13KZh31C77PmN EFur8rCNveRAK/bhsPtw3a3Fbhh+KOPCez1GBrD/0yhQsXLFPZg8lzr X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2PR02CA0064.apcprd02.prod.outlook.com (2603:1096:4:54::28) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|DBAPR04MB7448:EE_ X-MS-Office365-Filtering-Correlation-Id: 13bd78cd-48a6-4e37-ac13-08dc69dd35f2 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|1800799015|376005|7416005|52116005|366007|921011|38350700005; X-Microsoft-Antispam-Message-Info: =?utf-8?q?OnqtqR8vLs4FBneMNgR4jcfKkFz4uNe?= =?utf-8?q?AkMhIoRnUC4GWmY5GFW0ByjTYZ+fkYbBokuyO0YMNT/6A9KkYG53yikYVAJWfupxQ?= =?utf-8?q?eGPMhVxg2j5Bq7rA0zdjvcnUb/xcIoiElq2NQEjz5Kj+tKyTns3DjE7R2lUxDAmay?= =?utf-8?q?7Mp8mpr2ahTWZ+sv+8hjPzh5Q046FA/aRd+a+20JetkDjMzKj5futSncW5bLpwA8/?= =?utf-8?q?7ZgCrpfxCKxYkdMl3RbBAaiTNfvgHnz+nJSrT3F26m0fZXvwHs/Rxfdsu70PuOZzR?= =?utf-8?q?s1EPujYNYrC/mIeo9vAVJ2aD0UyFffDlbzOlpic56vCQQFM+ESq764atz2IXmAD77?= =?utf-8?q?EIRkK+WopaA/talzPsWObPLos629jSQo1V5xBjLFTt1oQNmEXY7OncMyYciZVg6Wv?= =?utf-8?q?96oGq5ei8CUg5r4egAU8/u09THxaceK/g0wC7N58jXr6lrcqfo7ZuNYPDMiQfXh1/?= =?utf-8?q?7bRobp/tTuHjg31vV1IEsyapUpThGz8+dJ9BjxqaVYJdqlEYMDHCoHkjjXBQ0XYga?= =?utf-8?q?3TEX9/EX9UVfdJPzrNIWTEyZplu3UOHW9SCiIPi/MpC+WksDFIn/kkkOdqwlLSzOx?= =?utf-8?q?I5MI5Lazb5rVpl9Bus+m4667UosuxusGxCdUY+RrfYwBcwIMV9V8TUJ6/6Ms6VPAB?= =?utf-8?q?8ue7PplUUUoK7xyk9lWBn4lWBFRiGkqZjommIZaJNIw7bfdsBD8tljxxPSNWR/Pfm?= =?utf-8?q?iUdwm+PURT+cHVh/aXPm1FyIPpLNqnEHSXxcENiGa5pcBnO0CrAxR0OwwgWlY5ARe?= =?utf-8?q?YT1MUzX4+uaPEcJ0RjhJKxkCKiF3TJ7JY6lg2KJJyVGdzaHbBAuOw3HklFEziPDXN?= =?utf-8?q?onbVf4QmEsGAM6f2SAtPLqBbsAq9fD70LI1G1RmzQn2g7RDUOPsArcguKU5Xo2D30?= =?utf-8?q?5WhFXVwnMGEwDmy1osup9beSAdhfaUA2auFdydQBa0YfnR5iYJrWI7kpmtdDcV+Sn?= =?utf-8?q?v1gzGNhbrdDT+B+WFmuiQKmakyDz4wwrwEHbiOD0d08nNks4CntEDbkZPIYpjWF0o?= =?utf-8?q?kapmeGAAHanYvRnnkdhQsqq9QC0QDYlMcE320v0mEfoiEa1jD5f9nxtmz9/2rgyM8?= =?utf-8?q?pvOMcROvt3DxotQ7VLAJNsH6jYfKxA3nZQOv0vIkR/fwKBYZEOkEzwC5/kZpJ5D0K?= =?utf-8?q?dtKi8u6cWbyedfor+xrdJzhrAvjnh8u/JmcAPLDqpjUleF8HyWZMwlhlz2O8AFxAw?= =?utf-8?q?Oqwrynzp698/DOsyDu4DalKzR0waA+OUw6e56pKECMRtT7J2F8TwKGnckrbY8NRsC?= =?utf-8?q?THl4+bPSeCLzwgAflhsv7YJxb4LXHRfyZiQiZTyAIZ2iQdkdKxJlaJQs=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(376005)(7416005)(52116005)(366007)(921011)(38350700005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?MrYGaGW1Lf9TiwBBpYkbNlAmwnQ4?= =?utf-8?q?ftJdJQ7lWtCmW6jK9T5vJb5tGhs4Qy5FAuP2LthqOS45MEltwMgd1Vs6yVEgMmVFJ?= =?utf-8?q?cee2IY7PiY2WeFsBjlTIyieME/QOoeeLK+mtmANRrT2dD99CrxF4u9ynuHG6n3Pji?= =?utf-8?q?PwhIOPmtUdMb211PsJKmv5KCQYOW4EhkeXb14SPx5fQOpS0KbDXphdI5Fgz5IrR8N?= =?utf-8?q?dDNPdCijMjFjIu9YEwSiIa3owIdMWLf7lnE8wSnjAK50+6EQnnN6G72MoNv1DiSvo?= =?utf-8?q?efxMqg47sRJvWgoWzIQubaHudFSNwq9v5Cb9jhwarFD4h6INO9ci6Al5oY04VkBi1?= =?utf-8?q?9ETzWBSxNnwLRTAJWlZIrPmPeFLsj3dPCU22NFcdA66nVoaRV6CKCyIr1ZPr0MbTA?= =?utf-8?q?UHqOtw65+YZiq2czGv2Xjyrx+cn6sEo5TY0y0g4vSG5Tk2+UD0okg6ZHatohkqGp7?= =?utf-8?q?4mzr155wkiMSRhaC0vFs+URwAqUMve4vJcQVP3wpQXZrrDSwGRhfj4U1duhlYFReo?= =?utf-8?q?wDN7j2IDC/eIXt2pSjpreUENU502bP657JbLOvG3/l3wzD3/gD67JqBZybpjbxq9x?= =?utf-8?q?TkK/HqHHmlM8GwmLYaABmBw35T4AnTeM5nQpRcia5FAHSACBs1Q0n4dXjMRgWzRip?= =?utf-8?q?HoNiulzDGMAB1oI+S2lANtQRXXrf8OCnnN6jWxiuXok42kt+tNBi8at5t9KISudHH?= =?utf-8?q?zqWso0dtWrUr7JW9HlRoIA8ao/7/zsSYjL1KBScKvEeZtcvTQE6JsvdNjKIj06LJK?= =?utf-8?q?yLSGActe4RUsphhP0O3ugiSS7Y3N4hLx5IjNAVRdL2KdB0h8Vi0wGAOAjm+C77TTm?= =?utf-8?q?UCwi+Pn8H+R7+uHsNvIlvB07SHPi4wZBA1cFrdCE5vyJ1ik5Sm7+C8PIIsZZCdaPi?= =?utf-8?q?xArvNpWv5V3RlSlVyRYMt3XmaJOgsQth8J161PMblOzcR7NC4p/ksoUg2ghYJ9LV4?= =?utf-8?q?ccdQd5ugd70pLzACbvRSBqd3EwS+NFxL7H/frcdtVqhGJ1X22Td8i1RIIEfFlLWZ1?= =?utf-8?q?5pE0hlYTPpW8Il1Mu726YfnLuSrK6gl7eV7bkMcyQIB3OwWfoCNkxiW+VFQbqQ6lT?= =?utf-8?q?PeDMNl0iw5R8ooajaBcRlyrTCEKjCksqJ2CzZvjA9+JuYSrj++UmGNlbNaSjizfyf?= =?utf-8?q?m0lU+RvJkiaJHsHFI3mz4K3cUHrFjLJIhh/ag6ZgSf+aq5CUxfTbWyJdNoFVOMUDr?= =?utf-8?q?DeAE0mh7aUrfM/K2iWKqxTj0xwhzzDXEYidBIWftimJiZHvliHdg2RLqWIqskVzJb?= =?utf-8?q?Uy54/PmWQHtqYo2+Whm3uXgKZFO4ltP7VCfx7OckfDsqmRwtjz98r2wiDnczBpP6g?= =?utf-8?q?dDkLiFYw9DnDd8djnjObmRD6IIBChcfpa9Ovehb+j/FkSqc1xd0C7ZmR5Z51QMAQt?= =?utf-8?q?79VigI5b8YvIKpAq6PppjP89ztsb7hKvNW7praJKvErC0qxO0NI7LqW37VePUyRCu?= =?utf-8?q?H6V9gGbexU3BDp7Gx8VqKaWTGeS98fBFbLKWaZwRcuGYgOfoazcXojaxbn/DfModT?= =?utf-8?q?kmMKq5aeVstd?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 13bd78cd-48a6-4e37-ac13-08dc69dd35f2 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 May 2024 12:49:59.4572 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HQwUUTKPiQihfGdhaJ3Zux5//CziSv+w5sPrXRinOo0DZZHN5lFE9uUBlB+TKIp6YSfoLdBBKWRlLQOu//Ngug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7448 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240501_055005_073779_1FD6D42D X-CRM114-Status: GOOD ( 10.56 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org From: Peng Fan Use scope based of_node_put() cleanup to simplify code. Signed-off-by: Peng Fan --- drivers/pinctrl/sprd/pinctrl-sprd.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/pinctrl/sprd/pinctrl-sprd.c b/drivers/pinctrl/sprd/pinctrl-sprd.c index d0b6d3e655a2..c4a1d99dfed0 100644 --- a/drivers/pinctrl/sprd/pinctrl-sprd.c +++ b/drivers/pinctrl/sprd/pinctrl-sprd.c @@ -934,7 +934,6 @@ static int sprd_pinctrl_parse_dt(struct sprd_pinctrl *sprd_pctl) { struct sprd_pinctrl_soc_info *info = sprd_pctl->info; struct device_node *np = sprd_pctl->dev->of_node; - struct device_node *child, *sub_child; struct sprd_pin_group *grp; const char **temp; int ret; @@ -962,25 +961,20 @@ static int sprd_pinctrl_parse_dt(struct sprd_pinctrl *sprd_pctl) temp = info->grp_names; grp = info->groups; - for_each_child_of_node(np, child) { + for_each_child_of_node_scoped(np, child) { ret = sprd_pinctrl_parse_groups(child, sprd_pctl, grp); - if (ret) { - of_node_put(child); + if (ret) return ret; - } *temp++ = grp->name; grp++; if (of_get_child_count(child) > 0) { - for_each_child_of_node(child, sub_child) { + for_each_child_of_node_scoped(child, sub_child) { ret = sprd_pinctrl_parse_groups(sub_child, sprd_pctl, grp); - if (ret) { - of_node_put(sub_child); - of_node_put(child); + if (ret) return ret; - } *temp++ = grp->name; grp++;